From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7657C433F5 for ; Thu, 31 Mar 2022 20:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241437AbiCaUc0 (ORCPT ); Thu, 31 Mar 2022 16:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241434AbiCaUcV (ORCPT ); Thu, 31 Mar 2022 16:32:21 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F4B5577F for ; Thu, 31 Mar 2022 13:30:33 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id yy13so1731803ejb.2 for ; Thu, 31 Mar 2022 13:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=WnVDLK0fuVXet24goRyLeC09oaPRTS1cEiuOv9qpnzg=; b=xz4HmeCzQcf0bKScHWhvla+V2E7vgHeOrWNrab8oEGJzRpkOogwYZLg8l4nYxn7PGI DnSi7BcukvWTBLE1pQB9Al6zKPKetCxY1DMQ6jIlZNyQGsZlA+3jLPbZ97e20sb/L6k/ jru7po9wvWWn2ZtoPjQoAkNlyURKBUV9JRU8R9qubnXxwjbbhkLVg0YUUl3VhKebG4zg 5WLG1S4pyKhOY9Z/wRIFD0gr/ZGaoLsYa1JAF8LgBG4Xe7folO0xkJoq+BXzt9gX4zd+ j7HgDQSgbhnStRnEGu26upop8BWlyGxOqyLzZNdKPTqj/un11jX7rsTJM6d2WH1MtZkD X7UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WnVDLK0fuVXet24goRyLeC09oaPRTS1cEiuOv9qpnzg=; b=saS/ZvGV1J5UB1gqUzrjg9/Ih2lrRJccK2SrlW5du5a5HfrQS9Z3COVwhFk0YKz/Wr M8Tz65lqFVxQQ44Muy7oWFgXsrN+acFuAG+eubpBhwvEjvncsl97tVuyNez9JE68xRu4 bxHExU8GtUSB0JWiCzBBHANGXMPjLoH/SE0nXz1zoySV2FFFDJVYrtaXcJI4rR8DAsnw BKklyCU1cO7dvqgos494+HzCm1Bjvk5tVDlUlfROHkxStF78km72A1egSNKRPDPmjCqR 9aIMXXUarTn9k9qTcVldtuZCJw1rI7LoZdeOledxUP301usFtqdRlJWSVv/AhKLEnlZr I6rQ== X-Gm-Message-State: AOAM530S7r0T1yjoDQvwH7eVF9qhpF2bPACEfmM5ObzKjWfK34TpxvZr vk2+SX6n0rR1JNmg0/KprfEr1w== X-Google-Smtp-Source: ABdhPJzk1sADuDWf1mqltBlOA78Rm21xqsC7es/F5+4JjOUvGFm54/gqgEdhlOupkBs1Tk1QLX6phg== X-Received: by 2002:a17:907:3e82:b0:6e1:3fe3:9b14 with SMTP id hs2-20020a1709073e8200b006e13fe39b14mr6437585ejc.561.1648758632084; Thu, 31 Mar 2022 13:30:32 -0700 (PDT) Received: from [192.168.0.168] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id tc19-20020a1709078d1300b006e0649189b0sm169808ejc.68.2022.03.31.13.30.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 13:30:31 -0700 (PDT) Message-ID: <3d4159d6-112a-7818-8192-7197dcfca894@linaro.org> Date: Thu, 31 Mar 2022 22:30:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RFC net-next 2/3] dt-bindings: net: mscc-miim: add clock and clock-frequency Content-Language: en-US To: Andrew Lunn Cc: Michael Walle , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Alexandre Belloni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220331151440.3643482-1-michael@walle.cc> <20220331151440.3643482-2-michael@walle.cc> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/2022 22:16, Andrew Lunn wrote: > On Thu, Mar 31, 2022 at 10:05:48PM +0200, Krzysztof Kozlowski wrote: >> On 31/03/2022 17:14, Michael Walle wrote: >>> Add the (optional) clock input of the MDIO controller and indicate that >>> the common clock-frequency property is supported. The driver can use it >>> to set the desired MDIO bus frequency. >>> >>> Signed-off-by: Michael Walle >>> --- >>> Documentation/devicetree/bindings/net/mscc,miim.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/mscc,miim.yaml b/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> index b52bf1732755..e9e8ddcdade9 100644 >>> --- a/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> +++ b/Documentation/devicetree/bindings/net/mscc,miim.yaml >>> @@ -32,6 +32,11 @@ properties: >>> >>> interrupts: true >>> >>> + clocks: >>> + maxItems: 1 >>> + >>> + clock-frequency: true >> >> This looks unusual clock-frequency is usually for clock providers but >> this is a consumer, so it is not a common frequency here. You mention >> that "driver can use it", so it's not a hardware description but some >> feature for the driver. We have this already - use assigned-clock* in >> your DTS. > > Please see > > Documentation/devicetree/bindings/net/mdio.yaml > > clock-frequency: > description: > Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3 > defined 2.5MHz should only be used when all devices on the bus support > the given clock speed. > > The MDIO bus master provides the MDIO bus clock, so in a sense, the > device is a provider. although it does also make use of the clock > itself. It is a hardware description, because the users of the bus > make use of the clock, i.e. the PHY devices on the bus. > > It is also identical to i2c bus masters > Documentation/devicetree/bindings/i2c/i2c.txt says: > Thanks, it's good. Indeed buses also use this property. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof