From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758584AbcIWFgH (ORCPT ); Fri, 23 Sep 2016 01:36:07 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34496 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758067AbcIWFgE (ORCPT ); Fri, 23 Sep 2016 01:36:04 -0400 Subject: Re: [PATCH net-next 0/4] net: dsa: add port fast ageing To: Vivien Didelot , netdev@vger.kernel.org References: <20160922204924.16229-1-vivien.didelot@savoirfairelinux.com> Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , John Crispin From: Florian Fainelli Message-ID: <3d45f509-371e-85f3-3ab2-fcb783ebb371@gmail.com> Date: Thu, 22 Sep 2016 22:36:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160922204924.16229-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2016 01:49 PM, Vivien Didelot wrote: > Today the DSA drivers are in charge of flushing the MAC addresses > associated to a port when its STP state changes from Learning or > Forwarding, to Disabled or Blocking or Listening. > > This makes the drivers more complex and hides this generic switch logic. > > This patchset introduces a new optional port_fast_age operation to > dsa_switch_ops, to move this logic to the DSA layer and keep drivers > simple. b53 and mv88e6xxx are updated accordingly. This looks good, just one minor thing, both the b53 and mv88e6xxx can actually return an error from fast ageing a port, should we account for that? Not that we would be doing something about it though... Reviewed-by: Florian Fainelli > > Vivien Didelot (4): > net: dsa: add port STP state helper > net: dsa: add port fast ageing > net: dsa: b53: implement DSA port fast ageing > net: dsa: mv88e6xxx: implement DSA port fast ageing > > drivers/net/dsa/b53/b53_common.c | 31 ++++++++++----------------- > drivers/net/dsa/mv88e6xxx/chip.c | 45 ++++++++++++++++++++-------------------- > include/net/dsa.h | 2 ++ > net/dsa/slave.c | 35 ++++++++++++++++++++++++------- > 4 files changed, 64 insertions(+), 49 deletions(-) >