From: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Ulf Hansson <ulfh@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v3 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632
Date: Fri, 02 Oct 2026 16:05:49 +0200 [thread overview]
Message-ID: <3d4f5ec99761527771fb197d38774349@mainlining.org> (raw)
In-Reply-To: <20261002-speedy-alligator-of-courtesy-5da662@quoll>
On 2026-10-02 12:01, Krzysztof Kozlowski wrote:
> On Fri, Oct 02, 2026 at 12:38:33AM +0200, Barnabás Czémán wrote:
>> SDM632 MSS is very similar for MSM8953 mss the difference is
>> mss-supply is a pm domain on SDM632, previously SDM632 MSS
>> was represented by MSM8953 MSS. Correct the bindings to
>> described it correctly.
>>
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml | 9
>> ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
>> b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
>> index 4049157dd83d..049191cad5f8 100644
>> ---
>> a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
>> +++
>> b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
>> @@ -27,6 +27,7 @@ properties:
>> - qcom,msm8940-mss-pil
>> - qcom,msm8953-mss-pil
>> - qcom,msm8974-mss-pil
>> + - qcom,sdm632-mss-pil
>>
>> - const: qcom,q6v5-pil
>> description: Deprecated, prefer using qcom,msm8916-mss-pil
>> @@ -79,14 +80,14 @@ properties:
>> (not valid for qcom,msm8226-mss-pil,
>> qcom,msm8926-mss-pil
>> and qcom,msm8974-mss-pil)
>> - description: MSS proxy power domain (control handed over
>> after startup)
>> - (only valid for qcom,msm8953-mss-pil)
>> + (only valid for qcom,sdm632-mss-pil)
>> minItems: 1
>>
>> power-domain-names:
>> items:
>> - const: cx
>> - const: mx # not valid for qcom,msm8226-mss-pil,
>> qcom-msm8926-mss-pil and qcom,msm8974-mss-pil
>> - - const: mss # only valid for qcom,msm8953-mss-pil
>> + - const: mss # only valid for qcom,sdm632-mss-pil
>
> So not valid for msm8953, but msm8953 has it, so you just introduced
> new
> warnings, no?
It was never valid for MSM8953.
>
> Anyway, changing existing device needs its own rationale and usually
> own
> commit.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-10-02 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 22:38 [PATCH v3 0/7] MSM8953/SDM632 rpmpd/mss fixes Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 1/7] dt-bindings: power: qcom-rpmpd: define RPMPD_VDDMD Barnabás Czémán
2026-10-02 9:57 ` Krzysztof Kozlowski
2026-10-02 14:04 ` Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 2/7] dt-bindings: power: qcom,rpmpd: Add SDM632 Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 3/7] pmdomain: qcom: rpmpd: Split SDM632 pm domains from MSM8953 Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 4/7] remoteproc: qcom_q6v5_mss: Use mss as regulator for MSM8953 Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632 Barnabás Czémán
2026-10-02 10:01 ` Krzysztof Kozlowski
2026-10-02 14:05 ` Barnabás Czémán [this message]
2026-10-01 22:38 ` [PATCH v3 6/7] remoteproc: qcom_q6v5_mss: Add SDM632 MSS Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 7/7] arm64: dts: qcom: sdm632: Correct power domains Barnabás Czémán
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4f5ec99761527771fb197d38774349@mainlining.org \
--to=barnabas.czeman@mainlining.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®