From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux@armlinux.org.uk, luto@kernel.org,
tglx@linutronix.de, m.szyprowski@samsung.com,
mark.rutland@arm.com
Subject: Re: [PATCH] clocksource: Fix arm_arch_timer clockmode when vDSO disabled
Date: Fri, 21 Feb 2020 16:33:03 +0000 [thread overview]
Message-ID: <3d4fa11d-fe93-438f-6668-f2e6f93c62bc@arm.com> (raw)
In-Reply-To: <076d13fd01ca5e17f278cdb1db53b9ff@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
Hi Marc,
On 21/02/2020 16:24, Marc Zyngier wrote:
> On 2020-02-21 15:56, Vincenzo Frascino wrote:
[...]
>
> Which is exactly the same thing as before. It's not an indirection,
> it is just another overloading of an existing symbol.
>
Yes, sorry, I missed the indirection here. I wanted more to agree on the concept.
>>> Fair enough. But don't override the symbol locally. Create a new one:
>>>
>>
>> I see what you mean now, you mean to not overload the semantical meaning of the
>> symbol. The symbol (VDSO_CLOCKMODE_ARCHTIMER) at this point is never defined
>> when VDSO=n, but I agree with you it can cause confusion.
>
> Exactly. It breaks the expectation that if VDSO_CLOCKMODE_ARCHTIMER exists,
> it has a unique, known value. Yes, the outcome is the same. That doesn't
> make it acceptable though.
>
> So building on your above example, here's what I'd like to see:
>
[...]
All right, I agree, I will post the patches later on today.
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
prev parent reply other threads:[~2020-02-21 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200221130455eucas1p2aa4312aad606b53add889811d8e9fbc7@eucas1p2.samsung.com>
2020-02-21 13:03 ` Vincenzo Frascino
2020-02-21 13:15 ` Marek Szyprowski
2020-02-21 13:34 ` Marc Zyngier
2020-02-21 14:48 ` Vincenzo Frascino
2020-02-21 15:28 ` Marc Zyngier
2020-02-21 15:56 ` Vincenzo Frascino
2020-02-21 16:24 ` Marc Zyngier
2020-02-21 16:33 ` Vincenzo Frascino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4fa11d-fe93-438f-6668-f2e6f93c62bc@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®