From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C58AF1F3B96 for ; Mon, 3 Mar 2025 15:07:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741014480; cv=none; b=u/MH4mXY1Znl1bpH+EK+AMx7Bn/VU9bcMLHW1Pef0K1t3Rrprg2VQxPd76hMdqo8veikOWudPU6ujFdavp2hb1oW9d8gWgBRyruEzRQMrIhEK0eTnhu/1sIKVpOg6n6Gs/QLNrpIZbXoxqOEDvFytS9kkmDKZjTnoPh2jFtNFHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741014480; c=relaxed/simple; bh=uSb/yxbvChCW6hzs4hDcIgSFGGgGb0cAjB48fwKDUYY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ULdlKmH5/oxC37TTirMyZC+oI5/FZ1+A+5r3LPd+/Z/+LgCn99WaLitfXS0qTQ/99ILx1/6w+VaT0Hh9jY34DuhRldgUTaKScQ3mjjwXofOKM5OuGjvg87T5srmQxVRj+JKF+w1Ur2Bzb/Rl3UXWBxnxeaMFoh2VopFQi6Al5Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=elETcbPU; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="elETcbPU" Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Z62HT1VSpz9smd; Mon, 3 Mar 2025 16:07:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1741014469; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iBPG7n3y2ClZ2gcQ+yvlN/v5j78/gLYozFYU3F5P0Y0=; b=elETcbPUqQjzpuHyP6HpebsY9gnWeh3HERipnbBAhNYo9sQstsrwakLHdSTDKKp16wdTo8 qeL3DWFbwyrneUCCk3OYiFu4V3PhGceZXbOoc9nLnDa3O9CORAcNb7OA6klv3k3XNhuxVg bfGHf2cF00+Z4cwdx5c/077twrzjpHKsWNvh4UDjyACWgStQQcbqwd0+AXwCRheHiLyCJ4 LuYtA49atdNOWRYAsmxsqkWtC0T7tClSM37rjsurV+eDxvXMR4p2yCToKsMCQnbWPm/6Dh ywR/ZWfrpe3UqiiESoUf7N7IU0v7oh7zQ6npAm+8j3SGzsS1Nu9U15PgERDGlg== Message-ID: <3d4fc7d979ef0b22422f18de073be87e69ad92b5.camel@mailbox.org> Subject: Re: [RFC PATCH] drm/sched: Fix preprocessor guard From: Philipp Stanner Reply-To: phasta@kernel.org To: Philipp Stanner , Matthew Brost , Danilo Krummrich , Christian =?ISO-8859-1?Q?K=F6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 03 Mar 2025 16:07:45 +0100 In-Reply-To: <20250218124149.118002-2-phasta@kernel.org> References: <20250218124149.118002-2-phasta@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-META: jomof6fq3cjhps7rdk5urqj9ef731461 X-MBO-RS-ID: 56e81f524ec96604943 On Tue, 2025-02-18 at 13:41 +0100, Philipp Stanner wrote: > When writing the header guard for gpu_scheduler_trace.h, a typo, > apparently, occurred. >=20 > Fix the typo and document the scope of the guard. >=20 > Fixes: 353da3c520b4 ("drm/amdgpu: add tracepoint for scheduler (v2)") > Signed-off-by: Philipp Stanner Applied to drm-misc-fixes with Tvrtko's RB > --- > I just discovered this. But I have little understanding of what is > going > on in this header in the first place, so I kindly ask for comments on > this entire guard line with its logical or || >=20 > The code hasn't been touched since 2015. So it seems it at least > didn't > cause bugs. >=20 > P. > --- > =C2=A0drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > index c75302ca3427..f56e77e7f6d0 100644 > --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > @@ -21,7 +21,7 @@ > =C2=A0 * > =C2=A0 */ > =C2=A0 > -#if !defined(_GPU_SCHED_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) > +#if !defined(_GPU_SCHED_TRACE_H_) || > defined(TRACE_HEADER_MULTI_READ) > =C2=A0#define _GPU_SCHED_TRACE_H_ > =C2=A0 > =C2=A0#include > @@ -106,7 +106,7 @@ TRACE_EVENT(drm_sched_job_wait_dep, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __entry->seqno) > =C2=A0); > =C2=A0 > -#endif > +#endif /* _GPU_SCHED_TRACE_H_ */ > =C2=A0 > =C2=A0/* This part must be outside protection */ > =C2=A0#undef TRACE_INCLUDE_PATH