From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: keith.busch@linux.intel.com, ming.lei@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 0/2] blk-mq: some fixes about updating hw queues
Date: Sat, 13 Oct 2018 16:51:44 -0600 [thread overview]
Message-ID: <3d50f599-4243-6a11-b7d0-9eee9d71ec63@kernel.dk> (raw)
In-Reply-To: <1539338848-1789-1-git-send-email-jianchao.w.wang@oracle.com>
On 10/12/18 4:07 AM, Jianchao Wang wrote:
> Hi Jens
>
> This patch set fixes some defects during update hw queues.
>
> 1st patch refactor the blk-mq debugfs and sysfs register during
> blk_mq_update_nr_hw_queues.
>
> 2nd patch change the GFP_KERNEL to GFP_NOIO during blk_mq_realloc_hw_ctxs,
>
> 3rd patch try to realloc hctx when this hctx is mapped to a different node.
>
> 4th patch should be able to fix the panic reported in follwing link
> https://marc.info/?l=linux-block&m=153799465603723&w=2
>
> V2:
> - Newly add 2nd and 3rd patch.
> - Use blk_mq_map_queues when __blk_mq_update_nr_hw_queues fallbacks to
> previous nr_hw_queues to avoid driver's .map_queues leak mapping of
> some cpus due the fallback nr_hw_queues.
> - Add Ming's Reviewed-by in 1st patch.
>
>
> Jianchao Wang[4]
> blk-mq: adjust debugfs and sysfs register when
> blk-mq: change gfp flags to GFP_NOIO in
> blk-mq: realloc hctx when hw queue is mapped to
> blk-mq: fallback to previous nr_hw_queues when
>
> block/blk-core.c | 2 +-
> block/blk-flush.c | 6 +--
> block/blk-mq.c | 155 ++++++++++++++++++++++++++++++++++--------------------
> block/blk.h | 2 +-
> 4 files changed, 102 insertions(+), 63 deletions(-)
>
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-10-13 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 10:07 Jianchao Wang
2018-10-12 10:07 ` [PATCH V2 1/4] blk-mq: adjust debugfs and sysfs register when updating nr_hw_queues Jianchao Wang
2018-10-12 10:07 ` [PATCH V2 2/4] blk-mq: change gfp flags to GFP_NOIO in blk_mq_realloc_hw_ctxs Jianchao Wang
2018-10-12 10:07 ` [PATCH V2 3/4] blk-mq: realloc hctx when hw queue is mapped to another node Jianchao Wang
2018-10-12 10:07 ` [PATCH V2 4/4] blk-mq: fallback to previous nr_hw_queues when updating fails Jianchao Wang
2018-10-13 22:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d50f599-4243-6a11-b7d0-9eee9d71ec63@kernel.dk \
--to=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®