From: Vlastimil Babka <vbabka@suse.cz>
To: Christoph Hellwig <hch@infradead.org>,
syzbot <syzbot+359a67b608de1ef72f65@syzkaller.appspotmail.com>
Cc: akpm@linux-foundation.org, apopple@nvidia.com, baohua@kernel.org,
byungchul@sk.com, cem@kernel.org, david@fromorbit.com,
david@redhat.com, gourry@gourry.net, harry.yoo@oracle.com,
joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
matthew.brost@intel.com, mhocko@suse.com,
penguin-kernel@i-love.sakura.ne.jp, rakie.kim@sk.com,
syzkaller-bugs@googlegroups.com, willy@infradead.org,
ying.huang@linux.alibaba.com, ziy@nvidia.com
Subject: Re: [syzbot] [mm?] WARNING in xfs_init_fs_context
Date: Mon, 29 Sep 2025 09:05:45 +0200 [thread overview]
Message-ID: <3d54a546-77dd-4913-bcd0-7472aec8f53c@suse.cz> (raw)
In-Reply-To: <aNop4ZBrfuqrX40Y@infradead.org>
On 9/29/25 08:40, Christoph Hellwig wrote:
> This looks like slub turning a < PAGE_SIZE allocation into a order > 0
> folio allocation, which the page allocator then complains about.
It's order-1 to order-2 but in principle yes.
> We'll either need to make slab not propagate < PAGE_SIZE allocations
> to order > 0 page allocation
It normally doesn't, but enabling debugging stuff can do that. In this case
it seems to be KASAN, but could be also slub's own redzones etc.
, or make the page allocator handle the
> latter.
It handles it, but warns you're doing something you shouldn't, as
__GFP_NOFAIL allocations shouldn't be large. We could just silence it if
it's due to debugging. SLUB could check if page allocation is bloated due to
debugging and there's __GFP_NOFAIL, and then add an extra gfp flag to
silence the warning. We could use __GFP_NOWARN with the risk of someone else
combining __GFP_NOFAIL and __GFP_NOWARN to silence this. Or invent some
other internal flag, but there's not many bits left.
> And XFS shouldn't need the NOFAIL allocation here, but this will break
> things elsewhere as well.
>
prev parent reply other threads:[~2025-09-29 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 22:47 syzbot
2025-07-01 15:01 ` Zi Yan
2025-07-02 1:41 ` Tetsuo Handa
2025-07-02 7:30 ` Vlastimil Babka
2025-07-04 8:26 ` Harry Yoo
2025-07-07 16:57 ` Vlastimil Babka
2025-07-07 22:10 ` Dave Chinner
2025-07-08 8:50 ` Vlastimil Babka
2025-07-08 9:48 ` Tetsuo Handa
2025-09-28 17:44 ` syzbot
2025-09-29 6:40 ` Christoph Hellwig
2025-09-29 7:05 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d54a546-77dd-4913-bcd0-7472aec8f53c@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=byungchul@sk.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=gourry@gourry.net \
--cc=harry.yoo@oracle.com \
--cc=hch@infradead.org \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rakie.kim@sk.com \
--cc=syzbot+359a67b608de1ef72f65@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®