From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbdJ3RgF (ORCPT ); Mon, 30 Oct 2017 13:36:05 -0400 Received: from mout.gmx.net ([212.227.17.21]:62512 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbdJ3RgD (ORCPT ); Mon, 30 Oct 2017 13:36:03 -0400 Subject: Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx To: Colin King , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171029133809.6831-1-colin.king@canonical.com> From: Lino Sanfilippo Message-ID: <3d566098-10dd-a9db-4d50-8fffebc71b92@gmx.de> Date: Mon, 30 Oct 2017 18:36:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171029133809.6831-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qALpCkK2CCnxXbYIeMbMEmNAy6Dt6I0U/0jXBMIMmX3O5RU6Gv5 Q0E5IsHRNMEr4aBmRIjM4PXp58OJC1/01YO719nvMM5+/1LUC2xagjJDmzJWnqjG0bRVdC8 iFLWnlzObivhN7HLKDjLJC59l3XMka6Q3lr96+2f7Gy0gTIYGxWP4GJNgkzsaFP1x0K5D1Y 2aV4nJWeVy7PtwLq/O2gA== X-UI-Out-Filterresults: notjunk:1;V01:K0:RNsngzNPhEA=:nhk/P5k9q0tYN1sKfHJc+h Ftq76vK6mEIeHpr139wzSHxQf7pLTD8CZo1oJpIaucVnpC9qzSENS1gcdYXtvpAZtBo5o3b/I mTsMSlnuCcK2NurqxjDWCi1vcqt1X4pTamzoh7+3nbTxNnGSazm++dImlkMkpeHicIwvBQnKz BmwGSOIAxZHLSOoHCXP04sHfcKAeLZMvJsfFKQGf3Bku1eoczKKBHRbxAIFnbdK9HCqI23kYd H7WkQ2jmgqlZh6/6FVJvxfytMY7y1GbncCP/oQpE7ZO51pP+H1G2KeqPFcT30NVLmryKKDY04 6fBznJNoIYr9D1hflZ0XAQckjCQUuIeHPqUJl+pvv2QdCVfEyCVv+DKDhmQu0VQc+W35+4rfO 9t7oSHjVDUPJjJsxu+Eu96udOsGbbLyYfnj7GxxQsyBH8ti3BJNEOb76kgIh+tCKdz24EWi2q YdLJQZKK59mUA06Oe/UwaQSGwzbHi5JpcJlM5acGO2IXCU3V/Gb+mlXSm7bcegdNrtaXmtG6y ldpL7Nry6tmJfkhS/hmdjsD6bMgCtaGz62bgJADJVSg2CVeZYT2D5mRorWz7H/UoDOa0czR72 CzrhXRzxLHnDinzh+t4K986exG8Uawg+DtlRDApC6w24tSEqt5WMOj8w5dw6CT2s+SqfzaeXD 970ZW/HncQqv435BrYSXmy+0bfYxBYggWFkjiZwxD9R+mdIjCUkQYAfZnZuuB8I+5lmX1zTbo vqrG2X9xGK3KlRp2nD7yQPw3JMYFhlp1tHAzFgzc5Xd4DIB7IVOnn+7GES7N3RQO6q0Qe/KaP qHOfWawppTxtEDCUCJLPeKH161uzed56tkfBxZqvMBxoNj/3Y4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, On 29.10.2017 14:38, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: > > drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value > stored to 'idx' during its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/alacritech/slicoss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c > index 15a8096c60df..ac8004186fa8 100644 > --- a/drivers/net/ethernet/alacritech/slicoss.c > +++ b/drivers/net/ethernet/alacritech/slicoss.c > @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev) > { > struct slic_tx_queue *txq = &sdev->txq; > struct net_device *dev = sdev->netdev; > - unsigned int idx = txq->done_idx; > + unsigned int idx; > struct slic_tx_buffer *buff; > unsigned int frames = 0; > unsigned int bytes = 0; > Acked-by: Lino Sanfilippo Regards, Lino