From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Yishai Hadas" <yishaih@nvidia.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Alex Williamson" <alex@shazbot.org>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>
Subject: Re: [PATCH] virtio_pci: drop kernel.h
Date: Wed, 19 Nov 2025 00:57:47 +0000 [thread overview]
Message-ID: <3d58c482-c171-45a9-ba13-2cc9ff50ad3d@nvidia.com> (raw)
In-Reply-To: <a1efb550481fc67973c0a86860e0724c8f5b9957.1763507303.git.mst@redhat.com>
On 11/18/25 15:08, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas"<yishaih@nvidia.com>
> Cc: Alex Williamson<alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
Indeed:
linux-block (discard-ret-value) # grep "kernel\.h" include/uapi/linux/* -ir
include/uapi/linux/virtio_pci.h:#include <linux/kernel.h>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-11-19 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 23:08 Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni [this message]
2025-11-19 2:51 ` Jason Wang
2025-11-19 5:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d58c482-c171-45a9-ba13-2cc9ff50ad3d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alex@shazbot.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®