From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751543AbdGZIE1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Jul 2017 04:04:27 -0400
Received: from foss.arm.com ([217.140.101.70]:57062 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750989AbdGZIEZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Jul 2017 04:04:25 -0400
Subject: Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
References: <1501041791-10131-1-git-send-email-yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <3d59b609-aeec-9177-8849-da1fbd386191@arm.com>
Date: Wed, 26 Jul 2017 09:04:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1501041791-10131-1-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26/07/17 05:03, Masahiro Yamada wrote:
> Some irqchip drivers have a Kconfig prompt.  When we run menuconfig
> or friends, those drivers are directly listed in the "Device Drivers"
> menu level.  This does not look nice.  Create a sub-system level menu.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/irqchip/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index f1fd5f44d1d4..7b66313a2952 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -1,3 +1,5 @@
> +menu "IRQ chip support"
> +
>  config IRQCHIP
>  	def_bool y
>  	depends on OF_IRQ
> @@ -306,3 +308,5 @@ config QCOM_IRQ_COMBINER
>  	help
>  	  Say yes here to add support for the IRQ combiner devices embedded
>  	  in Qualcomm Technologies chips.
> +
> +endmenu
> 

I'm very reluctant to introduce this. IMHO, interrupt controllers are
way too low level a thing to let them be selected by the user. They
really should be selected by the platform that needs them

Do you have any example in mind where having a user-selectable interrupt
controller actually makes sense on its own?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...