From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317B5C2BB40 for ; Mon, 14 Dec 2020 00:54:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2A8522D72 for ; Mon, 14 Dec 2020 00:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437034AbgLNAyh (ORCPT ); Sun, 13 Dec 2020 19:54:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgLNAye (ORCPT ); Sun, 13 Dec 2020 19:54:34 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 946B1C0613CF; Sun, 13 Dec 2020 16:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=eXHSUbHUuYdNdh6eTrrSzxWBQFgcFwTnIcLbyddVGcM=; b=Xq5FbABOhc4h8CPpAYOl5jrWkG K/8VvDrguxThk9MW0Q6cp1qWjEkIVo47hR7n3xzDnJWtukgpThX71EjRuS02fIZwKldt4qlNDqYRW oiXimXtskggcIY/mnYhHWk/C4wNLPsSHwqJBJ6EJs/L5opqiK06upHb6+260jUfVQNrrvM6qijnkM zXmcXVxjdUagu971UyF34xpHq1Fwzd5cfXpr2jRj5af9EXQt/jEso8PlVYe8E3Z8Fs3V+Fm2F3NJ3 p4rUaqCvR6++cobMFALadL5JXRKhHJa2hpxjYosFfHhI14ZOPmrIuE+byxnrkAa8tr64IAteUuXOV LW1Vhk6Q==; Received: from [2601:1c0:6280:3f0::1494] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1koc7c-0004n5-6H; Mon, 14 Dec 2020 00:53:52 +0000 Subject: Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings To: Andy Shevchenko Cc: Linux Kernel Mailing List , Maximilian Luz , Hans de Goede , Platform Driver References: <20201211190335.16501-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: <3d5a5c8f-4bb1-6205-ae76-354473d59a18@infradead.org> Date: Sun, 13 Dec 2020 16:53:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/20 11:07 AM, Andy Shevchenko wrote: > On Sat, Dec 12, 2020 at 7:05 PM Randy Dunlap wrote: >> On 12/12/20 5:24 AM, Andy Shevchenko wrote: >>> On Fri, Dec 11, 2020 at 9:20 PM Randy Dunlap wrote: > > ... > >>>> +#ifdef CONFIG_PM_SLEEP >>>> static int surface_gpe_suspend(struct device *dev) >>> >>> Perhaps __maybe_unused ? >> >> Yes, I am aware of that option. >> I don't know why it would be preferred though. > > Here [1] is the rationale behind annotation vs. ifdeffery. > > [1]: https://lore.kernel.org/patchwork/patch/732981/ > Thanks for the link. I'll send a v2. Could we add that to the Linux BKP (Best Known Practices) document? -- ~Randy