From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BCDC433DB for ; Tue, 23 Mar 2021 15:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD778619C5 for ; Tue, 23 Mar 2021 15:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233045AbhCWPqH (ORCPT ); Tue, 23 Mar 2021 11:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232803AbhCWPpv (ORCPT ); Tue, 23 Mar 2021 11:45:51 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29A1C061763 for ; Tue, 23 Mar 2021 08:45:50 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id c17so18549258ilj.7 for ; Tue, 23 Mar 2021 08:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eNcwAhe8EECmJ+67E5IQtqOhMGQZ7Q8SnR6/Iu7GDqo=; b=fVK+hoNA6Z2If7+jw9Gya5oau5Kach+9ONPCC98VmVCKgB4pZffbmH6s/XcAaWqPqD M/uzfO6MA60ffmQUFGfBsII0Gs3aEnnfEkQa/S1AUZa7pRXV5MHBEzpsG9anLsb2jYRm nw4KRLJGJ66ZASt/uEssfPghYVLeDMv9fin5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eNcwAhe8EECmJ+67E5IQtqOhMGQZ7Q8SnR6/Iu7GDqo=; b=HP4md+4SgKTDNDmCyZri/Gj3XJ0LXgqPuy2cet3xSgEQbaR4D4iTuh9k8n+NqtKBGZ E8LV6PPI8cBUBmdKLbl0/1K6zaSZ1V1TI80TrOI+hIv6sikiWnzzKAxXL71AMmoBigJP osLg74p4LU408/RbOdaO4Z8ZFHdFJnDu8sUkQnoaFo7u1G+ojz7uuyAlEo5zjf6yYhfs bGWYa8lK1P50XKNmBy7HPtx+oNR0GQ8fAre1qtoi6Q+1AC/MaX7veGXD6FlOg9QFqfnT 3oIqCg8bnwDm0R4QpzhUzvG3y8of3Ky1HWxbHScxKbuEyMBmwHd91CpOKdAmAaWrdB3Z nzTg== X-Gm-Message-State: AOAM530vI6zVbCAIVc8kbOzp78O4fnwFnAZ6y5kxxaR6d+WIdpssNn0Q iYyvc7hT4Quw4QDTg5JyoNgtXw== X-Google-Smtp-Source: ABdhPJwzXXZ1kbUwrfW/PKshnh8p7S8RyqnAU3cfcJS+Mlzbh8jJMJWVUnCNfW1coxUngiS3AGwGqQ== X-Received: by 2002:a92:2c04:: with SMTP id t4mr5377940ile.99.1616514350412; Tue, 23 Mar 2021 08:45:50 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 18sm9742312ilj.59.2021.03.23.08.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 08:45:49 -0700 (PDT) Subject: Re: [PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c To: "Hongren Zheng (Zenithal)" , Valentina Manea , Shuah Khan , Antonio Borneo , Greg Kroah-Hartman , matt mooney , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Shuah Khan References: From: Shuah Khan Message-ID: <3d5c3b76-40a4-8db7-8e12-a210f0c52e51@linuxfoundation.org> Date: Tue, 23 Mar 2021 09:45:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/21 7:01 AM, Hongren Zheng (Zenithal) wrote: > The option '-d/--device' was implemented in 'usbip list' but not > shown in usage. Hence this commit adds this option to usage. > > Signed-off-by: Hongren Zheng > --- > tools/usb/usbip/src/usbip_list.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > PATCH v2: > Add signed-off-by line > > PATCH v3: > Move patch changelog after the marker line > Remove nickname in signed-off-by line > > PATCH v4: > Use commit short hash and message instead of long hash only when > referring to commit in the kernel > > diff --git a/tools/usb/usbip/src/usbip_list.c b/tools/usb/usbip/src/usbip_list.c > index 8625b0f514ee..3d810bcca02f 100644 > --- a/tools/usb/usbip/src/usbip_list.c > +++ b/tools/usb/usbip/src/usbip_list.c > @@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] = > "usbip list [-p|--parsable] \n" > " -p, --parsable Parsable list format\n" > " -r, --remote= List the exportable USB devices on \n" > - " -l, --local List the local USB devices\n"; > + " -l, --local List the local USB devices\n" > + " -d, --device List the local USB gadgets bound to usbip-vudc\n"; > > void usbip_list_usage(void) > { > Looks good to me. Thanks for adding this. Acked-by: Shuah Khan thanks, -- Shuah