mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: xiaohui.xin@intel.com
To: netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
	davem@davemloft.net, herbert@gondor.hengli.com.au,
	jdike@linux.intel.com
Cc: Xin Xiaohui <xiaohui.xin@intel.com>
Subject: [PATCH v16 06/17]move member destructor_arg before member dataref
Date: Wed,  1 Dec 2010 16:08:17 +0800	[thread overview]
Message-ID: <3d6498d772aa4ec1585ff3736ccae63c359448e5.1291187695.git.xiaohui.xin@intel.com> (raw)
In-Reply-To: <fc6e95d63a2c62aaf77f8ded22fc43ccefcdbbff.1291187695.git.xiaohui.xin@intel.com>
In-Reply-To: <fc6e95d63a2c62aaf77f8ded22fc43ccefcdbbff.1291187695.git.xiaohui.xin@intel.com>

From: Xin Xiaohui <xiaohui.xin@intel.com>

Then we can clear destructor_arg when __alloc_skb().

Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com>
Signed-off-by: Zhao Yu <yzhao81new@gmail.com>
Reviewed-by: Jeff Dike <jdike@linux.intel.com>
---
 include/linux/skbuff.h |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 696e690..6e1e991 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -199,14 +199,15 @@ struct skb_shared_info {
 	struct sk_buff	*frag_list;
 	struct skb_shared_hwtstamps hwtstamps;
 
+	/* Intermediate layers must ensure that destructor_arg
+	 * remains valid until skb destructor */
+	void *		destructor_arg;
+
 	/*
 	 * Warning : all fields before dataref are cleared in __alloc_skb()
 	 */
 	atomic_t	dataref;
 
-	/* Intermediate layers must ensure that destructor_arg
-	 * remains valid until skb destructor */
-	void *		destructor_arg;
 	/* must be last field, see pskb_expand_head() */
 	skb_frag_t	frags[MAX_SKB_FRAGS];
 };
-- 
1.7.3


  parent reply	other threads:[~2010-12-01  7:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01  8:08 [PATCH v16 01/17] Add a new structure for skb buffer from external xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 02/17]Add a new struct for device to manipulate external buffer xiaohui.xin
2010-12-10 20:36   ` David Miller
2010-12-01  8:08 ` [PATCH v16 03/17] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-12-10 20:36   ` David Miller
2010-12-01  8:08 ` [PATCH v16 04/17]Add a function make external buffer owner to query capability xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 05/17] Add a function to indicate if device use external buffer xiaohui.xin
2010-12-01  8:08 ` xiaohui.xin [this message]
2010-12-01  8:08 ` [PATCH v16 07/17]Modify netdev_alloc_page() to get " xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 08/17]Modify netdev_free_page() to release " xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 09/17] Don't do skb recycle, if device use " xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 10/17] If device is in zero-copy mode first, bonding will fail xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 11/17]Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-12-01  9:38   ` Changli Gao
2010-12-01  8:08 ` [PATCH v16 12/17] Add header file for mp device xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 13/17] Add mp(mediate passthru) device xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 14/17]Add a kconfig entry and make entry for mp device xiaohui.xin
2010-12-01 17:53   ` Randy Dunlap
2010-12-02  1:32     ` Xin, Xiaohui
2010-12-01  8:08 ` [PATCH v16 15/17]Provides multiple submits and asynchronous notifications xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 16/17]An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 17/17]An example how to alloc user buffer based on " xiaohui.xin
2010-12-01  8:08 ` [PATCH v16 00/17] Provide a zero-copy method on KVM virtio-net xiaohui.xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d6498d772aa4ec1585ff3736ccae63c359448e5.1291187695.git.xiaohui.xin@intel.com \
    --to=xiaohui.xin@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=jdike@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®