From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927E9C4167D for ; Mon, 30 Oct 2023 18:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbjJ3Srz (ORCPT ); Mon, 30 Oct 2023 14:47:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjJ3Sry (ORCPT ); Mon, 30 Oct 2023 14:47:54 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6088DDE for ; Mon, 30 Oct 2023 11:47:51 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c523ac38fbso71249031fa.0 for ; Mon, 30 Oct 2023 11:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698691669; x=1699296469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mdfkodqtRgpzDSBxx7a3aoX4UmAsfQ6jNbjpEc4xUMk=; b=C+bEJImrIvIaYDTTvhSVlp1BL0HsCiFVGortmX6UeiLT7a3YgcsVwrd3iuLVHMcnUB WXakFk3Z9+SwP218/RkjOPtNgvpGG3LLyxKl/AJhCnIWIcUTYX6jZqTUj6k+xfTZKpLU quOUgXicC2hyRlylxPMA0O/utG/QoEeyCkwjTm2QcV+mRZki93gvWamYae5zuFtqzsMg Z8208bhTEcJ061+044A82r/QiOQdPg7SbZofSox3jKADWZtkZFctg4M8fMv/4lqrZixR Pc6DJtmmKAR/XHz5XdPuC1Er8rsg2417Tm+FiNMH1uACiAFqmHq9TqKXYgmJqe0uU8QD nawA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698691669; x=1699296469; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mdfkodqtRgpzDSBxx7a3aoX4UmAsfQ6jNbjpEc4xUMk=; b=ds3RDXsmLlXrCOGVoJtAI59ACSX7gavMuG03M1CPp+BnbD9uEnbvo2Zy0RMh2bu84l 0kknZpxk1tX3QF6VUlFgRIotAiAkHfDp757dZPE+pI0H3wUxpjPtZtEVDH0nWjtT2Coi vn0qSfnW0BIgJPSTQFzM3Rru8nLfgtX8+DFRaHRg2V9w1O+qRP1LfZJHlZ3gmLEbRswh xnxK5I7qBDFpGGVWww4jhqiJUOEDLrI+/WEZkukZfTmzic5Jb9MqJ6zs8PP7yea8nfi7 zNfuUPcECSzlIpnbtA+Dof6qZBKkQnV8FB1G2MZqlvEco70TwkK9gzfK4d7M9MZIsShP MeWw== X-Gm-Message-State: AOJu0YyegPFbEtT68Zkxb9/BIvFlWQcrleZxvOA03qXjryXAVe/IzVCi 6AvDxamGg3ftXHT4vQRsiEoyvA== X-Google-Smtp-Source: AGHT+IHOwmjWAKi3EkcSIdomRl/i+lZTcOhi3e+rIMuCXL9A6mh82Eh41J+X7bx7IeYQN9Oltop5cg== X-Received: by 2002:a2e:84c7:0:b0:2b6:e958:5700 with SMTP id q7-20020a2e84c7000000b002b6e9585700mr7247840ljh.4.1698691669554; Mon, 30 Oct 2023 11:47:49 -0700 (PDT) Received: from [192.168.133.160] (178235177091.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.91]) by smtp.gmail.com with ESMTPSA id bf19-20020a2eaa13000000b002bcb89e92dcsm1357295ljb.6.2023.10.30.11.47.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 11:47:49 -0700 (PDT) Message-ID: <3d686b62-13a2-4107-86ff-d9753cb177fb@linaro.org> Date: Mon, 30 Oct 2023 19:47:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/3] OPP: Level zero is valid Content-Language: en-US To: Viresh Kumar , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, Vincent Guittot , Ulf Hansson , Stephan Gerhold , Manivannan Sadhasivam , linux-kernel@vger.kernel.org References: <36de122e568dcba371d3581e5f936243b405a874.1698661048.git.viresh.kumar@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <36de122e568dcba371d3581e5f936243b405a874.1698661048.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.10.2023 11:24, Viresh Kumar wrote: > The level zero can be used by some OPPs to drop performance state vote > for the device. It is perfectly fine to allow the same. > > _set_opp_level() considers it as an invalid value currently and returns > early. So, currently if the device is PM-enabled, but OPP requirements are lifted, is the API currently internally stuck at the last non-zero level? Just trying to understand if this could fix some silent issues Konrad