From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762786AbbA3SQw (ORCPT ); Fri, 30 Jan 2015 13:16:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:54536 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759403AbbA3SQv (ORCPT ); Fri, 30 Jan 2015 13:16:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,492,1418112000"; d="scan'208";a="645206808" Message-Id: <3d6a39202cff6415eeb0af7bff58f36ce879a253.1422641617.git.tony.luck@intel.com> In-Reply-To: <20150130173830.GB1893@pd.tnic> From: Tony Luck Subject: [PATCHv2] x86, mce: Kernel does full decoding for AMD, others still need /dev/mcelog reports To: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Cc: Borislav Petkov , Chen Gong Date: Fri, 30 Jan 2015 10:16:48 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should only believe a NOTIFY_STOP on an AMD system. For others we need to provide the error record out to a user level decoder via /dev/mcelog. Signed-off-by: Tony Luck --- v2: Boris says: "on AMD, mcelog is not needed" arch/x86/kernel/cpu/mcheck/mce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index d2c611699cd9..ea1bc1a05c07 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -151,12 +151,13 @@ void mce_log(struct mce *mce) { unsigned next, entry; int ret = 0; + struct cpuinfo_x86 *c = &boot_cpu_data; /* Emit the trace record: */ trace_mce_record(mce); ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, mce); - if (ret == NOTIFY_STOP) + if (c->x86_vendor == X86_VENDOR_AMD && ret == NOTIFY_STOP) return; mce->finished = 0; -- 2.1.0