From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933332AbcLIOki (ORCPT ); Fri, 9 Dec 2016 09:40:38 -0500 Received: from mout.web.de ([217.72.192.78]:50756 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcLIOkg (ORCPT ); Fri, 9 Dec 2016 09:40:36 -0500 Subject: [PATCH 4/4] staging: greybus: power_supply: Use kcalloc() in gb_power_supplies_setup() To: devel@driverdev.osuosl.org, Alex Elder , Greg Kroah-Hartman , Johan Hovold , Rui Miguel Silva References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <3d6e0e13-b74d-f022-3edc-1bf1ae6ef9ac@users.sourceforge.net> Date: Fri, 9 Dec 2016 15:40:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9Eq6Od3l/hfpS+K/TyWLB7nDYYIOoPygszdVzXQhnxxbfTZy401 /zUIKPBrGryoaasRZst5pNgiylffwcgAq0O3N73gfIDeCjezNGx5+Zao5XXd02SpBdg+jAw 7h3xnkBCpshl0TmPxbgZhckdfx2WgoogR5sZMQIcNjPJI3DWHG3B2icxvQvL77KQHd0jzbN Wo2JEnrTcri376VbyhQ1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:KGz1tkSXl+4=:iG7P0Cxkb6JamYcelaqK0/ rhiDtbfh4DOARFJF18oQ6PfN7D2LKXGFm6PzBB6JrP9GQ59BKGQqyDcNCYCEet/fYBoVDnr/2 kAN3Pc1CNGFYZC8wk9GWinRTqLBKa6SStCqL4qRr4rZduqCOGZCJk9Voevi/S/rg4aj5yyYFQ hclTWGbCijMaBBCKtw9jMy4jWNaxrVXZQFx0nRrtePu5U3w3IO47/W8E/jW6bDev6CY0w/2r7 SzCHavk9Vyv2qwceyOO04R6XN3j0YFRz5FX+oeE0h6JfkYtsqmYMP+27JM5xpBaPBHf61tk4+ LJonyYD00/OVD4WJbR/NiHjewJRqw9B5q0RGMfFMJN9bKvO/g9IFrffdIz0vZOmdIEj2NWGdX 3haA7l2+mLFknlxVJkYOxGusiNDYaMsJr4yWd7QbRGefhTuSWbr6tRY8DnXPmkiU5jwXMTbvQ k7KfFGNWxaK7yl2cIrvB7ckzBKlnOkGmI6tZZ93S52oWtTJrnvHdAsaJ50w/Yx9h4J2xoYmsZ g3qrodhCVgnxC2zyOK0Nbb4493kn/arXNYbm/PtuesbPe34g7+8bk8/MiOgujEO6RLsCuHkdg JK8s7aQ3b0vuemMsXrV6KA1R+cHa+qL1Zo2nWIDyNEA1zmgEsZgxnC3XKJPF0y1GSqHKmhcMP Te62Yy6vumh43Y698Vyzv64Swb8ABw7rUNQBuo5pIEK7tqdZBSz2On5H2mcew9D+ZmXTGs+Ej gsYiwtlfjFCxXYuQJmBiOAo/P7v8i43FU+QWt+n43cGewXoJ79+drkhhLV2Y/wXq8T/SsMzO6 CCM4uYS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 9 Dec 2016 15:04:24 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Fixes: ffe2e2487a388cf01ec44439346363aa8d654cd4 ("greybus: power_supply: rework and operation changes") Signed-off-by: Markus Elfring --- drivers/staging/greybus/power_supply.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index e85c988b7034..19080c7f1491 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -944,10 +944,9 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies) if (ret < 0) goto out; - supplies->supply = kzalloc(supplies->supplies_count * - sizeof(struct gb_power_supply), - GFP_KERNEL); - + supplies->supply = kcalloc(supplies->supplies_count, + sizeof(*supplies->supply), + GFP_KERNEL); if (!supplies->supply) { ret = -ENOMEM; goto out; -- 2.11.0