From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA3FA264627 for ; Tue, 30 Dec 2025 09:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767087775; cv=none; b=NY0Lznwl2WXpDqAeW+eg/zsp9Cu3HD1C7yKflvVC1lg9FE+d07hnNKTlNrv6kp/Jwh/9pqV86aM2r3jooFIOTpnh6CRg5nIlchk5WK0W/ZVcMc8AFXw8vWnKwdBOmVSJCF0bDqmSWdT3CnZZ/a2+BiKu3VeQxiLZTWWl6wmu6/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767087775; c=relaxed/simple; bh=SU/gkVSJSKmS1toUh8a9AX9Zwej8Gg1TuhVWXdqgfeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WDozgOkPNsvSIc1jB3W+siK6z+0yAJWAopUxCd4hkdWEsd7WeJOUQNs/1iFjl0VOxICk2IlrPDQfeyt7VKTZGiE4DYHOjClRAOlIlLFP66HVhrhUECof+76Avh3v7cfYqJclXV9Km0d+DsXxF5/n1Sknnn1Y59GX90w1m3rIDgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Aj4UMGBy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xvl3Ppnx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Aj4UMGBy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xvl3Ppnx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767087772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q9/bKFXPzIaEZ/uggKugW5GizuegwuaRhWjx7DK7tW0=; b=Aj4UMGByRf3/Ku/ZQezjk62PgEYmkBeuqLgvKxMnJAPaAMzVEY4UBlBWJtCmcQ0hAWQfUf P2SRoqbvYU5R7J9JdNtk/qUJoOa3qwhdv6g9LasAzPed2/a9YG48cvoj9cT9+4lGDFEtYX dBRXMssY31YBQJOlm+fgDY7WRlGjg70= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-vG0L9Z38ON2_WEq7LoYDZw-1; Tue, 30 Dec 2025 04:42:51 -0500 X-MC-Unique: vG0L9Z38ON2_WEq7LoYDZw-1 X-Mimecast-MFC-AGG-ID: vG0L9Z38ON2_WEq7LoYDZw_1767087770 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43009df5ab3so5453114f8f.1 for ; Tue, 30 Dec 2025 01:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767087770; x=1767692570; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q9/bKFXPzIaEZ/uggKugW5GizuegwuaRhWjx7DK7tW0=; b=Xvl3PpnxqJ8ShPtrHMNnbUU40XyeJSVfCzxWQfJWZM7In46jKQnpEt3DDDNWlulBRT 8VQq6DyPJyqzTz830FwvbWoQSFE3jCh0RFTi2AU29XhRjsD1x8jIUlJDfd1YM11EJl5X mqWVJDPRMHgIvNnJevB8jZD+kTGKNWHig4MsUNZ69nQAP3xDHKJpzCutB8Vsexg6150q EavwzHnGnGxwvvOTEOGHmRRFoM7I6Q5z7VEsK9uaix2msUbw3A2VB5ObhvlJnT1bpTua ffkQ9zsMczDMrhYimfP/lFqGCM4rHUAeFjT9t1j7oR7TDVxNcrdX953CjsVOb+vyDG7Z UHGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767087770; x=1767692570; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q9/bKFXPzIaEZ/uggKugW5GizuegwuaRhWjx7DK7tW0=; b=VRDNlpep4dgsL2f0Fs/+BCS/moqAfEhM6EdO65CFEB1+RuFPAcgUkJlQ5ZNDuktZDb MbKnv9WGyxo4RCv8E3CBxtt5EasthGcMsnBbXRxdNY5KxeYTtclVHwA3ORRP5jsZ9rld rtHyamOax1FsV+rOzTqiBW36psYdbIHwcyBIBtHsIpMn35EZXGNz8Q7/1XggQdw+RJET jelJDAaTfyfdZyk6+QO3P2y7VzkBPYWQiW5FLt0AeguGNCN7wgHkPvlTN7zuMhppgUxL 1Fs/wanlwk+vAoFUXhxwg6DvAEcfj/tGLMFQSI3H7IRr6vA7eU3OiZgpYN11gx9ccLZx SivQ== X-Forwarded-Encrypted: i=1; AJvYcCVlu9WxL1u1AU/WISqnGtqe/iE/8nNmNWFPg+XSfjd0PGb+79fjfFh5ryfzEfzac6QYsWQph4+bcXhgfN4=@vger.kernel.org X-Gm-Message-State: AOJu0YyFC9R2f9lcdjeUWvvh8IeNUtU+oP/FyfWZAjpKZJqYvl2DIc4s NGkoqwTDz/d48m94F05mkITYufkucr1bGkliyBErB6yigBbe9EIsSFxEWYD2tpZXLmoiDzCXV3K 4Mv1bAfXE1wgm/DHEXhGz92nom1t2GuArl0KEwb3HF8kuOJhlDujjEe+EmJugpm8Mj3XWinDWIA == X-Gm-Gg: AY/fxX4uNt3UVtCVST3bE17uHpsSaP5JTFvbILHwrPk07Q5JW852lOc0Hj7ALo4Mq4q lz7dyvZmDCI6/L2i7gOHVlXsYeJQHmo4PA9nIm7Sf4GSl4mL2KeeuiLmAiCW2nL9Wf7Dqw1SaaH 1zT+2MocKgs0VaLM6g9Tvq65gtOZCrS1zGBGGXV44d447reNqeKbReu+hQbBidzvIHClQXW+z/w G884SFEbSvvMVC8eGzFEB7KPXhn56/p58VtC/ZroevyqbDMRZyqVu6JimlAUebiNGIY2C2qzMeY R+WTAS0o2HJ0EjPF6+oaEOWTddsBx5OfIPbQjtw/OGFVU4RTUu4VUFqm0qjIFIZNjnCKjrYTq3x QM2PCMZ9luqrZ X-Received: by 2002:a05:600c:8b06:b0:477:a977:b8c5 with SMTP id 5b1f17b1804b1-47d34de6358mr303808895e9.31.1767087770039; Tue, 30 Dec 2025 01:42:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3Zx9lRdKfuZUc0CFMcTPCHEvkS3FVBu+fC+b4QW1XnjJD/mHOaw+2kjvzo31uDZK3uXx8xw== X-Received: by 2002:a05:600c:8b06:b0:477:a977:b8c5 with SMTP id 5b1f17b1804b1-47d34de6358mr303808595e9.31.1767087769680; Tue, 30 Dec 2025 01:42:49 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a4651bsm250192045e9.7.2025.12.30.01.42.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 01:42:49 -0800 (PST) Message-ID: <3d6fbc23-e9b8-443c-badb-b3380b62d21f@redhat.com> Date: Tue, 30 Dec 2025 10:42:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix PTP driver warnings by removing settime64 check To: Tinsae Tadesse , richardcochran@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251229173346.8899-1-tinsaetadesse2015@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251229173346.8899-1-tinsaetadesse2015@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/29/25 6:32 PM, Tinsae Tadesse wrote: > Signed-off-by: Tinsae Tadesse > --- > drivers/ptp/ptp_clock.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c > index b0e167c0b3eb..5374b3e9ad15 100644 > --- a/drivers/ptp/ptp_clock.c > +++ b/drivers/ptp/ptp_clock.c > @@ -323,8 +323,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, > size_t size; > > if (WARN_ON_ONCE(info->n_alarm > PTP_MAX_ALARMS || > - (!info->gettimex64 && !info->gettime64) || > - !info->settime64)) > + (!info->gettimex64 && !info->gettime64))) > return ERR_PTR(-EINVAL); > > /* Initialize a clock structure. */ I guess this is an attempt to address the following issue: https://lore.kernel.org/all/20251108044822.GA3262936@ax162/ If so, it's already fixed by commit 81d90d93d22ca4f61833cba921dce9a0bd82218f /P