From: Mike Looijmans <mike.looijmans@topic.nl>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, <frowand.list@gmail.com>
Subject: Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper
Date: Mon, 26 Mar 2018 08:54:03 +0200 [thread overview]
Message-ID: <3d719f25-fced-e934-04c0-b821807ac69b@topic.nl> (raw)
In-Reply-To: <d2dfee96-cd30-fa16-6c83-b55773e3aa91@topic.nl>
On 25-03-18 10:17, Mike Looijmans wrote:
> On 24-03-18 19:53, Andrew Lunn wrote:
>>> A quick survey for the of_get_mac_address users learns that most of them do
>>> a memcpy (or similar) right after it, so for these drivers the
>>> "of_get_nvmem_mac_address" style signature that performs the memcpy (or
>>> better, ether_addr_copy) is a better fit, e.g.:
>>>
>>> int of_get_mac_address(struct device_node *np, void *addr)
>>
>> Hi Mike
>>
>> This is a nicer solution, but it is quite a lot of work, there are a
>> lot of users. Maybe Coccinelle can help?
>
> About 58 of them, yeah. And this looked like such a simple thing when I
> started it...
> https://elixir.bootlin.com/linux/v4.16-rc6/ident/of_get_mac_address
> I have no experience with Coccinelle though.
>
I'll at least post a v2 patch with what we've discussed so far.
Another thing that just occurred to me is that the nvmem interface would also
allow a MAC address to be written to NV storage. Haven't looked at that path,
but it would be nice to be able to permanently program the MAC address using
standard interfaces.
Kind regards,
Mike Looijmans
System Expert
TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
next prev parent reply other threads:[~2018-03-29 17:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 14:24 Mike Looijmans
2018-03-23 15:11 ` Andrew Lunn
2018-03-23 19:20 ` Mike Looijmans
2018-03-23 19:33 ` Florian Fainelli
2018-03-24 16:17 ` Mike Looijmans
2018-03-24 18:53 ` Andrew Lunn
2018-03-25 8:17 ` Mike Looijmans
2018-03-25 21:04 ` Andrew Lunn
2018-03-26 6:54 ` Mike Looijmans [this message]
2018-03-23 19:42 ` Andrew Lunn
2018-03-24 16:03 ` Mike Looijmans
2018-03-26 6:41 ` [PATCH v2] " Mike Looijmans
2018-03-26 15:50 ` Andrew Lunn
2018-03-26 18:25 ` Mike Looijmans
2018-03-26 18:41 ` Andrew Lunn
2018-03-26 16:58 ` David Miller
2018-03-26 17:05 ` Florian Fainelli
2018-03-26 18:21 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 0/2] " Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 1/2] " Mike Looijmans
2018-03-27 22:50 ` Florian Fainelli
2018-03-29 5:31 ` Mike Looijmans
2018-03-27 9:52 ` [PATCH v3 2/2] net: macb: Try to retrieve MAC addess from nvmem provider Mike Looijmans
2018-03-28 8:00 ` Nicolas Ferre
2018-03-27 22:43 ` [PATCH v3 0/2] of_net: Implement of_get_nvmem_mac_address helper Andrew Lunn
2018-03-29 5:29 ` [PATCH v4 " Mike Looijmans
2018-03-29 5:29 ` [PATCH v4 1/2] " Mike Looijmans
2018-03-29 5:29 ` [PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider Mike Looijmans
2018-03-30 14:40 ` [PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper David Miller
2018-03-31 17:20 ` Mike Looijmans
2018-03-31 17:27 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d719f25-fced-e934-04c0-b821807ac69b@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®