From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: James Clark <james.clark@arm.com>,
coresight@lists.linaro.org, anshuman.khandual@arm.com,
mike.leach@linaro.org
Cc: stable@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Pratik Patel <pratikp@codeaurora.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kaixu Xia <xiakaixu@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coresight: etm4x: Fix width of CCITMIN field
Date: Wed, 1 Nov 2023 13:23:21 +0000 [thread overview]
Message-ID: <3d744ee6-a739-42b6-8a87-124746a9287c@arm.com> (raw)
In-Reply-To: <20231101115206.70810-1-james.clark@arm.com>
On 01/11/2023 11:52, James Clark wrote:
> CCITMIN is a 12 bit field and doesn't fit in a u8, so extend it to u16.
> This probably wasn't an issue previously because values higher than 255
> never occurred.
>
> But since commit 0f55b43dedcd ("coresight: etm: Override TRCIDR3.CCITMIN
> on errata affected cpus"), a comparison with 256 was done to enable the
> errata, generating the following W=1 build error:
>
> coresight-etm4x-core.c:1188:24: error: result of comparison of
> constant 256 with expression of type 'u8' (aka 'unsigned char') is
> always false [-Werror,-Wtautological-constant-out-of-range-compare]
>
> if (drvdata->ccitmin == 256)
>
> Cc: stable@vger.kernel.org
> Fixes: 2e1cdfe184b5 ("coresight-etm4x: Adding CoreSight ETM4x driver")
> Reviewed-by: Mike Leach <mike.leach@linaro.org>
> Signed-off-by: James Clark <james.clark@arm.com>
Thanks, applied to coresight next :
Suzuki
prev parent reply other threads:[~2023-11-01 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 11:52 James Clark
2023-11-01 13:23 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d744ee6-a739-42b6-8a87-124746a9287c@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=pratikp@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®