From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: fix comment for upper usb3 port
Date: Mon, 22 Apr 2024 10:53:06 +0200 [thread overview]
Message-ID: <3d76df5e-7bdc-4318-8d2a-6d569cfc4752@theobroma-systems.com> (raw)
In-Reply-To: <20240418210332.2394871-2-heiko@sntech.de>
Hi Heiko,
On 4/18/24 23:03, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> The comment for the host2_xhci points to the wrong port on the board.
> The upper usb3 port is the correct one, so fix the comment to prevent
> confusion.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> index d672198c6b64..214f8258af68 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts
> @@ -260,7 +260,7 @@ &usb_host1_ohci {
> status = "okay";
> };
>
> -/* host2 on Q7_USB_P2, lower usb3 port */
> +/* host2 on Q7_USB_P2, upper usb3 port */
Missing the same update to the comments above &usb_host0_ohci and
&usb_host0_ehci.
Cheers,
Quentin
next prev parent reply other threads:[~2024-04-22 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 21:03 [PATCH 0/2] Add support for the dual-role dwc3 controllers on rk3588-tiger Heiko Stuebner
2024-04-18 21:03 ` [PATCH 1/2] arm64: dts: rockchip: fix comment for upper usb3 port Heiko Stuebner
2024-04-22 8:53 ` Quentin Schulz [this message]
2024-04-18 21:03 ` [PATCH 2/2] arm64: dts: rockchip: add dual-role usb3 hosts to rk3588 Tiger-Haikou Heiko Stuebner
2024-04-22 9:06 ` Quentin Schulz
2024-04-19 22:24 ` [PATCH 0/2] Add support for the dual-role dwc3 controllers on rk3588-tiger Rob Herring
2024-04-22 7:43 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d76df5e-7bdc-4318-8d2a-6d569cfc4752@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®