Re: [PATCH v1 04/23] drm/imagination: Discard pm_runtime_put() return value

[Matt Coster <Matt.Coster@imgtec.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1919 bytes --]

On 22/12/2025 19:59, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The Imagination DRM driver defines pvr_power_put() to pass the return
> value of pm_runtime_put() to the caller, but then it never uses the
> return value of pvr_power_put().
> 
> Modify pvr_power_put() to discard the pm_runtime_put() return value and
> change its return type to void.
> 
> No intentional functional impact.
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Hi Rafael,

Apologies for the late reply, I was on holiday. If this hasn't already
landed, feel free to add:

Reviewed-by: Matt Coster <matt.coster@imgtec.com>

Cheers,
Matt

> ---
> 
> This patch is part of a series, but it doesn't depend on anything else
> in that series.  The last patch in the series depends on it.
> 
> It can be applied by itself and if you decide to do so, please let me
> know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
> 
> ---
>  drivers/gpu/drm/imagination/pvr_power.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/imagination/pvr_power.h
> +++ b/drivers/gpu/drm/imagination/pvr_power.h
> @@ -30,12 +30,12 @@ pvr_power_get(struct pvr_device *pvr_dev
>  	return pm_runtime_resume_and_get(drm_dev->dev);
>  }
>  
> -static __always_inline int
> +static __always_inline void
>  pvr_power_put(struct pvr_device *pvr_dev)
>  {
>  	struct drm_device *drm_dev = from_pvr_device(pvr_dev);
>  
> -	return pm_runtime_put(drm_dev->dev);
> +	pm_runtime_put(drm_dev->dev);
>  }
>  
>  int pvr_power_domains_init(struct pvr_device *pvr_dev);
> 
> 
> 

-- 
Matt Coster
E: matt.coster@imgtec.com

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]