mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] gpiolib: remove gpio_set_debounce
Date: Thu, 26 Jan 2023 16:30:12 +0100	[thread overview]
Message-ID: <3d7b86a3-ac70-4459-a6c3-24046e81be0e@app.fastmail.com> (raw)
In-Reply-To: <Y9KFENOgVGC2bUAj@smile.fi.intel.com>

On Thu, Jan 26, 2023, at 14:50, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:27:57PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> gpio_set_debounce() only has a single user, which is trivially
>> converted to gpiod_set_debounce().
>
> Also need to mention the gpio_cansleep() removal.

Indeed, I think that bit got lost in one of the rebases
after some of the other functions that I originally
removed here are already gone.

I've dropped the gpio_cansleep change for now, we can
revisit this later and possibly drop it at the same
time as gpio_{get,set}_value_cansleep that are still
used in a handful of places that could use gpiod
instead.

> P.S. Fun fact that I was yesterday thinking about the pretty much
> the same change, except intrusive conversion of the user.
>
> ...
>
>>  Documentation/driver-api/gpio/legacy.rst |  2 --
>
> Documentation/translations/zh_CN/driver-api/gpio/legacy.rst:222:        
>         gpio_set_debounce()
> Documentation/translations/zh_TW/gpio.txt:229:  gpio_set_debounce()

Fixed.

>>  drivers/input/touchscreen/ads7846.c      | 24 +++++++++++++-----------
>>  include/linux/gpio.h                     | 22 ----------------------
>
> ...
>
>>  #include <linux/of_gpio.h>
>
> Do we need this?

Dropped now.

>>  #include <linux/of_device.h>
>> +#include <linux/gpio/consumer.h>
>
>>  #include <linux/gpio.h>
>
> And this?

I think we still need both linux/gpio/consumer.h and linux/gpio.h
since there is still a call to devm_gpio_request_one() and
gpio_is_valid().

    Arnd

  reply	other threads:[~2023-01-26 15:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 13:27 [PATCH 0/8] gpiolib cleanups Arnd Bergmann
2023-01-26 13:27 ` [PATCH 1/8] gpiolib: remove empty asm/gpio.h files Arnd Bergmann
2023-01-27  9:41   ` Bartosz Golaszewski
2023-01-27 13:04   ` Linus Walleij
2023-01-26 13:27 ` [PATCH 2/8] gpiolib: coldfire: remove custom asm/gpio.h Arnd Bergmann
2023-01-27  9:41   ` Bartosz Golaszewski
2023-01-27 13:05   ` Linus Walleij
2023-01-26 13:27 ` [PATCH 3/8] gpiolib: remove asm-generic/gpio.h Arnd Bergmann
2023-01-26 13:46   ` Andy Shevchenko
2023-01-26 15:43     ` Arnd Bergmann
2023-01-27 13:07   ` Linus Walleij
2023-01-27 13:14     ` Arnd Bergmann
2023-01-26 13:27 ` [PATCH 4/8] gpiolib: remove gpio_set_debounce Arnd Bergmann
2023-01-26 13:50   ` Andy Shevchenko
2023-01-26 15:30     ` Arnd Bergmann [this message]
2023-01-27 13:09   ` Linus Walleij
2023-01-26 13:27 ` [PATCH 5/8] gpiolib: remove legacy gpio_export Arnd Bergmann
2023-01-26 14:00   ` Andy Shevchenko
2023-01-26 16:02     ` Arnd Bergmann
2023-01-27 13:09   ` Linus Walleij
2023-01-26 13:27 ` [PATCH 6/8] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Arnd Bergmann
2023-01-26 14:04   ` Andy Shevchenko
2023-01-26 14:51     ` Arnd Bergmann
2023-01-27 13:15   ` Linus Walleij
2023-01-26 13:28 ` [PATCH 7/8] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h Arnd Bergmann
2023-01-26 14:08   ` Andy Shevchenko
2023-01-26 14:54     ` Arnd Bergmann
2023-01-27 13:17   ` Linus Walleij
2023-01-26 13:28 ` [PATCH 8/8] gpiolib: move of_gpio_flags into gpiolib-of.c Arnd Bergmann
2023-01-26 14:09   ` Andy Shevchenko
2023-01-26 14:47     ` Arnd Bergmann
2023-01-27  8:53       ` Andy Shevchenko
2023-01-27  9:43         ` Bartosz Golaszewski
2023-01-27  9:46           ` Arnd Bergmann
2023-01-27  9:48           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d7b86a3-ac70-4459-a6c3-24046e81be0e@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®