From: Dan Murphy <dmurphy@ti.com>
To: Ondrej Jirman <megous@megous.com>, <linux-sunxi@googlegroups.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Lee Jones <lee.jones@linaro.org>, <linux-leds@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/4] ARM: dts: axp813: Add charger LED
Date: Tue, 25 Feb 2020 06:56:39 -0600 [thread overview]
Message-ID: <3d7c078b-362d-6eab-0915-8079768a729e@ti.com> (raw)
In-Reply-To: <20200223131435.681620-4-megous@megous.com>
Ondrej
On 2/23/20 7:14 AM, Ondrej Jirman wrote:
> PMIC supports charging status indication via a LED. Add support
> for it.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> arch/arm/boot/dts/axp81x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 1dfeeceabf4c3..00b092f94433d 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -175,4 +175,9 @@ reg_drivevbus: drivevbus {
> usb_power_supply: usb-power-supply {
> compatible = "x-powers,axp813-usb-power-supply";
> };
> +
> + charger_led: charger-led {
> + compatible = "x-powers,axp813-charger-led";
> + status = "disabled";
As I commented before you need to add function and color to this node
and read it from the driver. Or you can add them to the over ride for
the specific use case.
Another question is is this LED only used for charging or can it be
multi purpose?
Dan
> + };
> };
next prev parent reply other threads:[~2020-02-25 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 13:14 [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondrej Jirman
2020-02-23 13:14 ` [PATCH 1/4] dt-bindings: leds: Add a binding for AXP813 charger led Ondrej Jirman
2020-02-25 12:55 ` Dan Murphy
2020-02-26 22:30 ` Rob Herring
2020-02-23 13:14 ` [PATCH 2/4] leds: axp20x: Support charger LED on AXP20x like PMICs Ondrej Jirman
2020-02-25 12:53 ` Dan Murphy
2020-02-26 14:08 ` Pavel Machek
2020-02-23 13:14 ` [PATCH 3/4] ARM: dts: axp813: Add charger LED Ondrej Jirman
2020-02-25 12:56 ` Dan Murphy [this message]
2020-02-23 13:14 ` [PATCH 4/4] ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED Ondrej Jirman
2020-02-23 13:27 ` [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Ondřej Jirman
2020-02-23 13:35 ` Ondřej Jirman
2020-02-24 6:31 ` [linux-sunxi] " Stefan Mavrodiev
2020-02-24 16:28 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d7c078b-362d-6eab-0915-8079768a729e@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®