From: "Guillaume Chazarain" <guichaz@yahoo.fr>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Dropping some patches from sched-devel
Date: Fri, 25 Jan 2008 18:27:37 +0100 [thread overview]
Message-ID: <3d8471ca0801250927r67d0a27es77f4176f89e7d8f7@mail.gmail.com> (raw)
In-Reply-To: <20080125165837.GA19377@elte.hu>
On Jan 25, 2008 5:58 PM, Ingo Molnar <mingo@elte.hu> wrote:
> sure, done.
Thanks.
> what method are you using of determining quality?
I was talking about code quality: adding a dependency on jiffies does
not seems like a good idea. But also, about the clock quality, I was
focusing on getting rid of underflows and overflows so relaxed the
checks. But I realized all these underflows are definitely needed. I
mean, the conversion from TSC to sched_clock always rounds to lower,
so overtime it lags a bit.
> Could you perhaps try
> to automate it? (even better would be some self-test within the kernel
> that detects badness)
I find the overflow/underflow/warps checks you added in the first
place to be sufficent. Not sure we want to add more tests to
differentiate between normal and abnormal drifts.
Thanks for your prompt reply.
--
Guillaume
prev parent reply other threads:[~2008-01-25 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 16:38 Guillaume Chazarain
2008-01-25 16:58 ` Ingo Molnar
2008-01-25 17:27 ` Guillaume Chazarain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8471ca0801250927r67d0a27es77f4176f89e7d8f7@mail.gmail.com \
--to=guichaz@yahoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®