From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169CCC433EF for ; Sat, 14 May 2022 05:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231809AbiENFGQ (ORCPT ); Sat, 14 May 2022 01:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbiENFF5 (ORCPT ); Sat, 14 May 2022 01:05:57 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 292FDEB1 for ; Fri, 13 May 2022 22:05:51 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-ed9a75c453so12913445fac.11 for ; Fri, 13 May 2022 22:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=X/IAgav4s9J/eHMYgeYeDUOX7BruZpeeDkv9wTzgnWY=; b=M+uGt8zf3J9fvCZPki4VDQjO6k9RWF3TwzCJRZ6+pV6g+35xfeih5qRCucqItHYPs8 zougwwQRL7sVf3h8t8ZDSs8xtH5HxaP/km8HpN+fbk+xgOwWOJFpgTdZK4VhKDpWY2R/ ctcgmcFlPVqmahsyZlDFQW8L7yO1N/8HoK4umZw/7LxTF9JzS8ps6YhLfImaSDoSFRia X6elXH8asqFGSE0kbdJTxe2rUptET18s22Cz8anvGjPQK3npB6wZuLCdHwE4U6TG8fo7 3YJf4h/lcttSV3z/UFbeuLC4zxMuMpWfflC+7um8RCFp956evzBFGVvQOETo5b3oxKYv RI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=X/IAgav4s9J/eHMYgeYeDUOX7BruZpeeDkv9wTzgnWY=; b=5epOXEoglR7bYvkt/nHyj3RupIfXvuUyKCtbyGxOI4Zdugmu79B+bIA6zUvIGOLzdl 6g+WwROiRfO62LPlfNc15M4+yXiEXvvU3a2N/KSDXhLQoGOFLUXCqd721/oWmaS88lP7 jajPQg+f0fgiAbXYLm8CtbdQFzBOA/7RfLeoQubLrU9phj/NcLe4A5K6eJJBeeyrg95A SjFo6EraIbe16mRdjHO8t8yfDo9PZ8MFZ61ESX+f2V47JSj7Nnh3MAxpOYshFyoNRwk6 ukspH9NOU7L6rOT++LkSsOTADsF0IE7Mj0Po3szokEX3NaF9X6c0UOpbDr8Xx8j6gKdk jMmQ== X-Gm-Message-State: AOAM530F+oqzM2cQifKKWEXMuG4HmbcoFhCLWuXs6FsJjmrASfFfOxSX 0hG3kU5Non7kPc6qB0PdepibCEreN5v+8w== X-Google-Smtp-Source: ABdhPJy70FSboA/M7j4vD92dz5/lEptNURnyMkDTAyA1IhHQZoa5U8vy7hqJG1EE8gw+gexfUrUTGA== X-Received: by 2002:a05:6870:a2cd:b0:ed:754:a2c6 with SMTP id w13-20020a056870a2cd00b000ed0754a2c6mr9067488oak.270.1652504750057; Fri, 13 May 2022 22:05:50 -0700 (PDT) Received: from [192.168.11.16] (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id r25-20020a4a7019000000b0035eb4e5a6c8sm2006483ooc.30.2022.05.13.22.05.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 22:05:49 -0700 (PDT) Message-ID: <3d856d44-a2d6-b5b8-ec78-ce19a3686986@kali.org> Date: Sat, 14 May 2022 00:05:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] ath10k: do not enforce interrupt trigger type Content-Language: en-US To: Kalle Valo , Krzysztof Kozlowski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Govind Singh , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , linux-arm-msm@vger.kernel.org References: <20220513151516.357549-1-krzysztof.kozlowski@linaro.org> <87zgjl4e8t.fsf@kernel.org> From: Steev Klimaszewski In-Reply-To: <87zgjl4e8t.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/22 10:57 AM, Kalle Valo wrote: > Krzysztof Kozlowski writes: > >> Interrupt line can be configured on different hardware in different way, >> even inverted. Therefore driver should not enforce specific trigger >> type - edge rising - but instead rely on Devicetree to configure it. >> >> All Qualcomm DTSI with WCN3990 define the interrupt type as level high, >> so the mismatch between DTSI and driver causes rebind issues: >> >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind >> [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000! >> [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found >> [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6 > So you tested on WCN3990? On what firmware version? I can add the > Tested-on tag if you provide that. > Hello Krzystof, Kalle, I have seen this issue as well on a Lenovo Flex 5G, which has a WCN3990: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000 kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 firmware ver  api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790 htt-ver 3.86 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1 With this patch applied, I no longer see the error message in the commit message, when I unbind/bind when wifi stops working. Tested-by: Steev Klimaszewski -- Steev