From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DDA922339 for ; Mon, 2 Feb 2026 12:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770035710; cv=none; b=lYdrhXIeNTCf9SV01IysM4U9jeH1b4Xg4/2JFGCX/te6qTHRqf7xpj66dVac2KNXVn/ko1MbSuxYgvS4VUZ1j305IqMsLa264jvszQNOieGCum6kBCcka32HT6bE16sCniO+GlRiZrabzJlJvEKum3/WMuJV2HXVQt+xCgVIiGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770035710; c=relaxed/simple; bh=ZUV+WpYJvy41qS+AsXlda1XtcYlHkozC7ARvIqjkdl4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jPAy7QYKho9WdnHF1kWZCQHltshwqNQOVxcQroVEUUrLTCRcST1hnn6LCF4CnYM0QAjhvME93/DuY/xYu8V7fjbbWnCkB64vuXL3OJ4kXs6xCZMnqA8PtWQmCcG3dt/ZMoySlApqWdvKud818D1lx0p6F2e3av7w3UposEd/lSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VO1TO/qZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CLoK/GUS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VO1TO/qZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CLoK/GUS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 612B4FZv2848639 for ; Mon, 2 Feb 2026 12:35:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +RlfaiRErFz+38qG7agb/NlNLMwIwniX7TrkIR1vmws=; b=VO1TO/qZU6sJT/0T dDKZIt9nwE/gGhEPSPMoJ7FUszbDAdt/jB0TsUoYUe7hPaZJx1JjvNYVUZVJds0U IT6cD7InL6sf+9+Mk5s0xjox7BMOBE1Ddc32wyPj8AIM6SK6c8msFKtBwZ0Uk3Mx kk2zp0QhHBpkF/lwZR8KaqhLwx8CgYW9wQf1vRvN59xBGCXeY6mysfZOIXNfz9AY DHJGilo1puhAHIBv5QfpzKlb1pN+zSX58FPygwZiGACVyp92Tzun7TBNRD4rQJl8 rRBGAgaucaUX4XZClFMM/WZ87TQahQPq+xEV/pNc41CfGupolekG0cDiWMKDDsv/ RUmkgw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2tqtg7ux-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 12:35:08 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50340abfc02so6302201cf.1 for ; Mon, 02 Feb 2026 04:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770035707; x=1770640507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+RlfaiRErFz+38qG7agb/NlNLMwIwniX7TrkIR1vmws=; b=CLoK/GUSlg/Ah0wtptrTSN2mPa1prLUN1HgO40LVEkdK4dVsavybU4IseSLoW4V0xm v7RStALHU4CQ3+uxbmhwaHfAJSyNKh9Y4uI8bmuuNRjd1DAr0MpH7iMIztzXE2pBqSaw ztGqnECR3pPTgA//yk9P7ladxKBmXCh0mSClU9iJ9V+NymtpUjrkGtIfWJyReb5HSybq dhB3HLGX4H0QJZqpwNqL7agkJJD/ciEcfJ1XYXz32946b66PLAjgSSsX09Ea6LOMVL/1 KBmkCC6ZTEDJLHXo88sqDdg+1cpTRnHKUrxPnIb8omI74ReaAdyozLQwDVfLu7CdHdWJ qaLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770035707; x=1770640507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+RlfaiRErFz+38qG7agb/NlNLMwIwniX7TrkIR1vmws=; b=VEmqcHLBKnC9fQL2I6jlNp17yQfSMgqkGeqskaZDVN7Oz6T5NjeVrOXTM7RO738IdM qHGepoxBuvyW12ph4KCjlKL43q2UgaaMLYNCvieyXX2PNNenDCLadymR9k9arESh5I9K /uQHR4L9c0YWxWe0EYHnm/BTlc6xqYlm7pphriPDoefYOTuQaiL9VE29Lqfr/jeGEK+z rzHsDAidAl+uMtOTBp+mP0vMFCqgbjlI+GuPxbFLImlz4A6RCJSuVYagkKReyRexUp4f Ay8UWK/p54Jhp4vtkWQUAsDpWiki5b4g8Z0+FanL8sRceXE59iCngOTEJMl4nz8WMTDF /F+A== X-Forwarded-Encrypted: i=1; AJvYcCWMhgkNjPTYVUnUCKB0W62YgAsma3bwpuKRMn4NA95Xg0YD908x+2Kf0rQqTssUScNZn3otdItBBYZAFyE=@vger.kernel.org X-Gm-Message-State: AOJu0YwK+3r4Csm2glICWhg/b6AW0M23Zp6rDXGTp3ygtQewLuI40Wy5 lJU+DoZJo2Lhfhq5m5q01rQknif6aaxxrpoVY8k5pW6t9DmWzHEqkYCrSTfedFEdsMAM3ge4yqt uwQ71UWACcTNHkMhbL4v3KC9S+yetSr3PymBZin33uHQhbPp7wABQw9WhqK6znTgFwag= X-Gm-Gg: AZuq6aJ/FFQaPTP/px6FWD6QTmkVfrWnoRaWGz+i833TQ38Ze2gsJSZeYnTl0paPnWM 7goMgwSJXXAvl8+Do1HQ6Hjx4KIXZVexA4p5TSbOpsjaEqqMeiffxvAS1HitifFmwN2hal3Q8T4 k9NdkSYf0vUJtslN2FKB/lemO/3Ns3NmDX8CYY1a04qiJxL9kliAKZL/goYGbAx33cw72cIVEoR MdHboV5u76p9SBdBPlYlwYoNkENNgsLf0qtPiuTQqxIlJO0FLgPzLN/nthG7UCPfVmvGiYEsk3V KI3RtIVVtzg2PPBPllWeHZS1zsNWBVtqAL5ONjoTgvY1En+pnCCmOe3OlC5zgIu+c5VtZynp3Wr TcI4qvvjdiWpJ/meDXRItm6DC7SrmUYndZqUEfPBLRWYGIO80qUoSIogyacdSvoGDNqE= X-Received: by 2002:a05:622a:15c2:b0:501:46db:6b3b with SMTP id d75a77b69052e-505d21a2a4cmr131162171cf.5.1770035707251; Mon, 02 Feb 2026 04:35:07 -0800 (PST) X-Received: by 2002:a05:622a:15c2:b0:501:46db:6b3b with SMTP id d75a77b69052e-505d21a2a4cmr131161761cf.5.1770035706657; Mon, 02 Feb 2026 04:35:06 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e0a2ddabasm3158660e87.25.2026.02.02.04.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 04:35:05 -0800 (PST) Message-ID: <3d88b354-66a2-4125-a06d-752b052bf0ee@oss.qualcomm.com> Date: Mon, 2 Feb 2026 13:35:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Wesley Cheng , Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> <6lieos5uudkgynizozrmzrj5ov57frzzl65b2fpanwbhbmehot@z5uhyv4ipyet> <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> <5a773b89-f3f8-486b-af01-3387c99e53e5@oss.qualcomm.com> <3b5685da-5178-46ec-b720-97e1ecd5310c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <3b5685da-5178-46ec-b720-97e1ecd5310c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=XP89iAhE c=1 sm=1 tr=0 ts=698099fc cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QsawANE1_QW70S-DVw0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: ku2hdcgo-KubIUSTn18LaPwwvra8I5-r X-Proofpoint-ORIG-GUID: ku2hdcgo-KubIUSTn18LaPwwvra8I5-r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA5OCBTYWx0ZWRfXxZQKvu2kcH6x ek/TneCuN5pAQja4dSsDDWUf6qJsPbUukcL2oxd385T1V9nT7faNbi/JSY4gnmeKjz/a7lKTwxz yv0qFo/t5dEI1MRd/yOzCrJDtx5qc3Ehwx6vSSq/cgNpJVjybUnm5Qln18CmwZ8WCxre312QLM0 6csfIi9LgkAV9sf4Uj2RPpf8I/nqB1uV0pJINkfvI7pxzitA99sWjyDp9mt5Q44/lHhvrxyQjuY JbgJkgE3OElEqbQfXBei1XHPPtpKBy5yImD4mI5GzzA5kG0wu0LNKX2hFtrGB1RxR+tYG1Frobk YCwz6ey9y1qxIRmJDxeHFJMB8Y2FYsYtiwRJMB3RWnVjeGub2uszdKFXEIsA6DeKoGoIhIcVgpb kVB8QEA3nYfaX4LeWZM3nN/G26mYgQCNM0nCBuCUfo5njNorHFYPIbzguntH6lULw3Unm+MteEr HyphAKhpNRq4c46aR6w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_04,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020098 On 1/31/26 1:11 AM, Wesley Cheng wrote: > > > On 1/28/2026 1:53 AM, Konrad Dybcio wrote: >> On 1/27/26 11:26 PM, Wesley Cheng wrote: >>> >>> >>> On 1/27/2026 3:46 AM, Konrad Dybcio wrote: >>>> On 1/27/26 12:41 PM, Abel Vesa wrote: >>>>> On 26-01-13 14:13:32, Konrad Dybcio wrote: >>>>>> On 1/13/26 1:33 PM, Abel Vesa wrote: >>>>>>> From: Wesley Cheng >>>>>>> >>>>>>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>>>>>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>>>>>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>>>>>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>>>>>> >>>>>>> Signed-off-by: Wesley Cheng >>>>>>> Co-developed-by: Abel Vesa >>>>>>> Signed-off-by: Abel Vesa >>>>>>> --- >>>>>> >>>>>> [...] >>>>>> >>>>>>> +            snps,dis_u2_susphy_quirk; >>>>>>> +            snps,dis_enblslpm_quirk; >>>>>>> +            snps,dis_u3_susphy_quirk; >>>>>>> +            snps,usb2-lpm-disable; >>>>>> >>>>>> Other SoCs have a list that's much longer, please consult Wesley if >>>>>> this list is enough >>>>> >>>>> Checked with Wesley. He confirmed that this trimmed list is fine. >>>>> He said he dropped the rest since they are related to the power saving >>>>> features like USB2/3 LPM (l1 or u1/u2) and we don't seem need those. >>>> >>>> Is that to say that those erratas were fixed in this hardware? >>>> >>>> Low-power states of the link are no less than desired is possible.. >>>> >>> >>> I think it was misunderstood.  We should keep the same quirks as our previous targets to enable USB LPM support in certain cases. >>> >>> snps,hird-threshold = /bits/ 8 <0x0>; >>> snps,usb2-gadget-lpm-disable; >>> snps,dis-u1-entry-quirk; >>> snps,dis-u2-entry-quirk; >>> snps,is-utmi-l1-suspend; >>> snps,usb3_lpm_capable; >>> snps,has-lpm-erratum; >>> tx-fifo-resize; >>> snps,dis_u2_susphy_quirk; >>> snps,dis_enblslpm_quirk; >>> snps,usb2-lpm-disable; >>> >>> There are some questionable ones that I'm on the fence though, which we should consider removing: >>> snps,usb2-lpm-disable >>> snps,usb2-gadget-lpm-disable >>> >>> USB L1 support is routinely being verified on our devices (in host and device modes), so if its power over performance, we should consider removing the properties to disable USB L1. >> >> Does the fact that we allow L1 entry impact performance itself, or is >> there some room for improvement in the drivers? >> > > Hi Konrad, > > Its not exactly something USB drivers have control of, as USB L1 LPM is a feature handled within the controller.  The only reason why we might see some performance hit is if we have to frequently enter/exit L1 states, but if the link never make transitions into L1, then we obviously won't take a hit. > >> >>   (esp since we're defining the HIRD threshold as well...) >> >> Wouldn't HIRD threshold be related to *U*1(/2) though? >> I see in the list above you decalred >> > > U1/U2 are USB3 LPM states, which utilize the BESL, not HIRD. > >> snps,dis-u1-entry-quirk >> snps,dis-u2-entry-quirk >> >> which forbid them >> > > These disable them for when we are in gadget/peripheral mode, but u1/u2 while in host mode is still enabled.  I'm not sure we are confident enough yet at this point to enable them (U1/U2) for device mode use cases. > >> and the threshold is set to 0, so IIUC that means entry is only allowed >> for devices that don't ""really"" suspend >> > > HIRD specifies the L1 exit latency that our device will require, and programming that to 0 will mean we'll require the minimum HIRD latency to exit L1. Seems I had a lot of misconceptions, thanks! Konrad