From: Jules Irenge <jbi.octave@gmail.com>
To: boqun.feng@gmail.com
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH 1/2] fs_pin: Add missing annotation to pin_kill() declaration
Date: Thu, 30 Jan 2020 00:29:13 +0000 [thread overview]
Message-ID: <3d8d1f596dcf556f1b9276c4e6d2f5401e598657.1580337836.git.jbi.octave@gmail.com> (raw)
In-Reply-To: <cover.1580337836.git.jbi.octave@gmail.com>
Sparse reports several warnings within the kernel acct.c file
warning: context imbalance in acct_on()
- different lock contexts for basic block
warning: context imbalance in __se_sys_acct()
- different lock contexts for basic block
warning: context imbalance in acct_exit_ns()
- wrong count at exit
The root cause is a missing annotation at
declaration of pin_kill() within the header file
Given that pin_kill() does actually call
read_rcu_unlock()in its function definition
Add the missing __releases(RCU) annotation.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
include/linux/fs_pin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs_pin.h b/include/linux/fs_pin.h
index bdd09fd2520c..d2fcf1a5112f 100644
--- a/include/linux/fs_pin.h
+++ b/include/linux/fs_pin.h
@@ -21,4 +21,4 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *))
void pin_remove(struct fs_pin *);
void pin_insert(struct fs_pin *, struct vfsmount *);
-void pin_kill(struct fs_pin *);
+void pin_kill(struct fs_pin *) __releases(RCU);
--
2.24.1
next prev parent reply other threads:[~2020-01-30 0:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/2>
2020-01-30 0:28 ` [PATCH 0/2] Lock warning clean up Jules Irenge
2020-01-30 0:29 ` Jules Irenge [this message]
2020-01-30 0:30 ` [PATCH 2/2] rcu/nocb: Add missing annotation for rcu_nocb_bypass_unlock() Jules Irenge
2020-01-31 0:59 ` Boqun Feng
2020-01-31 4:42 ` Paul E. McKenney
2020-04-29 22:57 ` [PATCH 0/2] Lock warning cleanup Jules Irenge
2020-04-29 22:57 ` [PATCH 1/2] cxgb4: Add missing annotation for service_ofldq() Jules Irenge
2020-04-29 22:57 ` [PATCH 2/2] spi: atmel: Add missing annotation for atmel_spi_next_xfer_dma_submit() Jules Irenge
2020-04-30 14:23 ` [PATCH 0/2] Lock warning cleanup Mark Brown
2020-04-30 14:41 ` Mark Brown
[not found] ` <20200803122430.82364-1-jbi.octave@gmail.com>
2020-08-03 12:24 ` [PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-03 12:24 ` [PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
2020-08-03 12:34 ` [RESEND PATCH 0/2] cleanups Jules Irenge
2020-08-03 12:34 ` [RESEND PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-06 18:33 ` Paul Moore
2020-08-18 0:38 ` Paul Moore
2020-08-03 12:34 ` [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
2020-08-06 18:35 ` Paul Moore
2020-08-18 0:38 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8d1f596dcf556f1b9276c4e6d2f5401e598657.1580337836.git.jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®