From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757972AbcK2Ox1 (ORCPT ); Tue, 29 Nov 2016 09:53:27 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45804 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757731AbcK2OxT (ORCPT ); Tue, 29 Nov 2016 09:53:19 -0500 Subject: Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload To: Jassi Brar References: <1476934445-17718-1-git-send-email-javier@osg.samsung.com> <20161024091039.GF14477@dell> Cc: Lee Jones , linux-kernel@vger.kernel.org From: Javier Martinez Canillas Message-ID: <3d940511-cb29-9b0b-b3b0-e24447a18206@osg.samsung.com> Date: Tue, 29 Nov 2016 11:53:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024091039.GF14477@dell> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jessi, On 10/24/2016 06:10 AM, Lee Jones wrote: > On Thu, 20 Oct 2016, Javier Martinez Canillas wrote: > >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias >> $ >> >> After this patch: >> >> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias >> alias: of:N*T*Cmailbox-testC* >> alias: of:N*T*Cmailbox-test >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> drivers/mailbox/mailbox-test.c | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Lee Jones > Any comments about this patch and 2/2? Lee acked both patches but I see that were never picked. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America