mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Petr Oros <poros@redhat.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"moderated list:INTEL ETHERNET DRIVERS" 
	<intel-wired-lan@lists.osuosl.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "iavf: Add waiting for response from PF in set mac"
Date: Wed, 31 Aug 2022 11:31:29 -0700	[thread overview]
Message-ID: <3d9e5deb-5de3-2a30-8e4f-dec08876ff5b@intel.com> (raw)
In-Reply-To: <20220830214309.3813378-2-poros@redhat.com>

On 8/30/2022 2:43 PM, Petr Oros wrote:
> This change caused a regressions with MAC address changing.
> It is not possible to simple fix issues caused by this patch.
> It is better revert/rework it.
> 
> [root@host ~]# ethtool -i enp65s0f0
> driver: ice
> version: 5.19.4-200.fc36.x86_64
> firmware-version: 3.20 0x8000d83e 1.3146.0
> 
> - Change MAC for VF
> [root@host ~]# echo 1 > /sys/class/net/enp65s0f0/device/sriov_numvfs
> [root@host ~]# ip link set enp65s0f0v0 up
> [root@host ~]# ip link set enp65s0f0v0 addr 00:11:22:33:44:55
> RTNETLINK answers: Permission denied
> 
> - Add VF to bond
> [root@host ~]# echo 2 > /sys/class/net/enp65s0f0/device/sriov_numvfs
> [root@host ~]# ip link add bond0 type bond
> [root@host ~]# ip link set enp65s0f0v0 down
> [root@host ~]# ip link set enp65s0f0v1 down
> [root@host ~]# ip link set enp65s0f0v0 master bond0
> RTNETLINK answers: Permission denied
> dmesg:
> bond0: (slave enp65s0f0v1): Error -13 calling set_mac_address
> 
> This reverts commit 35a2443d0910fdd6ce29d4f724447ad7029e8f23.
> 
> Signed-off-by: Petr Oros <poros@redhat.com>

Hi Petr,

Could you see if this patch [1] resolves your issues?

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/20220831135243.8623-1-mateusz.palczewski@intel.com/


      reply	other threads:[~2022-08-31 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 21:43 Petr Oros
2022-08-30 21:43 ` Petr Oros
2022-08-31 18:31   ` Tony Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d9e5deb-5de3-2a30-8e4f-dec08876ff5b@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=poros@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®