Re: [PATCH 2/2] arm64: dts: rockchip: enable NPU on rk3588-jaguar

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Heiko,

On 8/12/25 10:52 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Enable the NPU cores and their mmus and wire up the supply-regulator.
> The regulator itself was already defined, but it does not need to be
> always on - the npu can control it.
> 

My apologies for the time it took me to review and test this.

I tested with aarch64 defconfig + DRM_ACCEL_ROCKET=m loosely following 
the instructions from https://docs.mesa3d.org/teflon.html and the script 
finishes, so I guess that means it works.

I have managed to get an Oops with another defconfig, but that is not 
related to DT so not a blocker for merging this.

Thus:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Tested-by: Quentin Schulz <quentin.schulz@cherry.de>

Note that I have the same remark about regulator-boot-on property in 
vdd_npu_s0 I made[1] for Tiger here.

[1] 
https://lore.kernel.org/linux-rockchip/d784230e-49f4-49e9-be4a-bc7c00020cfb@cherry.de/

Thanks!
Quentin