From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793639359; b=TcIMKsFVqkvc34D1ysCkPijfSE/mOenJYam4WlGKVAhZX9Z+dC9kHFAjaR4Brf78HXaO 2qo2rOjCGma9W/HPBnZdznFUJTepvZ9+vYPaHwjXmsZoCHmo+KzqLInibRM2EziJXrUwB NLc3OxY9Qz8gx0A4BGd2Uqge7C5XbnosVECrORkJu5o410Q8dZcxbIM67sKA0sTIVqTSH u27kHcaLRZNMWfeEGkuC0DIoOU3JHQvGAbag+qGxwV0mQXReKpd7FiVNZu+yOZiCBjQuO L3sJKTMy2MDV7eG3yhmxtXG+S+pZOe4x35AsVzVFulfiZXHqjkU7Nxoh6vO9+cSPSIQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793639359; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=WW9GTkHRZwsz400fm+diDjo7fUTHQ83uQseXVYo8FMo=; b=h7Ci6qvGA/jQlAt1VtvqpjZPoZ6Mg60dYdCEKUGicM7n6sfHX7qJ4w1d/z7K2/rcFd4D 1QLR35GCh0P5LpmQS3T7VTZ2ONWRg5/PcIJ8+712lfVOjbIl976JIWKW0/4evoH59/ixY /NeQEewLY1KzzskWQ1MWaPITvJOItq/EdGdAg9UND2lC9O4P/Irct3WL0MANyEhR/rC5Y 6yPS66FWaQEojo9Jpdu97v3r+AV7vo1Th/ciar968ZL0yx8FARb8lTIX8RNdD045L18WF OMwQmpQla+aKJZ/etLBvroI9Tk02jSeFvJJhkRMwhE5CsF7HDrTdYVBpzCzrI8pZHZg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ClalfCpV; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=XkeyjU8z; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D2D60716C9 for ; Mon, 2 Nov 2026 17:09:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C0D2D60716C9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ClalfCpV; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=XkeyjU8z Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A2GZMWr256545 for ; Mon, 2 Nov 2026 17:09:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WW9GTkHRZwsz400fm+diDjo7fUTHQ83uQseXVYo8FMo=; b=ClalfCpVKYgZwLpG o4M35d5UPvOB5NX3PCW+UtWCe/zCbiDgH2TXEs454m/ZgbYkfA2wN5QKBrMmwhwp mW+8EFAvJ1QYqYQPZux5vIuc721PJFh5wWqUOAGFhiqI/T8N4LFG3MKtT7LFjFCd 3EDEi0Hn8mVC9sZ+OnlZj4GD/eJGFenVIGeomtnUNt8G/dKREKU3nEVoAcS1NUS3 U8PMouMLQlhGA9FU8XdmrIju7alWNd1a7Y/ZQcVXQd11BTcuff0EN8SgCDh55Rbu 8z4Rkjyx7U7UMEpUYKcwf2UDODeyyzSpiZNxEhXj4yFunj29HlC5NDz2SxcLrNMk jrlTVQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hpss5hf5d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Nov 2026 17:09:17 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3ac7a4ba546so3185686a91.0 for ; Mon, 02 Nov 2026 09:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793639356; x=1794244156; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WW9GTkHRZwsz400fm+diDjo7fUTHQ83uQseXVYo8FMo=; b=XkeyjU8zw5vb3LRIH5CoQoTEUZwAtCQE23Ian2FZjZf3jIIZF6TkUg5bG3NZ4OOVYX U5UbmuzwBz+jYj9NKGt0WN+uCgjsYLl6X6vbpfNi5b0oNR54ziPnegaNGTmbPX76sOAh Ook5snab4oqXo2nuwayn/ht4HAbJ7+GaCWAVCBYEkn2gL60msMd5ld4ePGLq0fQwR9AZ o1DcF2mDc6zQs+tSzfl3m5Iph8MTxHfEOCjv88nJXzxkEjKciD8/m96/O9z8mVItC/xI Z5mSs6ctD7HinJ6iVSWXmHfGba+tHb6TVmGuS/KpIPAg1NgdQ8vGbGwUUcWKjGzAqg0d MOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793639356; x=1794244156; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WW9GTkHRZwsz400fm+diDjo7fUTHQ83uQseXVYo8FMo=; b=WCqQbFmIFuv3ZgD8eDhXiYI7lQlIi7WKwyFK19LJvcwoaoOEalZp1laF3mAPWspvTp z7/nUvLVRKnlbbBDJ7cSS5oJAzRCKKOwpq3iqpaG8/NY4vKrLALzJZrnY0DhnyWLzQVt xIEZyp7FZHVqvSLz9IoWlTKVDuz3IgH6DLbPjt0DT0pjOCdIqSvNYg2HdWcSL87Y+ZRK xfIu8d7qcgoFIMVXr9ih4bIn0kbzqWtzvzIklIXerYyExNlZw/av7vjDwtVpVJpRIlSF GSTHy5UCcMkBXNKkjCDcWhPbxmV7/1bFt+a6aPjOspoeqbyKJ+nPb5fuYbkyzoIGllbF mNbw== X-Forwarded-Encrypted: i=1; AKwUvBzEQT6xlcYR9msIN9b6JmeLp80kqgLhc5S/hocGNzHf9+GukWeiDvUuB5T5bcY8pE7kwgWtas0TYPrbSO0=@vger.kernel.org X-Gm-Message-State: APuU4Z+dk8egxIZ8Zj3RV6BteLpdlRfbTVrv5+432qUSPTTyV027Lclr AaB3IMhWdCJEIDWSkQIiTlhSdK7ECzrX81HcN0/ra3VXLqh/IJ+5gy332Je47aYFeRccQfQ6UPH mi9sD75klTpxrUPz1Gh2viI1PF33hgUzUcZpk4NsJ2Q3awvbpA3fL2Zzn0WOvsjyolwo= X-Gm-Gg: AYBFou0wVwhGFoQhhefky7mtw7HxkXybiGyWe3Q8U4jCcdLWGPlNhSiQsr8aABJvBvN SH6B7Ka0/bcKdfn/hRBpgU65Jgwo/oYVt/oRlAs2GTEpm+CVYYvMZRuWBbPTfvcGzjYBppJet3v Zzq5XfhMNrgCZvWSWtEcf5QGTlgtD+W1K/vGaTrfEEXIdGcCVTmubyhWCQyOLA824M1eBjXG54X 5JNQpaEcCOD8VMQtBOssdkFkdxYLMU0FqPf6ivvHXdur1mli6aFl07n34hs8EfJiYBX+cxqKo5c NyOMFkTH/z/NMUO8SUa8IyaN/tIYwCI/Kn0aWG/uVMu7NurPDL9jDHBZU22Vsc2bX9eb9KdDTQm bGF3ekHATzbpZ/KOU8RAP/I1WVGjowR4ZWy1yZ3tIJwAQSioiWr6/kMgXnjtCHYQyk6pAvOsFvk 91k0otFB4AulEnkayGZaDZM80xDp9SAdyc5mepF5c= X-Received: by 2002:a17:90a:ea0c:b0:3ae:8983:4ef8 with SMTP id 98e67ed59e1d1-3ae89834f45mr4756793a91.9.1793639356399; Mon, 02 Nov 2026 09:09:16 -0800 (PST) X-Received: by 2002:a17:90a:ea0c:b0:3ae:8983:4ef8 with SMTP id 98e67ed59e1d1-3ae89834f45mr4756766a91.9.1793639355846; Mon, 02 Nov 2026 09:09:15 -0800 (PST) Received: from [192.168.1.6] ([122.177.242.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b07c6c4259sm35635a91.14.2026.11.02.09.09.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 09:09:15 -0800 (PST) Message-ID: <3da347c7-6c7d-477b-afe6-9dbb37208438@oss.qualcomm.com> Date: Mon, 2 Nov 2026 22:39:07 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] arm64: dts: qcom: glymur: Set snps,resume-hs-terminations for USB controllers To: Peter Chen Cc: Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Conor Dooley , Dmitry Baryshkov , Abel Vesa , Wesley Cheng , Udipto Goswami , Jack Pham , Pratham Pratap , Thinh Nguyen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20261019021547.1694088-1-peter.chen@oss.qualcomm.com> <20261019021547.1694088-2-peter.chen@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <20261019021547.1694088-2-peter.chen@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=VORIDNPX c=1 sm=1 tr=0 ts=6ae8c3bd cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=4cW2FY/XLap1olThQF9nEw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=ptdc_f1R2aCmbPsLd1wA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: PfT3gU7htUNDceZ1-QsCo5iCdkB_Mjfc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTAyMDA2OCBTYWx0ZWRfX0iwIYrSTKiu7 Ossdl0WK4bOF869g+DJE/kJlQXQY0NuQ4kB+9PiKnJbSvgk4BGseKV9Pa85MRfpjs+DexpGVfjP SojPVKbtoS5Lzx6Gl/SaP9ZdfJtU/yjvTXuo2qyFEBw5olqZnVeuJnoN5PfiXOc6y1dAJWYkjaU z9Px6OhviNt5/eJRbYa0QNR/TUfTo1JpcjJ/SUVPZa0WjtBkLVFJ3YHipyN0KqysH6iFC0yJChV ptWsXSHPZ8YQR4vDI0Adcw1CyKnjjbVbuIndLad/DliZtQwGD64rb01Cx/H+Zb1yE3AC76zP18x +784j8oIHGODelYf01djEzATaICRJzuuy/pyL60dgs0DotNaXV01dq3orXIjMT1JjkYUyBNNPVa xe3B93bdz72M3YzLQtziniUTgdlHKbAIYnSIX78R9jJX883HlO+D/Wz0GCwMY3dRxL7ifAqOEya 0OkOnRLFEPOXSsooGJw== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTAyMDA2OCBTYWx0ZWRfX+ErqL4WuEiJ9 FedWi2NDpHrrabunK0Pcs3gR8pG9iisCwgr63ZCXIFuqgS/kvx8LUNCK1XizlIALET6LXCdUnt4 ykztyiq/FUs+SJ0TrlhLQ0jF67Sl6lU= X-Proofpoint-GUID: PfT3gU7htUNDceZ1-QsCo5iCdkB_Mjfc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-02_04,2026-11-02_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611020068 On 10/19/2026 7:45 AM, Peter Chen wrote: > The DWC3 controllers on Glymur are paired with the M31 eUSB2 PHY. > According to HPG, host-mode USB2 L2/L1 resume with this PHY, GUCTL1[10] > (RESUME_OPMODE_HS_HOST) must be set. > > Without this bit setting, USB2 HS device cannot be reset after it is > runtime resumed. For example, after: > > echo on > /sys/bus/usb/devices/1-1/power/control > > PORTSC.PR never clears (PORTSC = 0xe11) and the hub driver fails with > "port_wait_reset: err = -16". > > Set snps,resume-hs-terminations on all Glymur USB controllers. This > makes dwc3 core set GUCTL1[10] and fixes the issue, tested on Glymur CRD. > > Reviewed-by: Konrad Dybcio > Fixes: 4eee57dd4df9 ("arm64: dts: qcom: glymur: Add USB related nodes") > Assisted-by: Claude:claude-opus-5-5 > Signed-off-by: Peter Chen This also fixes one more issue in Glymur wherein the HS Pendrive disconnects after exiting pm suspend. Tested-by: Krishna Kurapati Regards, Krishna, > --- > arch/arm64/boot/dts/qcom/glymur.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi > index e269ae6e10ea..023a8448449c 100644 > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi > @@ -5544,6 +5544,7 @@ usb_0: usb@a600000 { > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,resume-hs-terminations; > > usb-role-switch; > wakeup-source; > @@ -5620,6 +5621,7 @@ usb_1: usb@a800000 { > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,resume-hs-terminations; > > usb-role-switch; > wakeup-source; > @@ -5696,6 +5698,7 @@ usb_2: usb@a000000 { > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,resume-hs-terminations; > > usb-role-switch; > wakeup-source; > @@ -5783,6 +5786,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,resume-hs-terminations; > > maximum-speed = "high-speed"; > > @@ -5858,6 +5862,7 @@ usb_mp: usb@a400000 { > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > + snps,resume-hs-terminations; > > dr_mode = "host"; > wakeup-source;