From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE22E262FC1 for ; Sat, 29 Nov 2025 13:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764424503; cv=none; b=iw2T13Zx8vhVz97JofNm4DgBmGtUJxJX0f5meldKkNk+44Ssc2KD1EqPG7R0EdfUx0bLdCBU/lR8OTV5us6w8mk5+dnDhNIMxBU2zNXMgo8Hw/qDYts6typkhMsy/DrcqFs3Xc6IW+QC/EmMrNhKwRh33cnf5fFC1knDRGdRwn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764424503; c=relaxed/simple; bh=gWKYc2eLaVGIJXFIP+DdXwUaHyC08QdUjzDZibaaXRI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ukms3zGXj+9Z9gnbef/mvA59PvcR6M1uQk3BSIeoyxJzB/yzvQnKmOV8UOX8kzjbLQGmg8LCsESgDVdN38JUPHl2alY+yamgn6iCzfA8iKBYMAc5Oy9MtdP756pHyjGW/3UngphkRvBjs3YYPDKJDpeBtrBkKY6p+o7VT5sKm3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fKUFSkR5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fKUFSkR5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso20912095e9.0 for ; Sat, 29 Nov 2025 05:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764424500; x=1765029300; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kuJJa1QyfSgZDITAN+wzAijav66vEdBFiqUvaGNcsFE=; b=fKUFSkR5T0o+k6XbDm8x+N6VBjo0Y7qmv/YMEUlQi3Ow0zmjfcY/BcBSQ6F2LIyBqX SgODaSLPQTixQhL9wqRz8XTrYFmvy7cEfibT/FVuGbHyNBq6eQBxFI2UmzGRdEmnbTU6 EeYkzgIZdCNzbKY4qDIE/ZAHp+RqAa00sOBzeOzB+ToLr2vplFQdP+zefMx8lOmd2YlC eXppCYRPsBRE28nEh9JLFqlWczbx65dQMlhCXJGbzLarEXCP5iBb8DKLoCfd2C0qSY8p 3FBgHRTnlP/oa/eZZf08PezmKDHeANjtY++zG34VLqrbI29C1tC6V8E9i6ZqR9FQEuKP RGgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764424500; x=1765029300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kuJJa1QyfSgZDITAN+wzAijav66vEdBFiqUvaGNcsFE=; b=M6JL3RqvsbAYlVzTpMToJJTORS6Xrj39iwpmmcOjKD6wO/Fnir4uvF/BSE8z0KBQHb DX6h6Ec9btHKMbR1PcTbix16z4YtUgOZ6rIcfhNyK+p26QjZk9rUtEZnFXzTPFkHR0C6 4j35iSqZyfQCgK7yTetqTOh61RI+cUvGHaTXO4D9kWOFFiubAWW9PbY3kpnvocQdRNcF xQJmLCL/ciAZpUuJlGEHQw5uBRSAaGXJbtw8K502n79oZOwvmTF0UiYC16X1PSGMf8Co xFCq8PHCDgSaKjrV4zOcV2+xW8GI0RIjaWhu+QwnfwP6LC27ocJI3vCHmGeUnBTiFmU5 6slQ== X-Forwarded-Encrypted: i=1; AJvYcCU00+p5dyiguwU5kf1rEOh3EVfoQasL9+/10fwSqrtO9JhlV+y1wzIoa9YI+Q56x0TgIJzumvfrtDUtAyE=@vger.kernel.org X-Gm-Message-State: AOJu0YyK9azpmJU1MmivFo9O+ATUxISv+VoRw5iBxM1PQ45tpgpTJt9Y vQQgpZ/ZBue71aDSx58RRMPa27AfdbyJ2X4kRflw196Opu1XflJExOBU X-Gm-Gg: ASbGncttWAripayJ+Bk84d3p/piRwHg7Y9whUpVEeIPFyLV7yscF/YgyjO7fDj3krO9 509xoEcakjDxyfvkj27ygJgGYhBGduxpkg9PgXLWeciQFYa7d/H7AbTJdjGNaTpU6YvccBJinrE Nu0PwCjhlRtlGnoGcZzgvl0mcPQBiz/fU4hjcUqByoqDPtsTNI55pht5HcIavyos32yBIMrrT3i qlT6WxjRKtMK2JC7Bre/JoNaDnY3rXOfTWsbHcMJe0dmCnb96EHp4viD3jtoFG+I5qViMJLHcWD xfsk8/JLVzSlxjGhfoXgvHjF0JSq7aKVlpbyIPbgfbq3r4btW8qzaLxbvvWD6FFgah4vZE8Hsy1 6Fq/c5wtu77MQp8s0Y8v3XOleJ1YBHEZWx4Prb8PXuk7P3xUTdJqF/Lqe0JTH0OMNZ50VBUnIGC VA9IN8iIUp9OhvTvhTxakgf6Q= X-Google-Smtp-Source: AGHT+IFnYjShq3rPpM766kWeJ3++2I/bYOmZL/eRZqSUa9tMG8SkQxhaeeLvqdMubHFcw0q1cKRIOg== X-Received: by 2002:a05:6000:228a:b0:3e7:6424:1b47 with SMTP id ffacd0b85a97d-42cc12f1bbamr37984898f8f.6.1764424499866; Sat, 29 Nov 2025 05:54:59 -0800 (PST) Received: from [192.168.1.121] ([176.206.93.222]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c3016sm15759806f8f.1.2025.11.29.05.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Nov 2025 05:54:59 -0800 (PST) Message-ID: <3da3baa8-aaea-45eb-a560-b81151a85803@gmail.com> Date: Sat, 29 Nov 2025 14:54:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] platform/x86: asus-wmi: use brightness_set_blocking() for kbd led To: Anton Khirnov , Corentin Chary , "Luke D. Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Jian-Hong Pan Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251129101307.18085-3-anton@khirnov.net> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: <20251129101307.18085-3-anton@khirnov.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/29/25 11:13, Anton Khirnov wrote: > kbd_led_set() can sleep, and so may not be used as the brightness_set() > callback. > > Otherwise using this led with a trigger leads to system hangs > accompanied by: > BUG: scheduling while atomic: acpi_fakekeyd/2588/0x00000003 > CPU: 4 UID: 0 PID: 2588 Comm: acpi_fakekeyd Not tainted 6.17.9+deb14-amd64 #1 PREEMPT(lazy) Debian 6.17.9-1 > Hardware name: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B9403CVAR/B9403CVAR, BIOS B9403CVAR.311 12/24/2024 > Call Trace: > > [...] > schedule_timeout+0xbd/0x100 > __down_common+0x175/0x290 > down_timeout+0x67/0x70 > acpi_os_wait_semaphore+0x57/0x90 > [...] > asus_wmi_evaluate_method3+0x87/0x190 [asus_wmi] > led_trigger_event+0x3f/0x60 > [...] Hi and thank you very much for this! Reviewed-by: Denis Benato > Fixes: 9fe44fc98ce4 ("platform/x86: asus-wmi: Simplify the keyboard brightness updating process") > Signed-off-by: Anton Khirnov > --- > v2: > - reworded commit message, adding traceback > - merged lines in kbd_led_set() signature > --- > drivers/platform/x86/asus-wmi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index e72a2b5d158e..8e3300f5c294 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -1619,14 +1619,14 @@ static void do_kbd_led_set(struct led_classdev *led_cdev, int value) > kbd_led_update(asus); > } > > -static void kbd_led_set(struct led_classdev *led_cdev, > - enum led_brightness value) > +static int kbd_led_set(struct led_classdev *led_cdev, enum led_brightness value) > { > /* Prevent disabling keyboard backlight on module unregister */ > if (led_cdev->flags & LED_UNREGISTERING) > - return; > + return 0; > > do_kbd_led_set(led_cdev, value); > + return 0; > } > > static void kbd_led_set_by_kbd(struct asus_wmi *asus, enum led_brightness value) > @@ -1802,7 +1802,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus) > asus->kbd_led_wk = led_val; > asus->kbd_led.name = "asus::kbd_backlight"; > asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED; > - asus->kbd_led.brightness_set = kbd_led_set; > + asus->kbd_led.brightness_set_blocking = kbd_led_set; > asus->kbd_led.brightness_get = kbd_led_get; > asus->kbd_led.max_brightness = 3; >