From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FC7C418A36 for ; Thu, 30 Jul 2026 11:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411157; cv=none; b=biBv1N7MogUswBMoJAica23n9Zi7TNXQ2ofgbiBvNU7tjrJujiP/AV06YoxZbnCRtexDglpnB8np9ax6hURU2VU3TC9hSaDZVa9jbMscX1kqMSC3ISD0wIbrCZXHnv+h2D/BYKL7MIM351w5+xCLNUQ0IlVRXL8Q5woVB2Cfj2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785411157; c=relaxed/simple; bh=N9Ohv6rcdNYwhoH7sgF7IMFqPbPWZ8UU9+WoZm0Q1PM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qy9UFkUgLv5xXlqupt+KtpdLxOKTDvgA8nZaEyciGT0Or3EujpQ8WMVRHxMuwOd0lgxLmlJdqYR6IYVA0sAXY1PkUSXVAaEl5jxiCtpJT6gCmkjjktEnDoGJa0P4LrTScE18Hx8f1H0pLwcgR/C+srQNeTWfa8ma5QBtXRRN6EA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f+s+ANf/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AGUZPEme; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f+s+ANf/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AGUZPEme" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UA2fk4735495 for ; Thu, 30 Jul 2026 11:32:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mU3S2KFyCM2FJ/zPY3ZKd6sbQzwi2C1DPhH/yC8ntBg=; b=f+s+ANf/k1s576D5 LIvfUa17zlcR+dIgzS72oMwvXrvZK/6kAyystl+icmj6yqXfoDgYJ4hhVBueI04C q/IfrBUiivE6c4nFF3cr4iDoZSJre2Yv/K7EIb6joVU11XY/e2aHGrgvP1hVu5hJ uxMIXlVyLlpBlxT4e8VtbEkekWNcNV/Mmcnzp/f2Jn7iSiKwdXiD3iZaNfu9kG/B 0WsaOZJVEfcMiR+wrg5BeyBZ99WUHD+miL5e5bj/qlpqCBXRQJ58F9d9ANjSDiGC FvQBzIP8FXC/pZfjKz/vrTdEvQTkD81QxM5wl6aQZ0O/IwK335oRaY0X20cPx2jB Xq3A8A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr4a2ge2r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 11:32:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-930edae07a7so34461585a.3 for ; Thu, 30 Jul 2026 04:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785411154; x=1786015954; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mU3S2KFyCM2FJ/zPY3ZKd6sbQzwi2C1DPhH/yC8ntBg=; b=AGUZPEmeqOidzVYwivVxxuJYks1pGvvAqWZtHi2CevuFbyRDRKAu7AX17qI+G+7Cg+ 5D+JgWg36mKgcoVEd3fU+3nZ2Jg5napIysRDZc6qL0Cx/DbWyv1ebIc4HlnBYRXGJgJ9 kVW01KTqvB9CJ/GDctxAdHVDcGFMBKiin3x68fdxY8NvqHCbhyNe6Ti1TBHd8hphrOjA fVwx/LWFE46O5aFaY9h5xUWigCErzNzNOmTzb1EiAO3I80hxvAK5RlBjlsyKGipo3Z1+ 0rQWduBvHvLDd4ui5CoBtHihXw7fIXQo0NrzaYAEZGLRVQE/+GnxmZ1nHnsV9JcticMb BhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785411154; x=1786015954; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mU3S2KFyCM2FJ/zPY3ZKd6sbQzwi2C1DPhH/yC8ntBg=; b=oMGgBASQ/cl8c1VJ46ZmRYgHP7k1oeKwBRZKvx4ikhnwil4jDz9dgfx5v7exNTirlh FbiZITFr/01fzRYZNTj23g69sGq2Z95IFpHtUV93PX2mrEveauLw+DkCxAisK9To5w7T F68vaWU1ePsBG5H/pnu6dNi2jyvAz9VNSZS6gr1IKk+Ys9H9VZFzWb1EXEQQXw3O30yY GIB49E0nrldrhI3v5zmffyjG6Lv4ja/VbrXxef3IUGziayEhxVDAw3P32khpIcuvVWZl XCSX+yNLcyHIHXCAze2xxv2J35CXzBHEbruPbyZTek+rTn0pcgdTuq93FtzJWx2gqT0f X6oQ== X-Forwarded-Encrypted: i=1; AHgh+Rr1EaLBu6+RZ2FtUpFtKMkgWch2ofv40Y30ymj65/QapVwJ/0xJMicmzvr8ht1nJRqKadd5wuj8Us5lPuI=@vger.kernel.org X-Gm-Message-State: AOJu0YwkhM5HybqQfS2/9SYSAi+NT3ICbaJhE1TnrsW+VjzH52dl5DoE QUVHirP6UZuMm5w6Q0lEsGuJAdBxNMyQbduFQoBdwZs85MsW1zl0dTA7XYKJ63tjhUaYPE3yM4x C7+QL3QURjxpfTcoxz4MBqAEUsbM1dU7EbCCKaL1u56TLH9N2jWJ8ANMHJTmMIRVEY5U= X-Gm-Gg: AR+sD13faiyHlzijv1Fa4+kGlwq477z1esFLvxbZXahK5wmZ4DEfxANKHFzWbgwQWoG YNEbQtL6l3ZPO16gnmU7XUJHDfkxboGMW8C5dFWWctfR+OC1sxXkXZW72v2LdjeVIaut0CMsb4G OdQ0ANqR3IA8G2Dd8euUu1df2JV9dVn8k6ypLqIHfsqGKzgITnXCmwhHoV4rHmiPWqlyf/lSVht psiu5h0fCs/hSGd/zi/Cg/Ac1W1weFOjSK62vOiqrUHK3+EuXahgyetoZVsS5KvgxwYPKYfaQlw /OlfuJM1suBXsJ86OA8x4TcIBAKZU+h8LUyLTnN0ZnoNoSDUzHONXUPoeJ4M/M+uoy2OTHjaL4E oSo7pKrLHQ100pbooLmFqHc0u X-Received: by 2002:a05:622a:6d01:10b0:51c:845b:ac4 with SMTP id d75a77b69052e-52b386944b1mr27789391cf.3.1785411154298; Thu, 30 Jul 2026 04:32:34 -0700 (PDT) X-Received: by 2002:a05:622a:6d01:10b0:51c:845b:ac4 with SMTP id d75a77b69052e-52b386944b1mr27789051cf.3.1785411153808; Thu, 30 Jul 2026 04:32:33 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fa857c8e1sm59328866b.19.2026.07.30.04.32.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 04:32:32 -0700 (PDT) Message-ID: <3da755bd-ab8c-4d2f-b7b0-6cd7eeb4808a@oss.qualcomm.com> Date: Thu, 30 Jul 2026 13:32:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: Fix test_ctl_hi field for DEFAULT_EVO PLLs To: Imran Shaik , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Shawn Guo , Dmitry Baryshkov , Iskren Chernev Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260729-pll-test-ctrl-fixup-v1-1-246d79589380@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260729-pll-test-ctrl-fixup-v1-1-246d79589380@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 1_TzjUx7lMNusvSeoBCTFjraO5cEPTYu X-Proofpoint-ORIG-GUID: 1_TzjUx7lMNusvSeoBCTFjraO5cEPTYu X-Authority-Analysis: v=2.4 cv=IoIutr/g c=1 sm=1 tr=0 ts=6a6b3652 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=HWpFVbl4Vm_CWwIzw78A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA4NiBTYWx0ZWRfX+Fe1g33ELAnm 8MUp1QEkZfzdjOVbx8+pSZPzB1JklTi2Q6/L4cf1OJrxwYkEdRYv0nXJHBNUMwlj2WtieGXkV0B ce9hREwr/ILRfwiaQnDPTP24SsadeIIp6YP/ticKfNjoXO2rBDK+aHHH9JYuyW6+wyoXY7gJd/N GzFz2DjzRH9dM8PJo0UpBFCMnzOcbblxRPc0d/5HpVtKbCxQUct4W063F/QtIhWnRqnPGvh3PBo m9nvhU0Q/xRCkWbbSTqPqB8vTCMlsK8H2fE2bLZPCtbGvBrr7etuCnG/DhOJCn5iM1F0A6giONI VWaLIA+0SSuoh9D0A13MiZMqRfc0qSkDzVIcxT95d+LmNGGoKGP6WaK1vTZ2V0st+k2AFKdRRr+ dqLqma9+fWHXgYPkgLJwawcscPkpxVmpyeRGUeoDX+ZOd1LbWCxwIGLaxn+x1ARVg9OdDglNtuf RIA6TGBewFeWQAp9XYQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA4NiBTYWx0ZWRfX3OJVOY/va55G VDX98jFtnlzVe6U1co1u5zcmY7W/+aYZhuZowMLXaFhS09hDEQb7wtq4KEM0io4vy7yOU2RqvwI EfkwE9wwYwT/lyithxnxCXVE7fYh5P0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_03,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300086 On 7/29/26 5:23 PM, Imran Shaik wrote: > CLK_ALPHA_PLL_TYPE_DEFAULT_EVO type PLLs do not have the PLL_TEST_CTL_U1 > register, so clk_alpha_pll_configure() does not program test_ctl_hi1_val > for this PLL type. > > The GCC PLL configurations for QCM2290, Shikra and SM6115 wrongly use > test_ctl_hi1_val instead of test_ctl_hi_val, deviating from the hardware > recommended settings. Fix them to use test_ctl_hi_val. > > Fixes: 496d1a13d405 ("clk: qcom: Add Global Clock Controller driver for QCM2290") > Fixes: 01cf3e27824d ("clk: qcom: Add Global clock controller support on Qualcomm Shikra SoC") > Fixes: e88c533d8a2a ("clk: qcom: gcc-sm6115: Add missing PLL config properties") > Cc: stable@vger.kernel.org > Signed-off-by: Imran Shaik > --- Reviewed-by: Konrad Dybcio Konrad