From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A928C4167B for ; Mon, 11 Dec 2023 12:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343525AbjLKMQC (ORCPT ); Mon, 11 Dec 2023 07:16:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234869AbjLKMPj (ORCPT ); Mon, 11 Dec 2023 07:15:39 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E2C2F3; Mon, 11 Dec 2023 04:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1702296940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L7kf+hcbV1aunzsc1VgHXPmGkTxyrjAbnWlUqmjpkTo=; b=APV739V1DwujHZ/HRZTNPFrxBD2Tls1tzP0FkljoQUKl2aBbwAs9PFWm7i5M+3AjOeEj6s GkMR+tAVdKzPn2t4Irv0rSPjQsIeG0XB1V+D+SOgtCg9zTH391azMl5da0b0xSebMXpC33 9T1rd6FRM76yNCLrA2YNUAZfVgL69vk= Message-ID: <3da88ffe37e1fa20918848fdef8f80e5ae49743a.camel@crapouillou.net> Subject: Re: [PATCH 1/4] dmaengine: axi-dmac: Small code cleanup From: Paul Cercueil To: Vinod Koul Cc: Lars-Peter Clausen , Nuno =?ISO-8859-1?Q?S=E1?= , Michael Hennerich , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 11 Dec 2023 13:15:38 +0100 In-Reply-To: References: <20231204140352.30420-1-paul@crapouillou.net> <20231204140352.30420-2-paul@crapouillou.net> Autocrypt: addr=paul@crapouillou.net; prefer-encrypt=mutual; keydata=mQENBF0KhcEBCADkfmrzdTOp/gFOMQX0QwKE2WgeCJiHPWkpEuPH81/HB2dpjPZNW03ZMLQfECbbaEkdbN4YnPfXgcc1uBe5mwOAPV1MBlaZcEt4M67iYQwSNrP7maPS3IaQJ18ES8JJ5Uf5UzFZaUawgH+oipYGW+v31cX6L3k+dGsPRM0Pyo0sQt52fsopNPZ9iag0iY7dGNuKenaEqkYNjwEgTtNz8dt6s3hMpHIKZFL3OhAGi88wF/21isv0zkF4J0wlf9gYUTEEY3Eulx80PTVqGIcHZzfavlWIdzhe+rxHTDGVwseR2Y1WjgFGQ2F+vXetAB8NEeygXee+i9nY5qt9c07m8mzjABEBAAG0JFBhdWwgQ2VyY3VlaWwgPHBhdWxAY3JhcG91aWxsb3UubmV0PokBTgQTAQoAOBYhBNdHYd8OeCBwpMuVxnPua9InSr1BBQJdCoXBAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHPua9InSr1BgvIH/0kLyrI3V0f33a6D3BJwc1grbygPVYGuC5l5eMnAI+rDmLR19E2yvibRpgUc87NmPEQPpbbtAZt8On/2WZoE5OIPdlId/AHNpdgAtGXo0ZX4LGeVPjxjdkbrKVHxbcdcnY+zzaFglpbVSvp76pxqgVg8PgxkAAeeJV+ET4t0823Gz2HzCL/6JZhvKAEtHVulOWoBh368SYdolp1TSfORWmHzvQiCCCA+j0cMkYVGzIQzEQhX7Urf9N/nhU5/SGLFEi9DcBfXoGzhyQyLXflhJtKm3XGB1K/pPulbKaPcKAl6rIDWPuFpHkSbmZ9r4KFlBwgAhlGy6nqP7O3u7q23hRW5AQ0EXQqFwQEIAMo+MgvYHsyjX3Ja4Oolg1Txzm8woj30ch2nACFCqaO0R/1kLj2VVeLrDyQUOlXx9PD6IQI4M8wy8m0sR4wV2p/g/paw7k65cjzYYLh+FdLNyO7IW YXndJO+wDPi3aK/YKUYepqlP+QsmaHNYNdXEQDRKqNfJg8t0f5rfzp9ryxd1tCnbV+tG8VHQWiZXNqN7062DygSNXFUfQ0vZ3J2D4oAcIAEXTymRQ2+hr3Hf7I61KMHWeSkCvCG2decTYsHlw5Erix/jYWqVOtX0roOOLqWkqpQQJWtU+biWrAksmFmCp5fXIg1Nlg39v21xCXBGxJkxyTYuhdWyu1yDQ+LSIUAEQEAAYkBNgQYAQoAIBYhBNdHYd8OeCBwpMuVxnPua9InSr1BBQJdCoXBAhsMAAoJEHPua9InSr1B4wsH/Az767YCT0FSsMNt1jkkdLCBi7nY0GTW+PLP1a4zvVqFMo/vD6uz1ZflVTUAEvcTi3VHYZrlgjcxmcGu239oruqUS8Qy/xgZBp9KF0NTWQSl1iBfVbIU5VV1vHS6r77W5x0qXgfvAUWOH4gmN3MnF01SH2zMcLiaUGF+mcwl15rHbjnT3Nu2399aSE6cep86igfCAyFUOXjYEGlJy+c6UyT+DUylpjQg0nl8MlZ/7Whg2fAU9+FALIbQYQzGlT4c71SibR9T741jnegHhlmV4WXXUD6roFt54t0MSAFSVxzG8mLcSjR2cLUJ3NIPXixYUSEn3tQhfZj07xIIjWxAYZo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, Le lundi 11 d=C3=A9cembre 2023 =C3=A0 17:27 +0530, Vinod Koul a =C3=A9crit= =C2=A0: > On 04-12-23, 15:03, Paul Cercueil wrote: > > Use a for() loop instead of a while() loop in > > axi_dmac_fill_linear_sg(). >=20 > Why? Simplicity? Code quality? -Paul >=20 > >=20 > > Signed-off-by: Paul Cercueil > > --- > > =C2=A0drivers/dma/dma-axi-dmac.c | 5 +---- > > =C2=A01 file changed, 1 insertion(+), 4 deletions(-) > >=20 > > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi- > > dmac.c > > index 2457a420c13d..760940b21eab 100644 > > --- a/drivers/dma/dma-axi-dmac.c > > +++ b/drivers/dma/dma-axi-dmac.c > > @@ -508,16 +508,13 @@ static struct axi_dmac_sg > > *axi_dmac_fill_linear_sg(struct axi_dmac_chan *chan, > > =C2=A0 segment_size =3D ((segment_size - 1) | chan- > > >length_align_mask) + 1; > > =C2=A0 > > =C2=A0 for (i =3D 0; i < num_periods; i++) { > > - len =3D period_len; > > - > > - while (len > segment_size) { > > + for (len =3D period_len; len > segment_size; sg++) { > > =C2=A0 if (direction =3D=3D DMA_DEV_TO_MEM) > > =C2=A0 sg->dest_addr =3D addr; > > =C2=A0 else > > =C2=A0 sg->src_addr =3D addr; > > =C2=A0 sg->x_len =3D segment_size; > > =C2=A0 sg->y_len =3D 1; > > - sg++; > > =C2=A0 addr +=3D segment_size; > > =C2=A0 len -=3D segment_size; > > =C2=A0 } > > --=20 > > 2.42.0 > >=20 >=20