From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FF03AB26D for ; Tue, 9 Jun 2026 09:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999036; cv=none; b=oOSwICFZH66eyCJEj9A6VrlF2VJNOXKrz+A9TRw2+hzsvbVzp6PhiM3yuAWo9VLqiet/Qovi4mbpWFGSetNWrWmMRGBrrxg4JJRzx+lK3e78aNZuZPX7zyPGO4mHwDx+Pkj26xFOJ+tid+h2xEYsvUG0jGnJHt7aTffXUPDQrxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999036; c=relaxed/simple; bh=l/exZGynhFniJ4IOReSaddSkbCSs3Th1uTqufpftfQQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=svq09Va0JDQylMYbRsXcWhx81MR2Zl6mH3jRvDjvfhe0/Aslouu+ON0Z7HxNqCGskqLHS8t+iUHV2fZrO5LJLCKvYfkhfccmeKi6V2WrkEKJYy6ii2XoILsDV3ZJBAH2znE+6BBSyGgMbNJdl5Ysaf6pzb0SKHIr7sqL3PJEL+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RaBrytJc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CIb7TJdQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RaBrytJc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CIb7TJdQ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599vD8f1868523 for ; Tue, 9 Jun 2026 09:57:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jWJT1a+F8ivTQleEWMwYup4EASygHT710sf+q+SVdxY=; b=RaBrytJcs9g+wY1B kZZ97LmO8KApbhI5jz+LhwtIguW5xr2a7MMmqWX7vKwakyrIQMMmf2ehgleFqfH3 rxHjkMYXGNGCDXu7IuXWoiIXD/LC2F2K0ujkXTbyp0VQvq9UGeDVLqZjanfiL+t2 n6TOEJlCGzeDzKysLv9kF5qt4TYZPR+Inbo1ziHEn56iGSJEtcshxBJ3umA96naz ndnelebxxz5d78djULzJrUNw851SVfQ2TcAVFi69We/L0CPtj7buUzmVolfMr8li 1yfLgFR7LMIZya7IuDNU9r7OVpXMkVAz+HrHd7MURpfv9eiTeCrT7OlImPL4Pp8j BRpzcQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epg3wg4ph-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:57:13 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5175bf22b2bso10089061cf.2 for ; Tue, 09 Jun 2026 02:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780999032; x=1781603832; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jWJT1a+F8ivTQleEWMwYup4EASygHT710sf+q+SVdxY=; b=CIb7TJdQKCksE7WbnlYK40pVytbq5FmFJ4By/hycRagxZJk4ghoedVRmQaa1ULGSJd JR/jUNYHogiQpy0kks9njvz892TdHT0sdluJliqvCfTuO5V4bOajvkdmQHB3ff1SMJL3 hlMli/nu+zI5Cwt4f56uLgtuWbV5g4p7cruCKsZi41hls/Jd5IiY7e8ZWLJYGAiCxTMu oAxeOcBKPW8nS6gfS5GGNAztKD0QX4pmatpJAKqeMWPFzi4O1CLhfllOkpXY8t3dCucE 5EAo54g2J/liuaKL/T2VrkqHhQBG9TNQ45dlFUKPwNPH+AmXf4K7PLLSXyo9HuWMhMU8 94QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780999032; x=1781603832; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jWJT1a+F8ivTQleEWMwYup4EASygHT710sf+q+SVdxY=; b=AO0+1565ep9YXe3LU7+Pzx7hAtpWv69F60xsXN4Ce2p3yKB+OBWg6cyQ6xPzYGxFyb f0rVWowlMpqhPNCLsEZW3Cpu5UuUW/wwtRzpu7oqLElw2Yok6m2UjCRXwO58Nb9Yxdz6 Tg24pFUAEuc/+GVyCnRdm+k4okjC0sG26lY/9J0KyAeaEym3QT2/vy4LGnAbAmM2Qaoi nY3hLV7YKYcctL7pm1gi7a7wTZ0e4+OXc/l4yAy7BnhigjpEMvatn9BxHg4i5yTr3CAB aTJ6lang69VAnwjGDdAbEmClrdg1VQAPMpzltdpzo/iNVGgNf0/6pkVkUQYZzATH0Lnb JVow== X-Forwarded-Encrypted: i=1; AFNElJ9Yhhsje+jI2lnuT1v+YJLbHIlWVYBtmYGW++//dXYC1SJB0Ch7oZoqBefErmKacXADDuO7wClgeEuA0PU=@vger.kernel.org X-Gm-Message-State: AOJu0YyVnfWUJDndlTv4YegP40+V2QAsAlpGh/OQZ/Knea4VathpneMK PQz0X6GW3S6eAwFlBWiviNgk1vfjIwRMBh+1zlJ+Xap1QI2Pv53709Fm1y7uzYWgpY0b86EPiP5 a9rDg82W2Xu8svzDJNK1+4Okm3kTzJdk5+51xFsA5TsaeZF8dHvcX+YxHPTsxVAtVHXQ= X-Gm-Gg: Acq92OHJYhWnKLCNSQaXApT4XvyvMWdwcK9bbM0NvBJpHgibtvYzj6vh9Sz4VGWlL0/ i9Mzs2p4LIZnkTi4jSZv6WC7LnN7jSAzCDoEFHsWFw/TiOle3S+cO10VJgQr7LAvBHWI1WgMZRc JHiRKKDiim+1XS1XvaENdqlo4FH/zCm8recmQboB2jMoc6xvxA1zArn8WSHY0/gw/ed9+7ryud2 y2Mq1TesqyvtmSF+CNvWcJahBdp5Ngn2789h9lcPwgWoOoALWq7BKrtWzymNVQfJ/Wxhm/jaCCl 4zHHJDEsTozeSzDDYVX9Y/z3u9ZSz6TWgyMKfN0Yv97zOsppoMQlHuF9qpl7SLugmqv3xrluDMc tl8qPAlKev8lu8ZiWA73AEdPE6fp75Sap3BIjgwExUBaEUc34mOUZVRya X-Received: by 2002:a05:622a:d:b0:50e:487a:bfef with SMTP id d75a77b69052e-51795a481e4mr171478271cf.2.1780999032532; Tue, 09 Jun 2026 02:57:12 -0700 (PDT) X-Received: by 2002:a05:622a:d:b0:50e:487a:bfef with SMTP id d75a77b69052e-51795a481e4mr171478091cf.2.1780999032144; Tue, 09 Jun 2026 02:57:12 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf054e051a5sm1019894766b.35.2026.06.09.02.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 02:57:11 -0700 (PDT) Message-ID: <3da8b668-1504-450e-bde2-b383d63090a8@oss.qualcomm.com> Date: Tue, 9 Jun 2026 11:57:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/13] dt-bindings: sound: Add Qualcomm QAIF binding To: Harendra Gautam , Srinivas Kandagatla Cc: Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260605103739.3557573-1-harendra.gautam@oss.qualcomm.com> <20260605103739.3557573-3-harendra.gautam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260605103739.3557573-3-harendra.gautam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5MiBTYWx0ZWRfXyO8GUW77Mxqq OSrDBChRzcdkfeo3k+s7BZnI/QqkIY6jTXXuxyDpAAdXrafmfiJJoKmHgkWGg3rpzdboI3E8rR7 8N+zLW8sBADZQQ0n1Qcig6R5y2jKR6HisOAg6e2LWXuIPSpH/SMWRB5Nenn3dgp6VQnCAD+cfbW BYzpkzY7ns6Jhn9Up0gRQa+y5HisCU3z9JJiegwr6ZyhpwC5Mj3i2AZMpSPA4AjaCQJCN8tN8t/ mKiWK8l+EWz0aeOQxsI2ugMcmhNPPmPli/f1JXx0r36KDn8QewUQz9EFpqoI6RcTR5bZys8XtzT 54TVkXR21wEMceL2E2pfgSfmP4HIyOC3f7EJC4zT9o/pxl03lA3SuP7JGMcsyWqCPJeBT7gegoD R4lkw8Iz1WucYO3pY6z0VKiYguqGrL2QNYFv1RsV0oSttCaeWTcy70maIxMjBYesOeVhGA3rlUw MASBQJx+8HwD2NclbPw== X-Authority-Analysis: v=2.4 cv=csWrVV4i c=1 sm=1 tr=0 ts=6a27e379 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=4Sww1aU327frn4sdWmQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: R1rqHN3EiEZhzSx4IgHUUXkcLt6phQfY X-Proofpoint-ORIG-GUID: R1rqHN3EiEZhzSx4IgHUUXkcLt6phQfY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090092 On 6/5/26 12:37 PM, Harendra Gautam wrote: > Add a Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI > controller used on the Shikra audio platform. > > QAIF moves PCM data between system memory and external serial audio > interfaces through the AIF path, and between memory and the internal Bolero > digital codec through the CIF path. The controller needs a binding so > platform Devicetree files can describe its MMIO region, DMA IOMMU stream, > clocks, interrupt, DAI cells and per-interface AIF configuration. > > Describe the single register region, one EE interrupt, the required GCC > LPASS and audio core clocks, the DMA IOMMU mapping, and 'aif-interface@N' > child nodes used for static PCM, TDM or MI2S configuration. > > Signed-off-by: Harendra Gautam > --- [...] > + clock-names: > + items: > + - const: lpass_config_clk > + - const: lpass_core_axim_clk > + - const: aud_dma_clk > + - const: aud_dma_mem_clk > + - const: bus_clk > + - const: aif_if0_ebit_clk > + - const: aif_if0_ibit_clk > + - const: aif_if1_ebit_clk > + - const: aif_if1_ibit_clk > + - const: aif_if2_ebit_clk > + - const: aif_if2_ibit_clk > + - const: aif_if3_ebit_clk > + - const: aif_if3_ibit_clk > + - const: ext_mclka_clk > + - const: ext_mclkb_clk Drop the _clk suffix, we already know they are clocks, as they are listed under the clocks property [...] > + qcom,qaif-aif-sync-mode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Sync mode. Use QAIF_AIF_SYNC_MODE_SHORT (0) for short (pulse) > + sync or QAIF_AIF_SYNC_MODE_LONG (1) for long (level) sync. > + qcom,qaif-aif-sync-src: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Sync source. Use QAIF_AIF_SYNC_SRC_SLAVE (0) for slave mode > + or QAIF_AIF_SYNC_SRC_MASTER (1) for master mode. Should these be boolean flags then? [...] > + #sound-dai-cells = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = ; > + status = "okay"; status is "okay" by default if unspecified Konrad