From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84744C48BE0 for ; Fri, 11 Jun 2021 11:51:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69B14613CC for ; Fri, 11 Jun 2021 11:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbhFKLxX (ORCPT ); Fri, 11 Jun 2021 07:53:23 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:36403 "EHLO mail-qv1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbhFKLxP (ORCPT ); Fri, 11 Jun 2021 07:53:15 -0400 Received: by mail-qv1-f51.google.com with SMTP id im10so15475938qvb.3 for ; Fri, 11 Jun 2021 04:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RM8SbiamRAqEYBQWvt1zz0QiLBzqVfHdHpmDx37QuwU=; b=fePXtwI12Iq05ePtlIj8shlIJHX4DaDQ32hB9cG3cca21aINFphdPqRiPJhrRM+oUB wN3V+w55rL0QhXLQ0bbels3X5vyE4iS5q0dMAxOUjUOuUrqqk2aTeq6okhBrzluXvaxe Hz8bq3LYstAAwip+vGEMF4C/eRe/CJFsf6ZHpAzFNL+vkzw7r7z9THIp8k6R28exgeWM 4HHMuSQi9fzSLxBgsC7HQizQPxXmPjqswVhAznvhC2pt5givvYX8XR1wfDukHEdBS+kP N0/b/dRySPVs/J+fAqEA56JSxrxzvXrx3rOL6d3p2f3DbuC6vHPXiZbrpB/dtvaL6JjH jSKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RM8SbiamRAqEYBQWvt1zz0QiLBzqVfHdHpmDx37QuwU=; b=AtFHag0CzhNzm/IIFTp42LnSoaK/sEZOdLlUmQhukYix/AODtxukc0owtF1fZXFZaL 2QxaSydAjyujo+8+5cHyu1WO8lsxz37olfCFWoBK5N6vxNHJFXvjhjkba2eyb+Mtnqx9 7dXJQIYdhDBK6Z//5/HwW5cWalx32nfGGRnCFX998TpnL1Jr14JDXepdIU2zlOzZFeZr pFqI/Y0CMcYJM/Nu2wzP6lzDVdAwWUbMZPdAG3FJa00B0n2BfR8BWqtlUcRDyhQOrAtM 80NMqLOMXXKwsUa5/vNofq3c+6eS/JYPYnSTgHVFVE4m4ZwI5Wm6Ckt54AIGpwjInJU6 O3Eg== X-Gm-Message-State: AOAM531eOQ8iEAQcGZFIWJSeBOZXCmu4PY0DBeEP5EdM4SAs1aTLLkPA cuGArZcpCmCVXyJD/8sYV4NMlMrG5Jw7mQ== X-Google-Smtp-Source: ABdhPJxzIcffT3qoG1eWyiesO8Mwm8yOIdHq4qcbltAq56GYtyGUnvyT4J2ipiPRhOVVLcc2VO3/DA== X-Received: by 2002:ad4:40cf:: with SMTP id x15mr4329423qvp.50.1623412203934; Fri, 11 Jun 2021 04:50:03 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id f5sm4052391qkm.124.2021.06.11.04.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 04:50:03 -0700 (PDT) Subject: Re: [PATCH] thermal/drivers/tsens: fix usage of unititialized value To: Yang Li , amitk@kernel.org Cc: agross@kernel.org, bjorn.andersson@linaro.org, rui.zhang@intel.com, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1623145299-109090-1-git-send-email-yang.lee@linux.alibaba.com> From: Thara Gopinath Message-ID: <3db50e86-911a-8b49-8c87-a33178754deb@linaro.org> Date: Fri, 11 Jun 2021 07:50:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1623145299-109090-1-git-send-email-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/21 5:41 AM, Yang Li wrote: > When "tsens_version(priv) > VER_0_1" is false, > "regmap_field_read(priv->rf[VER_MINOR], &ver_minor)" can't execute. > So, ver_minor has no initialization and assignment before it is > used, and we initialize it to 0. Hi Yang, Thanks for the patch. I have a few questions though. 1. Where do you see ver_minor being used uninitialized? AFAICT , ver_minor is used like below and will never be referenced if version <= VER_0_1 if (tsens_version(priv) > VER_1_X && ver_minor > 2) { 2. Do you know whether minor versions can be read or not on tsens ips with verions < 0_1? -- Warm Regards Thara (She/Her/Hers) > > Clean up smatch warning: > drivers/thermal/qcom/tsens.c:896 init_common() error: uninitialized > symbol 'ver_minor'. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/thermal/qcom/tsens.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 4c7ebd1..a36c43d 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -743,8 +743,8 @@ int __init init_common(struct tsens_priv *priv) > { > void __iomem *tm_base, *srot_base; > struct device *dev = priv->dev; > - u32 ver_minor; > struct resource *res; > + u32 ver_minor = 0; > u32 enabled; > int ret, i, j; > struct platform_device *op = of_find_device_by_node(priv->dev->of_node); >