mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hari Prasath G E <gehariprasath@ti.com>
To: Anshul Dalal <anshuld@ti.com>, Nishanth Menon <nm@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic
Date: Thu, 13 Aug 2026 23:14:06 +0530	[thread overview]
Message-ID: <3db98204-002c-4160-a055-d644c4559f33@ti.com> (raw)
In-Reply-To: <20260813-beagleplay_pmic_boot_phase_fix-v1-1-4518e7cba940@ti.com>

Hello Anshul,

On 8/13/2026 1:58 PM, Anshul Dalal wrote:
> The PMIC regulators for beagleplay are required for booting, therefore
> this patch moves the corresponding 'bootph-all' tag from the parent
> tps65219 node to all the regulator sub-nodes.
> 

Was there any issue with this platform that is triggering this change 
now ? I think we need a fixes tag here below.

> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> index c468b9c5fc09a..5f7265c426bbe 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -681,7 +681,6 @@ rtc: rtc@68 {
>   	};
>   
>   	tps65219: pmic@30 {
> -		bootph-all;

Wouldn't removing this from here prevent the driver from binding at all 
in that phase ? I am not sure if the child tag below would also imply to 
the parent node here, pls check once.

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/bootph.yaml

Moreover, k3-am62-pocketbeagle2.dts seems to use the same PMIC. Isn't 
the same change required for this platform ?

Regards,
Hari

>   		compatible = "ti,tps65219";
>   		reg = <0x30>;
>   		buck1-supply = <&vsys_5v0>;
> @@ -709,6 +708,7 @@ buck1_reg: buck1 {
>   				regulator-max-microvolt = <850000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			buck2_reg: buck2 {
> @@ -717,6 +717,7 @@ buck2_reg: buck2 {
>   				regulator-max-microvolt = <1800000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			buck3_reg: buck3 {
> @@ -725,6 +726,7 @@ buck3_reg: buck3 {
>   				regulator-max-microvolt = <1200000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			ldo1_reg: ldo1 {
> @@ -739,6 +741,7 @@ ldo1_reg: ldo1 {
>   				regulator-allow-bypass;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			ldo2_reg: ldo2 {
> @@ -747,6 +750,7 @@ ldo2_reg: ldo2 {
>   				regulator-max-microvolt = <850000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			ldo3_reg: ldo3 {
> @@ -755,6 +759,7 @@ ldo3_reg: ldo3 {
>   				regulator-max-microvolt = <1800000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   
>   			ldo4_reg: ldo4 {
> @@ -763,6 +768,7 @@ ldo4_reg: ldo4 {
>   				regulator-max-microvolt = <2500000>;
>   				regulator-boot-on;
>   				regulator-always-on;
> +				bootph-all;
>   			};
>   		};
>   	};
> 
> ---
> base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d
> change-id: 20260813-beagleplay_pmic_boot_phase_fix-c04b7f55de63
> 
> Best regards,
> --
> Anshul Dalal <anshuld@ti.com>
> 
> 


  reply	other threads:[~2026-08-13 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  8:28 Anshul Dalal
2026-08-13 17:44 ` Hari Prasath G E [this message]
2026-08-24  7:13   ` Anshul Dalal
2026-09-06 14:02     ` Kumar, Udit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3db98204-002c-4160-a055-d644c4559f33@ti.com \
    --to=gehariprasath@ti.com \
    --cc=anshuld@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®