From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBCDC4321E for ; Mon, 10 Sep 2018 09:55:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47C7B20855 for ; Mon, 10 Sep 2018 09:55:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="ShsfoSHh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47C7B20855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727966AbeIJOsk (ORCPT ); Mon, 10 Sep 2018 10:48:40 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:41516 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeIJOsk (ORCPT ); Mon, 10 Sep 2018 10:48:40 -0400 Received: by mail-ed1-f65.google.com with SMTP id f38-v6so15998906edd.8 for ; Mon, 10 Sep 2018 02:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=unYRDWjIMrkoqr4iNefiY8OtZceFXevztjbbjXtLjb0=; b=ShsfoSHhp77Rj7KZkQ+MXq0T5m2KzkVPbJEalMPeiFJ83UQ3uaYyz4jwvwcIbkL4WM Z9yqBwK2eo6kqjMLUMgbE/mj+qTCD94BL+UvFw3IMLTGLD9rSZsF2nbqeNkNDy59YCtX 07+1IO03qtKEm9D0Yhx//PCBoJl1pc4ludXl8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=unYRDWjIMrkoqr4iNefiY8OtZceFXevztjbbjXtLjb0=; b=ltiNKZugnEDiIog2PjdcG18A0YP5x9i7jMWpRu4lxKjxM5pkcM/+sPtsYVBgES09c/ P60LT1lFRZ5W4AK6ZMx6snxRX59I8D+GiXCatJoZ7olkz1GhAUQenOZkjjBwlgnR64ix z/Rw815PTj2sPOSGTd+nsVvBOPMiw92nu8i54w+oAzIQBLQfC2DlPox7j0SlMs/Z3xg4 UuKJE8FkbHU2oKjFzPZ/aH6BYnGBFpbybMygKMFKoNgSv1rheXMS67vmDB/tZOL81w0b Ls33h3vwwFfFtD3t32VxABNoqenzP5mt2+lYv7vleKZSE8pDfdfI4pyQDtI91WyePnxv 6W8A== X-Gm-Message-State: APzg51BXui12Q+/Voz9eiQyxC/8GwcYtuLaVM20XRmYcRPiSQzNyJzmn 4OuUkIPT8b+vfR01Eu5Xsu97Aw== X-Google-Smtp-Source: ANB0VdbqhPcQg4Bb5X9z1rB7XnMRfq4Acg2AVQJyKZ9tiqpcXf9896pxANaaQwQWtsVGnw9kz/cYmg== X-Received: by 2002:a50:8646:: with SMTP id 6-v6mr21777171edt.259.1536573324837; Mon, 10 Sep 2018 02:55:24 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id d56-v6sm8217584edb.7.2018.09.10.02.55.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Sep 2018 02:55:24 -0700 (PDT) Subject: Re: [PATCH v2 01/16] nvmem: remove unused APIs To: Bartosz Golaszewski Cc: "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Boris Brezillon , Andrew Lunn , Alban Bedel , Maxime Ripard , Chen-Yu Tsai , linux-doc , Linux Kernel Mailing List , Linux ARM , Bartosz Golaszewski References: <20180907100750.14564-1-brgl@bgdev.pl> <20180907100750.14564-2-brgl@bgdev.pl> <7e138142-8161-3646-4daf-619995baf395@linaro.org> From: Srinivas Kandagatla Message-ID: <3dbd65e5-c948-a784-0362-930fc41b840e@linaro.org> Date: Mon, 10 Sep 2018 10:55:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/18 09:43, Bartosz Golaszewski wrote: >>> this series. Later patches are MUCH cleaner thanks to this removal and >>> I believe it makes them easier for review. >> Am not sure about that, it definitely did not help me! >> > Why exactly? Aren't clean patches resulting from this removal easier > to read then if they'd also have to take into account the burden of > existing code that will be changes anyway later? I really don't see > why you insist on removing this. Here are few reasons: 1> TBH, This cleanup patch removes more than one feature from nvmem subsystem. Ex: it remove ability to add static cell from nvmem config, secondly it removed ability to read/write cells directly using nvmem_cell_info. 2> If you do changes as part of each patch, it will be much traceable on what is changed exactly and will allow much better review, and understand the reasoning. Having a clean start and writing code on top of it is alway nice, but we will definitely miss things in review in this particular instance. thanks, srini > > Best regards, > Bart >