mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: acme@kernel.org, mingo@redhat.com, eranian@google.com,
	kan.liang@intel.com, jolsa@kernel.org,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	yao.jin@intel.com
Subject: Re: [PATCH v2] perf/x86/intel/uncore: Provide alias for IIO free-running boxes on SKX
Date: Tue, 4 Sep 2018 15:45:12 +0800	[thread overview]
Message-ID: <3dbfc026-86c2-4523-f690-df45e4ed0643@linux.intel.com> (raw)
In-Reply-To: <20180904071349.GZ24124@hirez.programming.kicks-ass.net>



On 9/4/2018 3:13 PM, Peter Zijlstra wrote:
> On Tue, Sep 04, 2018 at 06:58:17PM +0800, Jin Yao wrote:
>> root@skx /sys/devices# ls | grep uncore_iio
>> uncore_iio_0
>> uncore_iio_1
>> uncore_iio_2
>> uncore_iio_3
>> uncore_iio_4
>> uncore_iio_5
>> uncore_iio_free_running_0
>> uncore_iio_free_running_1
>> uncore_iio_free_running_2
>> uncore_iio_free_running_3
>> uncore_iio_free_running_4
>> uncore_iio_free_running_5
> 
>> root@skx /sys/devices# ls | grep uncore_iio
>> uncore_iio_0
>> uncore_iio_1
>> uncore_iio_2
>> uncore_iio_3
>> uncore_iio_4
>> uncore_iio_5
>> uncore_iio_cbdma
>> uncore_iio_mcp0
>> uncore_iio_mcp1
>> uncore_iio_pcie0
>> uncore_iio_pcie1
>> uncore_iio_pcie2
> 
> I think I'm ok with that, except of course for people that have
> "free_running_#" in their scripts now and will to wtf when they upgrade
> their kernel.
> 
> Do we care about them?
> 

Yes, that may be a potential issue but maybe it's not since we really 
don't know if some people have used uncore_iio_free_running_# in their 
scripts or not.

I write this patch is because I always forget the meaning of 
uncore_iio_free_running_# so I have to go back to check the document 
"Intel Xeon Processor Scalable Memory Family Uncore Performance 
Monitoring" again and again to find the box definition. I guess other 
people may have similar trouble.

Maybe we wait some time to see more feedback from community?

Thanks
Jin Yao

  reply	other threads:[~2018-09-04  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 10:58 Jin Yao
2018-09-04  7:13 ` Peter Zijlstra
2018-09-04  7:45   ` Jin, Yao [this message]
2018-09-10  6:08     ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dbfc026-86c2-4523-f690-df45e4ed0643@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome