From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B5201DF748 for ; Sun, 22 Feb 2026 22:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771799207; cv=none; b=DfQi7HmduOIPrQOjU03TVLiVzmg6K33DK355rkUiivLHRZ/iL/qrADDrolOQIKj6VHiiaXTv+dYv21rnFFNy6xRAMeeFhd729s4/b1LoWQtE0PRrM+48d/g8vF3zxKqmjTWN7Szf3f22S/TEMbTrtTeBaDz5EZ25LzlVFHbCh74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771799207; c=relaxed/simple; bh=xhcvYszpM9QLlyAJ9YzoALnPzlRYvDwGrZ96RYVNowc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nDDu7iT5OvhBZMghlpfcXGldffh9hU9GsAz77Sah8RaOCs+X8//CwtHhLF4cNOI+hK4kPoZ3qyrlifKDnW2dSPBlAvu2NOZWSndzB/BSe/18tkFfAKPZlj2myAARGmYyA1XRFmtIhNKWISuFTXgv02/zcUtjRs5mRXH34eL42Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WTmM6jKg; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WTmM6jKg" Message-ID: <3dca0acb-2dea-4a65-a98e-8b40c878b076@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771799194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xvB44nvWYq1sT2ycvayIJfhrecfsGnFpNo++3uG80CY=; b=WTmM6jKgJy0SAGEdiAxRFmRFKvbY6oOx5YlYMBl6NTwdZhT1ML9yZT0Fo/3Zn9I8wERspr sh+921vlShReS8nze6sWEdLLsfbH4aVgcom61DZIVVGZAplKLL8Qfxu18KFyYZPTSpGr8W iRvGE9l8xCacenq+V2ijAHKrkQcuXNI= Date: Sun, 22 Feb 2026 23:26:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] platform/x86: asus-nb-wmi: add UX7602ZM DMI quirk To: =?UTF-8?Q?Pawe=C5=82_Hofman?= , corentin.chary@gmail.com, luke@ljones.dev, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20260222220526.285327-1-phofman@o2.pl> Content-Language: en-US, it-IT, en-US-large X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Denis Benato In-Reply-To: <20260222220526.285327-1-phofman@o2.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hello and than you for this. There a few things missing here: - a commit description for the why this was required - your signed-off-by tag On 2/22/26 23:05, Paweł Hofman wrote: > --- > drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c > index a38a65f5c550..19cd7ea13fef 100644 > --- a/drivers/platform/x86/asus-nb-wmi.c > +++ b/drivers/platform/x86/asus-nb-wmi.c > @@ -553,6 +553,15 @@ static const struct dmi_system_id asus_quirks[] = { > }, > .driver_data = &quirk_asus_z13, > }, > + { > + .callback = dmi_matched, > + .ident = "ASUS Zenbook UX7602ZM", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Zenbook UX7602ZM_UX7602ZM"), > + }, > + .driver_data = &quirk_asus_zenbook_duo_kbd, > + }, Please use tabs to align and ensure it is aligned with other entries. Also keep all quirk_asus_zenbook_duo_kdb entries together please. > {}, > }; >