From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB5D3E0080 for ; Thu, 4 Jun 2026 08:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561299; cv=none; b=q8aX/YM3OSjngR3W/my6Ae1tCS+RQHo4dDGOvTacwq7Kjad+DHSTcASNGSuKVnUd3ZPWhRKe+x7/YX7wn/P078Vi2V6TXQp1LN2VHsFHuyn7NpIKG23dXYDSDl1cpfDaS1OUROe/GO1TrASuLZsOdBeStDJyQA9eZZamYO2Iz8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561299; c=relaxed/simple; bh=lyLEVoSy7cPnWoRIV7vp/WX8YuoCgz/kRZmaoRluvWo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HKIqtPIbAUGh60XLJj8wT1d+68R1ANlJ1MQuvoFNyBrS1BSXe4bkUQcSu7nUYftZxQz5UWBR6MVjM/+sCVKwENpyQ4LVHNagdPuNaDvvarf+eTGYR0bVcNmO9a+/XcAlrjIInWYQPk/F9aY2Ei5KsgfzZSxznlnUztDJqGHacIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L94Y2lTo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jvWL7RcE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L94Y2lTo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jvWL7RcE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780561297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZcGJsSal8T9WZ+z65zYJjCayJlSk9Z139NGTW50LAo=; b=L94Y2lToiCSBUHxM7S9WIHylRe0091gssOVC8wR+IqR04/EsT39dYlhd6MN0+7CM5p1mVu cUMrrBevHPC37vrcqtqM1CbefZJwlMWiCiCmi8D1ni9MRx3YWw7ADj4OYy59rkVfTvggrS Fw2mSlZbj9azhlduHYe0LoVZeCvnStc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-ucykOXFZM_i1Chru2Dw37w-1; Thu, 04 Jun 2026 04:21:35 -0400 X-MC-Unique: ucykOXFZM_i1Chru2Dw37w-1 X-Mimecast-MFC-AGG-ID: ucykOXFZM_i1Chru2Dw37w_1780561294 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490b9318944so3076185e9.1 for ; Thu, 04 Jun 2026 01:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780561294; x=1781166094; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PZcGJsSal8T9WZ+z65zYJjCayJlSk9Z139NGTW50LAo=; b=jvWL7RcEriPW5qVy4EQR6lHkaWf5KtsOvEx3oq3oRtGGRFs8iwLMUfSim9kY2X8JbL tTqfpOO53ODwTXunCP2z4lyshNq4nw3fhOsA7ilaPg45S6eyvTadXF1nVgJAEI4euqyf 14qm33ya7hvTq2/uquE0WQurOwGGdm1CuPhANZnBAtScOTLSdKiN6PB8OXxV28h60z46 xbyBZeVEMjCKV3GGpbyod61YtzgRWgJf1A2EMsj1/VEtshJRTl+g7Twnx/d24yALgIp4 W3S27xuXdC6cOJqEx7xcoVs4nxqWzPdHrPRJHBgREUu+X2+p8Rcw1HU2gB+u1GJk6a21 2WjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780561294; x=1781166094; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PZcGJsSal8T9WZ+z65zYJjCayJlSk9Z139NGTW50LAo=; b=WuMg11/OGj4sQAiR2gaeKXIk4l2NmjHFOGaDMOn16vpR0GHOAlzI3dtfDwXPSFgeQ1 5PMkIlsm2nc+4u9lllDi0mmltACV3iWw09rFbsdING7l7DUVe/7WN9XqaMbhW0XGylqJ 5Z2XyPzarx70Lh+EdtAkzi4vS2vIf11mSPxz2Km/anWNWxXAZ4QdnGcWGG27Cf67cyCE 5sT44iKt3KA0szPNOF6S3yXVe1AKUojawp6KlqIPygnYzxL7Pbg8CBQhaskKrSQvxfEa NP/wjJEJUZdIKbKDFaD/S1J26tPrG+MY9+jzZdrpMOhZAnUQOddoqSSdM+Oaqcxg5RcL P9CA== X-Forwarded-Encrypted: i=1; AFNElJ9nFs5kTSfPRvw+O9I0CUbsJYViJQ3UnsExNsfVPoyaWWVcV8UshA5ZDir3fEvyefttoyMlv+2gMuFtxCM=@vger.kernel.org X-Gm-Message-State: AOJu0YwNwrnxxvVq2MNplJpsRVIuN4kRNZfYaFzw45D8CXYtbZjAsRol b1pOfzluU5OqQizVLXr4kjqeYxAyQ1/PMWexTVenh+KVjY4zXZK9YcRf9GcTG9//bYJeojas2SK rIdbsf9lsvqDIi3v3y8p/vILwX+GW9PUTneTRwViKRt7doMoqE4fN3GG2yHk0iC6yGg== X-Gm-Gg: Acq92OFUIKjWmOo22Xbe0Yc7naGflBm1+vudxTRH1JP0CLOz4SOiHXjf43fOtC89/Wl EeYQSyRMNQOlBbFbxIbSzgaIHta4ROcFMXPAf1UWj/mfFWmPKD2aqq+dYjegf6v/+blYtMRSKql ca83ALO1vjIb/aCx9zatXPeyNh2LzywkIyOliMHdC5YMy+fWqdSonoEhULFcNG4jywvdb6mha5K 21yj929EVXCd7VUN77J4cR/I+W6cImZPbrWn3fqkuKESMSVSaPlKkC2cBz0EseSlKf+43oV+xkR vMn5mhZaEezQJlzg6sGqWUGmgnXES9bCmAM42LCkYpGPxvR6XNB6Y9nw8RqT+NbnH6nyrhLTpXF ybB4pWs3ipZ3Vw4XuV+EE1KO6I+D8rIFHjoLszhvsc3hCyeFdi/p6JmYBeM7M1E6MByc= X-Received: by 2002:a05:600c:1f96:b0:490:53d3:47a9 with SMTP id 5b1f17b1804b1-490b5e7962dmr106047615e9.3.1780561294470; Thu, 04 Jun 2026 01:21:34 -0700 (PDT) X-Received: by 2002:a05:600c:1f96:b0:490:53d3:47a9 with SMTP id 5b1f17b1804b1-490b5e7962dmr106047165e9.3.1780561294130; Thu, 04 Jun 2026 01:21:34 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f34413csm14143945f8f.21.2026.06.04.01.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 01:21:33 -0700 (PDT) Message-ID: <3dd59d38-5d16-4632-ae4c-0416c70f5a17@redhat.com> Date: Thu, 4 Jun 2026 10:21:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 5/5] veth: time-based BQL completion coalescing via ethtool tx-usecs To: hawk@kernel.org, netdev@vger.kernel.org Cc: Simon Schippers , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20260527135418.1166665-1-hawk@kernel.org> <20260527135418.1166665-6-hawk@kernel.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260527135418.1166665-6-hawk@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/27/26 3:54 PM, hawk@kernel.org wrote: > +static int veth_set_coalesce(struct net_device *dev, > + struct ethtool_coalesce *ec, > + struct kernel_ethtool_coalesce *kernel_coal, > + struct netlink_ext_ack *extack) > +{ > + struct veth_priv *priv = netdev_priv(dev); > + > + priv->tx_coal_usecs = ec->tx_coalesce_usecs; Sashiko noted _ONCE() annotation are needed here and for lockless reader below. /P