From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB992D73B8 for ; Thu, 27 Nov 2025 16:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764261297; cv=none; b=D9nPZrjmo2Al0g+4FlsO63w6UtmV0ejV19lEThoX+VkHURwZoe0Cmio8zUInzfs1Qzc2y+v8HNiWWeXNURF4fuy+dsjq8Wp7frIO3x1dYWhjoitIh5EP4nKZBs2BLwrtL6lj2iP46St1BpXIMzlnj0oTl/uKtQ6rMfCL6uDaOlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764261297; c=relaxed/simple; bh=qbwQQeYnhh5Jp+VwwIUbFfb16SXJjHTfT04dLegf2aA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AienP/ZFA2zyuwQ2ASePDrOASLC3kWOFo7sk9Qi4Wc70+WqN4v5Lt8woajMFczZ2AduLI7zIutzbuPQdqFqR7z8NyFk87LxsV1NMCdQCYWaZFjkpQS2yZ082zeqpJuWZaQk6XDjFLn2WVHh/2JQNB8d5AdFkHlJc2X1Xl5cmPfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FbT4Kp5J; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N2C5DMv4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FbT4Kp5J"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N2C5DMv4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764261295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C4iwbs1h8WPfjtCWRn3LxmIB+8Vn4N4Td3zMk03YVIE=; b=FbT4Kp5JEh7tvFojDAoPB9nmDPJ3gbOF1FJLdq8DnXxdiTf+3rP3q532DziiX9deXqbztK 5hHrUZ9YXQXO9/UoPa7IUlVauTThZ+NNx3zjXE0ZLaJykrU3FvkaRlXq4ruIOKXPsp6mUV HQPkIEqRqcIhsdY6qGlk+SGNGRkwvPQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-_80pLK-bPd2bGcxpIrKmRA-1; Thu, 27 Nov 2025 11:34:53 -0500 X-MC-Unique: _80pLK-bPd2bGcxpIrKmRA-1 X-Mimecast-MFC-AGG-ID: _80pLK-bPd2bGcxpIrKmRA_1764261293 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-42b2ffe9335so687311f8f.1 for ; Thu, 27 Nov 2025 08:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764261293; x=1764866093; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C4iwbs1h8WPfjtCWRn3LxmIB+8Vn4N4Td3zMk03YVIE=; b=N2C5DMv49YAmipiVLj942vrUXgAqs8MW/pqT4xpbd2xp7SNzLOsxY5xE9E8ofIetrM FnKxyvQTqNbUKB7X4HDCj2i/QBomZ7bXVlYdX21Q6VWjI13LirRLYiY3Xcir1SiCkZ8U qTsI5oBcjc8k3Kd4piiaWHCiw+7bzTlvgpfc02gxn3WFmmqKWhA9wNVNzqos/gTzzpv7 sDKE4qh/4WQ9dXak5jbdLyD1MhGqNqzb1AEbE64sxOgF9Hl5JGaQr26bIgIXic9bHrR3 BNoiIgD8xLj7aep8mTK5byHIfcCZaQydHYr+BxFiX59iXqPvC3AcO9klq/JQgldDlkfC ySPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764261293; x=1764866093; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C4iwbs1h8WPfjtCWRn3LxmIB+8Vn4N4Td3zMk03YVIE=; b=ZXEs9HbFZQpNS3HwCektWqtgLVDSmUPRiFpe9da0N/E1sM0Xrtg/yPvUYd2WJ3SMXp JFMi60ifgnaJVLVamBpz30E+VArzZLsHMQYclev2X8+Ligo/pevNhK9BZD4ky2L47oXD J8Cb/VoTIBk90NtiW1a56G9PX3zeG1cTxkcP6605B06lSkOqi1ejhte1ZbXX9wak9HDE vdg3P0X7pyw7FEMpdR1AtpEMbT5VOF9+o1RpHPY9GTR/F9sH9NS5FZ8wPwUGbz3nQFGh tmsBZkegvjnAbmUVAcGXSsBevtC8uH5+h8evKbd9GV95mybhQvCjB22Uyy9tOA7Ketjy oTjQ== X-Forwarded-Encrypted: i=1; AJvYcCWp1bm/KvObsIGho7zXDff8g3Yq8ZIhVn6RNazS9eDipQc1lQWo7jyM5S3U1T/cA++s4VnlNVNboPk0AYM=@vger.kernel.org X-Gm-Message-State: AOJu0YzxJT/Qo9uJhdn2bRoiMGBBywoBfyTBypud2A9yVobO65MNkxTr mmrMaB3RVIpCopUTRCvSAd56azdxPrd+WUb6ftYWTg15yRmoWQ9pnaINmAy4ZDQigs/dd5G8Heh sthNuiMT10Pc+g+wcQh2u8BRR0mNlbNrBeiN3T3GuNJYOmPj1zXI+EPC/6/4XrBTnkg== X-Gm-Gg: ASbGncuZB+jZ0g+XNaJV7/+PPFfANezzoUBXXgI9Gv6Zxe5XbEEJ4L7io7lzJfn/0rm c6Hyb0nAboBeMB+a0zgfizbrgM/eR1ZrR7jSjt/z02etSt/ZvaTGEAuNyyS1IRenivWpPMrA4n/ TrHL9M5XituMRaZgKsa/LT9xRgAaffarxZla8XZjX5Tb0C4pi+i5RUyrAbWYi8mRarhl6ZTfnuG 0PH66hTRc5rgrkaKGHlJVzFNbTk0w231pa9UK70QGnaAQb327lC2XZkQpZH4kzGrX5nl8dL9iQT Xxr04UTKF0h1tIttmqI752Qy4xODo90xymb6I1w9c7LvP2KqgvTW3DMg4C6GpH6rqiB/G6MYTM6 eq/S3k5N+0GMYsQ== X-Received: by 2002:a5d:5e01:0:b0:42b:3131:5435 with SMTP id ffacd0b85a97d-42cc1ac9de0mr25419562f8f.2.1764261292590; Thu, 27 Nov 2025 08:34:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBjcdBlqLKajPU/sQcGkGD00QWIR2/Z2jTb31o5tzKYhK4fsXo5kSSU+5/YPOKYslbkKRh+g== X-Received: by 2002:a5d:5e01:0:b0:42b:3131:5435 with SMTP id ffacd0b85a97d-42cc1ac9de0mr25419529f8f.2.1764261292099; Thu, 27 Nov 2025 08:34:52 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.212]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c3c8csm5641761f8f.2.2025.11.27.08.34.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 08:34:51 -0800 (PST) Message-ID: <3dd5c950-e3e4-42b8-a40b-f0ee04feb563@redhat.com> Date: Thu, 27 Nov 2025 17:34:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: define IPPROTO_SMBDIRECT and SOL_SMBDIRECT constants To: Stefan Metzmacher , netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , Steve French , Tom Talpey , Long Li , Namjae Jeon , Xin Long , linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-rdma@vger.kernel.org References: <20251126111407.1786854-1-metze@samba.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251126111407.1786854-1-metze@samba.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/26/25 12:14 PM, Stefan Metzmacher wrote: > In order to avoid conflicts with the addition of IPPROTO_QUIC, > the patch is based on netdev-next/main + the patch adding > IPPROTO_QUIC and SOL_QUIC [2]. > > [2] > https://lore.kernel.org/quic/0cb58f6fcf35ac988660e42704dae9960744a0a7.1763994509.git.lucien.xin@gmail.com/T/#u > > As the numbers of IPPROTO_QUIC and SOL_QUIC are already used > in various userspace applications it would be good to have > this merged to netdev-next/main even if the actual > implementation is still waiting for review. Let me start from here... Why exactly? such applications will not work (or at least will not use IPPROTO_QUIC) without the actual protocol implementation. Build time issues are much more easily solved with the usual: #ifndef IPPROTO_* #define IPPROTO_ #endif that the application code should still carry for a bit of time (until all the build hosts kernel headers are updated). The above considerations also apply to this patch. What is the net benefit? Why something like the above preprocessor's macros are not enough? We need at least to see the paired implementation to accept this patch, and I personally think it would be better to let the IPPROTO definition and the actual implementation land together. Cheers, Paolo