mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086
Date: Mon, 17 Jul 2017 11:28:55 +0200	[thread overview]
Message-ID: <3dd9281f07c0d216434cb158d11d3ccf58bf0802.1500283733.git.michal.simek@xilinx.com> (raw)

MTF_CORE should be enabled when driver is enabled.

Without this patch you can configure:
CONFIG_MFD_CORE is not set
CONFIG_MFD_TPS65086=y

which ends up with compilation error:
drivers/mfd/tps65086.o: In function `tps65086_probe':
drivers/mfd/tps65086.c:110: undefined reference to
`mfd_add_devices'
drivers/mfd/tps65086.c:110:(.text+0x128): relocation
truncated to fit: R_AARCH64_CALL26 against undefined symbol
`mfd_add_devices'

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- Update commit message based on discussion with Lee Jones

 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 94ad2c1c3d90..f98b5a6d4da8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1294,6 +1294,7 @@ config TPS6507X
 
 config MFD_TPS65086
 	tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
+	select MFD_CORE
 	select REGMAP
 	select REGMAP_IRQ
 	select REGMAP_I2C
-- 
1.9.1

             reply	other threads:[~2017-07-17  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  9:28 Michal Simek [this message]
2017-07-18  9:08 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dd9281f07c0d216434cb158d11d3ccf58bf0802.1500283733.git.michal.simek@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®