From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570D7C433E0 for ; Tue, 4 Aug 2020 00:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 614E5206DA for ; Tue, 4 Aug 2020 00:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgHDA4k (ORCPT ); Mon, 3 Aug 2020 20:56:40 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8752 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727858AbgHDA4j (ORCPT ); Mon, 3 Aug 2020 20:56:39 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 5F284BA27CE62047C1C4; Tue, 4 Aug 2020 08:56:37 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 4 Aug 2020 08:56:34 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: make file immutable even if releasing zero compression block To: Daeho Jeong , , , CC: Daeho Jeong References: <20200730050928.356916-1-daeho43@gmail.com> From: Chao Yu Message-ID: <3dd96915-51f1-e8ab-ad2d-29bfda68a635@huawei.com> Date: Tue, 4 Aug 2020 08:56:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200730050928.356916-1-daeho43@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/30 13:09, Daeho Jeong wrote: > From: Daeho Jeong > > When we use F2FS_IOC_RELEASE_COMPRESS_BLOCKS ioctl, if we can't find > any compressed blocks in the file even with large file size, the > ioctl just ends up without changing the file's status as immutable. > It makes the user, who expects that the file is immutable when it > returns successfully, confused. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks,