From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45975249EB for ; Mon, 2 Dec 2024 18:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.17.235.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733163463; cv=none; b=HtdTG2qwaKgfUJ2lETBFQ7PWdVs+iKYEWc5Zhirnfj/ztNBFV6GZCTAGZIIrcLtHXy66SaRiWeUenukESJ9IXl1RejegQ+Tn0Li3qp5PReH15ypAtwVXDXj7s7zwuA8PoXst6Umb7vPr0tEm2avHJrNkegIDG+EAXpwrqfjOqAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733163463; c=relaxed/simple; bh=TTvpczeCHRtlH2/Kgm9ZxuNZhaiSYJxu1FqpQf9stP4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JCpWuec/Bk/uDAz6HnkzIGt11+e16ho+hCjo16KnxeO0f2X9wTByFeKgCrWnI/24cuDOiirl9cogAaePuCTuJfqMA5sCZkPbPG7XR+rVCUBDfj/ymmBKkxZywXLacHiuFsX6G7oXB6YE20ofRSGVioucIlskJv3zdLrSikm1DR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu; spf=pass smtp.mailfrom=csgroup.eu; arc=none smtp.client-ip=93.17.235.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Y2BpT6ncGz9sPd; Mon, 2 Dec 2024 19:17:37 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RJGLH475UjM9; Mon, 2 Dec 2024 19:17:37 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Y2BpT5m4tz9rvV; Mon, 2 Dec 2024 19:17:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 9FDB48B765; Mon, 2 Dec 2024 19:17:37 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Q_hUgq0oLnxX; Mon, 2 Dec 2024 19:17:37 +0100 (CET) Received: from [192.168.232.97] (unknown [192.168.232.97]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 222188B763; Mon, 2 Dec 2024 19:17:37 +0100 (CET) Message-ID: <3de6bf25-fb3c-49a9-b06b-5e2e527ec90c@csgroup.eu> Date: Mon, 2 Dec 2024 19:17:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] powerpc: copy preempt.h into arch/include/asm To: Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org Cc: npiggin@gmail.com, maddy@linux.ibm.com, bigeasy@linutronix.de, ankur.a.arora@oracle.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, vschneid@redhat.com, peterz@infradead.org, Michael Ellerman References: <20241125042212.1522315-1-sshegde@linux.ibm.com> <20241125042212.1522315-2-sshegde@linux.ibm.com> <026ad776-a889-4213-8e0e-1da9065dc5ef@linux.ibm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <026ad776-a889-4213-8e0e-1da9065dc5ef@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 02/12/2024 à 15:05, Shrikanth Hegde a écrit : > > > On 11/27/24 12:07, Christophe Leroy wrote: >> >> >> Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : >>> PowerPC uses asm-generic preempt definitions as of now. >>> Copy that into arch/asm so that arch specific changes can be done. >>> This would help the next patch for enabling dynamic preemption. >> > > The reason I want the content instead was to allow future patches where > I thought of making preempt count per paca for ppc64 atleast. generic > code assumes it is per thread. If this change is to be done at that > point, that is fair too. I am okay with it. I think it is better to keep series minimal and consistent. If you have a futur plan, no problem, keep it future and do everything at once unless it is heavy and better done in two steps. As we say in French, a lot of water will have flowed under the bridge by then. I'm sure there will be a lot of discussion when you do that and maybe at the end you will end up with something completely different than what you have in mind at the moment. > > >> Instead of copying all the content of asm-generic version, can you >> just create a receptacle for your new macros, that will include asm- >> generic/ preempt.h ? >> >> Look at arch/powerpc/include/asm/percpu.h for exemple. >> > > You mean something like below right? > > > #ifndef __ASM_POWERPC_PREEMPT_H > #define __ASM_POWERPC_PREEMPT_H > > #include > > #if defined(CONFIG_PREEMPT_DYNAMIC) && > defined(CONFIG_HAVE_PREEMPT_DYNAMIC_KEY) > DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > #endif > > #endif /* __ASM_POWERPC_PREEMPT_H */ Yes exactly.