From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DB32749D9 for ; Tue, 10 Feb 2026 13:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770731152; cv=none; b=N0mv8IsxVUZzW9Sk8QNIWK9mf/efsreanrGosXSgIsFwyS+HyRhoBxivqh8dLtvIQy3BdxRHEftKySMOEoVVzSRkPgvwVJfUWEvIDKBL0mp61VTTcS3VM825TI+0QKv7vJ/Utw0L61m2Ckyb48wZJKg8DbCX8U6En7oLW6lAiDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770731152; c=relaxed/simple; bh=LFfNuASI3M4ZdLNRiyjGm28OdZZb/0qgcsrmCPDGEnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VHP4W7mU5y/zE5QtrAwdVbaC7/s6gMrgkbyaFqDqztjYsxMNUB1tiXmnGa4szSohAmhkqW7h7W4TceD5cTiayR3UIjBHRuhbzOQy/vVRTqU+2fL7l7lalJGodXrqhACm4oSQi7a9QNWLXfYUX6efWOXiWHGH8vWDQjpah6KWpZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YD14sGCZ; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YD14sGCZ" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-382fb275271so41463461fa.0 for ; Tue, 10 Feb 2026 05:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770731149; x=1771335949; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MqGFCgjdz+m6pCARw4RzgeZOPwXzAMTXBB6oFzK0ogE=; b=YD14sGCZGVu42MMimn4W7M1MyTNK8FPNtiU+rfkNWV4HttjK40yUHuDjaMmF4PBdbA 3Ls3ssAjrf57Om0BODdM39wzsjuQr5CiyLYt+mSNPQkXgErMJzdEnvCaESudLjnsb2fP J74xfuWVqs3QDsk2st9MA7uGplvT7h/AxwkCXJjJL4qNGGpxPXC1Y6VLJZTs4ULC3Tiu nWFIcQt6M89YJXc0FMgoSkwilP+Jl2cGGZXGh2H7mGfrxiWfQhxqN9po+F3dbIH1dfb6 9Xzk0qgASe6ThwXQbQFprFxJwnCpwyV62SRzZj+RNNIoABt1dW83+MgWxT6cSsp2onPy iyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770731149; x=1771335949; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MqGFCgjdz+m6pCARw4RzgeZOPwXzAMTXBB6oFzK0ogE=; b=Sp1rUr+2rke1uMM09hiisVg1IPU/XedLBEFzB3UCTHA+8AW/nyImk/qfBgqSjJOBKA gYBUng+eostgPx6VvWag0RUp+6HYszycce96u+oIHuuqtr42Uu5QblDUb2Oip4hGeDL6 2R0TVPz5YT8fVkm9ZLvoBY+XeF5KfG4wOIfE8OwBUgJgZl3M6hQnyKe7hzR9w01oKydj bCDiQaPi2EZc1aX2l6PJq2SmJTCVdnmgvq/O3XoOMSZ9AGeWYWfNnqIMNb9TktJ75f+L wt3buVpwFnPGBsAM7QvaWQ1IVU5RTxeOiXA0+tw1kF3g0GPOgkSY/FNP2w08G7oMU4/V J6Ag== X-Forwarded-Encrypted: i=1; AJvYcCWEdEyJEkKUpwS8+iTQm8fOXy/X3FX7it/lwdLfpqsa/X73/gD4E4ts8y4boQBDTuSZ6/40/kLFans9Ysc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy03MjmPRyO5kpRbEyQGQV138pRfA1cf2rtPfwwMQ+hXdtHN1Hk /Qs++9kA7wQI18MrLSjxqL8/mDiXQSEd7SdWveniQ+/Uo7THZxbC+YKu X-Gm-Gg: AZuq6aKWykBEgv6b2+92jZWbFCo4NDgnL49Jtd8r9+ccDqZjmVMcQfic07jbxgINN+Q LZKD0vE9KcswFin8eXaZkbKcIDobIE6cqI/qot4DckwoZc9KiHugBnlx/NM99zs388UmedXf5ap eV3KzRJGzX7hLbKK7Ex4NSulsFGsV49DkxuChO6PEAS8RTxSlD5NTV+5z/DNvdz14FYz26xQocB MouGLYJ6EEhCWRNIoKj/FIwXmE4T2/eannMDTdH5dFPiQ9i7LVgHryeIHd9CiEC4FVJMOU9dNfW H71iyMb/TcG4eUCe1ghcJsBlLYT/Rp1HyCZc+rUoRDgBpKaveXE9vWUSzWMp/uXWBqpNEacAvFY 9GJqVgwILmv8HhBYgHjf/EHIJPVtYtnj64GwtSvvc4moxan/vTaVXTAtKclnwl/THUbexRUW4gP 5kM7K8WlaimTkZoZYLCniiAMkc5yXN1nQ+beWIPrQGhNTrNpF36B7PYRa/vtnkzJBx8/kQvsQct gjLCbO4yg== X-Received: by 2002:a05:6512:3044:b0:59d:f473:aa8e with SMTP id 2adb3069b0e04-59e451582cfmr5279851e87.27.1770731148826; Tue, 10 Feb 2026 05:45:48 -0800 (PST) Received: from ?IPV6:2a00:1fa0:4341:e63c:56b3:c9fb:1b7e:5017? ([2a00:1fa0:4341:e63c:56b3:c9fb:1b7e:5017]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-386b63b0540sm35527341fa.23.2026.02.10.05.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 05:45:47 -0800 (PST) Message-ID: <3de6c9bd-35c5-45c5-874b-75c6623bd4ad@gmail.com> Date: Tue, 10 Feb 2026 16:45:45 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: isp1760: Add missing error check for platform_get_resource() To: Chen Ni , rui.silva@linaro.org, gregkh@linuxfoundation.org, laurent.pinchart@ideasonboard.com, balbi@ti.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260210090202.2332349-1-nichen@iscas.ac.cn> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260210090202.2332349-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/10/26 12:02 PM, Chen Ni wrote: > Check the return value of platform_get_resource() to prevent potential > NULL pointer dereference when the memory resource is unavailable. > > Fixes: 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") > Signed-off-by: Chen Ni > --- > drivers/usb/isp1760/isp1760-if.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/isp1760/isp1760-if.c b/drivers/usb/isp1760/isp1760-if.c > index a64190addba6..60f81ec81373 100644 > --- a/drivers/usb/isp1760/isp1760-if.c > +++ b/drivers/usb/isp1760/isp1760-if.c > @@ -196,6 +196,8 @@ static int isp1760_plat_probe(struct platform_device *pdev) > int ret; > > mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!mem_res) > + return -EINVAL; Isn't it already checked in __devm_ioremap_resource(), called later on? [...] MBR, Sergey