From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BC527702D for ; Wed, 22 Oct 2025 20:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761165264; cv=none; b=IL4c/MB//T7BFZjEuo5zMSK2Pu3dY2oelNv7yYqEZhFVWXCDPKa1x41l3CVGJF4WuAOgpJ41l0CUjknRCRv1SGF4tkLG57MJXogP0hNnHttDjVZqYCZbHa0IUCG5d/1mG4s+5gAU3V4WBrXHfpfFVz4lWojjA3zsZYD5XskStGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761165264; c=relaxed/simple; bh=U/vDlQHXlM7yc6N12nvzWfUUTKAdNQyEHv1avd2LZJM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HGAg8488kZnIMfwrzwa+FcI6sEn0Z8wMFXrAdXDDFLV/cL53Zj1so36SDIIRJtredxtmUbUtokF4PFOvq7RawkPToNw8K6PTDjHpMGO/WWWC6l76y0tYYV+IidfIdKvoZBOySxj0NjWXIii7ap6CPx3mbSKQxmRdCrmE5YPNn+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G3OXD6dL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G3OXD6dL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761165261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MCpIcRCuoZ+NFrE8wED3wBMc5noEyqWsY1apOXEuFwM=; b=G3OXD6dL9NUltJHVqrWAZc9WJYR+YbZTt9+6VoIE6r9Ey66AKLWCe8ALxIIMJU3ZxI6pl0 yGcjkeVsA8y13SNYawOZKAGyn+H3AWf6w2iB/moAphxunTw5Ebq421N0S6R5T5w8nV57+Q ZxOuN0RY0OAO4k82jGrWlFIjZd1y42Q= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-sLHp4ZWxM12Qp1bIRUhBaw-1; Wed, 22 Oct 2025 16:34:20 -0400 X-MC-Unique: sLHp4ZWxM12Qp1bIRUhBaw-1 X-Mimecast-MFC-AGG-ID: sLHp4ZWxM12Qp1bIRUhBaw_1761165258 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4278c82dce6so25327f8f.3 for ; Wed, 22 Oct 2025 13:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761165258; x=1761770058; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MCpIcRCuoZ+NFrE8wED3wBMc5noEyqWsY1apOXEuFwM=; b=XyBHQW5hJLUTWoF39lsD9QlunUlpXl0pwwC56uVSjKtun13NN+VZ/gIcWOkAYrebci Dzf+o3Gv8HtTTVOSndKUV8jJwfdJAOmnUZXaVABQKSd9Gg7cYXngB0DfvC/51kEA1vHV EV73eQ1V/qz+ej/rADgD0mc7ftHDNKW7B2jumHTHTRjDop/mJqcbiCpGt3nXk4WoWpcB 73hVeleBOSjFWcOtAgx50KvbhT2FGPe1+lV3bZT54frU5YwvMS4ZC86qRpaENUcm1KgQ cTo6ODTmP2FeP737+YS28qGjsT3/q92SnbwzkKkXRaBTK67K0bWk/p7lyGyOfsjoNsXX ao5Q== X-Forwarded-Encrypted: i=1; AJvYcCV356o0ygs77ucdW4nfxofWGa8W7ZaWj1ufFVPTKlQ4It26M0KjMlvNHD1PEgKh47/OyJY4m55kUSePETE=@vger.kernel.org X-Gm-Message-State: AOJu0YxVZrd5+QGgO3qeDvC+h5BgezYdEo+DIZ1QraOZjYWJBbtr6IAV Ar+VZwNKIOpdG1bP13hPHldX2P/qudWGwLkvr2mFTe1J8eBQzbMAUmG/Avb14R+2R9SJC43tJ4c KSbMvpYMHUyFhDo9z9UIDmF1tdl5MYV4tuJYTF3nUstKyH0N+wfuyBjgRmO5Ef+IPog== X-Gm-Gg: ASbGnct+mlWwsG0BuGGVl0q9X8Cm0TYwv+uprDcEeUVFXkzFqkqLePyAmDgFeInM+Zn 0k2M2g4LiUDM1Ri70+QqXULb6vB8v4XKFadX0NPOmT3tBKmBwFVHDbcDk4EeOQN/yvkzwBDusBq KMIv3Apxe+kKdnCZWEIQ93Nz7ESka0cg5RbKtjz2HGAkIJ553a7psjUEZKlsqUFE6cED0Vgk3QD No2cFHPmz8zabAYZLAn3xC1YwHj5l4uSrXooAWNO+dUVy/tzgwh5W1P+ZZJZIxsbzvIFEmTIk05 77n7PPmeE6FtddVHs1N7naQ9UBezgODJcXWugLEC/29aJ3eqVlfFaG+gSOz7uwFVgpuC41nguRs 1xdBWzdLdXi492ijlHovnFlRDoR4qJDKrrPQH/5blR+VedERlMe1E1CWyWgIuvBUodns0w8vkB1 Uo4ArEVn4Dgn0vN4IT6WKHwkYBAmk= X-Received: by 2002:a5d:59af:0:b0:427:60d:c50d with SMTP id ffacd0b85a97d-427060dc758mr14291322f8f.51.1761165258044; Wed, 22 Oct 2025 13:34:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiFp/PzvHA2ojeVgZuHJ7PIytIU8hDkikqIVC3bIAAJDppHWer8LxxL625PQtTJr0DIUqs+g== X-Received: by 2002:a5d:59af:0:b0:427:60d:c50d with SMTP id ffacd0b85a97d-427060dc758mr14291305f8f.51.1761165257634; Wed, 22 Oct 2025 13:34:17 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429897e75absm322783f8f.7.2025.10.22.13.34.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 13:34:16 -0700 (PDT) Message-ID: <3dfb5722-f81f-4712-af9a-9ea074fb792d@redhat.com> Date: Wed, 22 Oct 2025 22:34:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] mm/huge_memory: preserve PG_has_hwpoisoned if a folio is split to >0 order To: Zi Yan Cc: linmiaohe@huawei.com, jane.chu@oracle.com, kernel@pankajraghav.com, akpm@linux-foundation.org, mcgrof@kernel.org, nao.horiguchi@gmail.com, Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , "Matthew Wilcox (Oracle)" , Wei Yang , Yang Shi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20251022033531.389351-1-ziy@nvidia.com> <20251022033531.389351-2-ziy@nvidia.com> <5BB612B6-3A9C-4CC4-AAAC-107E4DC6670E@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <5BB612B6-3A9C-4CC4-AAAC-107E4DC6670E@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.10.25 22:27, Zi Yan wrote: > On 22 Oct 2025, at 16:09, David Hildenbrand wrote: > >> On 22.10.25 05:35, Zi Yan wrote: >>> folio split clears PG_has_hwpoisoned, but the flag should be preserved in >>> after-split folios containing pages with PG_hwpoisoned flag if the folio is >>> split to >0 order folios. Scan all pages in a to-be-split folio to >>> determine which after-split folios need the flag. >>> >>> An alternatives is to change PG_has_hwpoisoned to PG_maybe_hwpoisoned to >>> avoid the scan and set it on all after-split folios, but resulting false >>> positive has undesirable negative impact. To remove false positive, caller >>> of folio_test_has_hwpoisoned() and folio_contain_hwpoisoned_page() needs to >>> do the scan. That might be causing a hassle for current and future callers >>> and more costly than doing the scan in the split code. More details are >>> discussed in [1]. >>> >>> It is OK that current implementation does not do this, because memory >>> failure code always tries to split to order-0 folios and if a folio cannot >>> be split to order-0, memory failure code either gives warnings or the split >>> is not performed. >>> >> >> We're losing PG_has_hwpoisoned for large folios, so likely this should be >> a stable fix for splitting anything to an order > 0 ? > > I was the borderline on this, because: > > 1. before the hotfix, which prevents silently bumping target split order, > memory failure would give a warning when a folio is split to >0 order > folios. The warning is masking this issue. > 2. after the hotfix, folios with PG_has_hwpoisoned will not be split > to >0 order folios since memory failure always wants to split a folio > to order 0 and a folio containing LBS folios will not be split, thus > without losing PG_has_hwpoisoned. > I was rather wondering about something like a) memory failure wants to split to some order (order-0?) but fails the split (e.g., raised reference). hwpoison is set. b) Later, something else (truncation?) wants to split to order > 0 and loses the hwpoison bit. Would that be possible? > > I will add > Fixes: c010d47f107f ("mm: thp: split huge page to any lower order pages") > and cc stable in the next version. That would be better I think. But then you have to pull this patch out as well from this series, gah :) -- Cheers David / dhildenb