From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21AAC43219 for ; Fri, 4 Nov 2022 05:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbiKDF6N (ORCPT ); Fri, 4 Nov 2022 01:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231721AbiKDF5q (ORCPT ); Fri, 4 Nov 2022 01:57:46 -0400 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D70C5FA2; Thu, 3 Nov 2022 22:57:42 -0700 (PDT) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 04 Nov 2022 14:57:41 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 4696E2059027; Fri, 4 Nov 2022 14:57:41 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 4 Nov 2022 14:57:41 +0900 Received: from [10.212.159.130] (unknown [10.212.159.130]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 75251B62A4; Fri, 4 Nov 2022 14:57:40 +0900 (JST) Subject: Re: [PATCH 4/4] arm64: dts: uniphier: Add NX1 SoC and boards support To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , Masami Hiramatsu Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221027045157.23325-1-hayashi.kunihiko@socionext.com> <20221027045157.23325-5-hayashi.kunihiko@socionext.com> <54206dca-0583-88c0-9924-a80dfaf0ba94@socionext.com> From: Kunihiko Hayashi Message-ID: <3e0a7894-677d-33fc-6b3c-a7561e18a93b@socionext.com> Date: Fri, 4 Nov 2022 14:57:40 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/03 1:48, Krzysztof Kozlowski wrote: > On 01/11/2022 05:02, Kunihiko Hayashi wrote: >> Hi Krzysztof, >> > > >>>> + compatible = "socionext,uniphier-nx1-clock"; >>>> + #clock-cells = <1>; >>>> + }; >>>> + >>>> + sys_rst: reset { >>> >>> reset-controller >>> >>>> + compatible = "socionext,uniphier-nx1-reset"; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> + watchdog { >>>> + compatible = "socionext,uniphier-wdt"; >>>> + }; >>>> + >>>> + pvtctl: thermal-sensor { >>>> + compatible = "socionext,uniphier-nx1-thermal"; >>>> + interrupts = ; >>>> + #thermal-sensor-cells = <0>; >>>> + socionext,tmod-calibration = <0x0f22 0x68ee>; >>>> + }; >>>> + }; >>>> + >>>> + spi0: spi@14006000 { >>>> + compatible = "socionext,uniphier-scssi"; >>>> + status = "disabled"; >>>> + reg = <0x14006000 0x100>; >>> >>> Reg is second property. Status goes last. The same in other nodes. >> >> Hmm, I've put "status" here according to the existing (uniphier's) DT >> policy >> and this should rewrite the policy. Is there documentation somewhere that >> recommends the order? Or, should I refer to previous comments? > > Hm, your decision (as arch maintainer) is then preferred, not mine. > Although it is quite unusual to find status, not reg, as the second > property. Okay, however, if there are no examples where the second is "status", I think it is better to follow the many descriptions for new additions. > compatible followed by reg is not documented anywhere, it's just the > most used style. And actually most sensible as it answers to questions > from highest importance to lowest: > 1. What is this device? compatible > 2. Where is it? Does it match unit address? reg > 3. all other properties > 4. Is it off or on? status as optional property I think it is reasonable to arrange the properties in order of importance. I'll put "reg" second in this addition in the next. Thank you, --- Best Regards Kunihiko Hayashi