From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: humidity: add ENS21x sensor family
Date: Wed, 10 Jul 2024 14:54:31 +0200 [thread overview]
Message-ID: <3e0d6c4b-bbf8-4f4a-897c-fdaa101dd380@kernel.org> (raw)
In-Reply-To: <20240710-ens21x-v2-1-a37c22018b0c@thegoodpenguin.co.uk>
On 10/07/2024 14:48, Joshua Felmeden wrote:
> Add device tree documentation for ENS21x family of temperature and
> humidity sensors
>
> Signed-off-by: Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk>
> ---
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-10 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 12:48 [PATCH v2 0/2] iio: humidity: Add support for en21x " Joshua Felmeden
2024-07-10 12:48 ` [PATCH v2 1/2] dt-bindings: iio: humidity: add ENS21x " Joshua Felmeden
2024-07-10 12:54 ` Krzysztof Kozlowski [this message]
2024-07-10 12:48 ` [PATCH v2 2/2] iio: humidity: Add support for ENS21x Joshua Felmeden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0d6c4b-bbf8-4f4a-897c-fdaa101dd380@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jfelmeden@thegoodpenguin.co.uk \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®