From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A67AC04EB8 for ; Sun, 2 Dec 2018 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C50AA2081C for ; Sun, 2 Dec 2018 12:25:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C50AA2081C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725841AbeLBMZg (ORCPT ); Sun, 2 Dec 2018 07:25:36 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:33634 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbeLBMZg (ORCPT ); Sun, 2 Dec 2018 07:25:36 -0500 Received: by mail-wm1-f67.google.com with SMTP id r24so4927589wmh.0 for ; Sun, 02 Dec 2018 04:25:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z/rcIo0VlNcTpCi1nNOj3vKciFxUK8im07qbOJ3nXHU=; b=YvZCzA8BCHoLS8voz4a5hWC+PvKXst5UJ+cU+EXUoGsG4PyCs++GM7XyOQm03XEIih CejhutsTQEfQ8CanYWEQUUTBdUBpumg6JhQhFjvtLMfTMi4G5yv/1jYLbE+Xc+wb3bv6 v5UbumPOjcXVvENdwN2NUfmIzVuAqvkdmlnUU2bXbjtv9fZYHiIVtFBbVrDylgBMHFTr txzkjxEHop7yfXhmCW9oNkFcMPH/9g5bUy3/WXxuuLlZmQum8p/rMvUeLC9U8C3igPVI Y52X1bn4BsqEPh5qs3zX+WbSEk0nBj2tvmmoYxFUWB8BXB3UDq7KHY7UFlkc8ye6Lq7Y mBfQ== X-Gm-Message-State: AA+aEWavx5rGWLLpX7fwF9JF8yE/uvxB4Iuw0aoK6zNoFePFBE4r/PB0 vbkC56+FmW2+morAImdvtQ/7bUKmXz0= X-Google-Smtp-Source: AFSGD/UpJdUYlOLypz1bInuRmjTDj6gtuoVCD6vhqQNAkt91eBtp1WwDmF5zLPwgLex2IGCymB5dfg== X-Received: by 2002:a1c:a485:: with SMTP id n127mr1484505wme.15.1543753531176; Sun, 02 Dec 2018 04:25:31 -0800 (PST) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id l2sm11886162wma.33.2018.12.02.04.25.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Dec 2018 04:25:30 -0800 (PST) Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) To: Mogens Jensen Cc: Pierre-Louis Bossart , Dean Wallace , Andy Shevchenko , Stephen Boyd , Michael Turquette , linux-clk , Stable , Johannes Stezenbach , Carlo Caione , Andy Shevchenko , Linux Kernel Mailing List References: <20181025232517.ywnw54qibemosjws@picard> <20181030143836.feo7zcxiestylxoo@picard> <2d429c87-24c5-4075-683e-b0d12c3eb1c2@linux.intel.com> <3iO9ehQbZm_haTV0IuZ0qhsVHR0QLUbTgRJT8ZenGuRsnz2_uBvO93f0bHVYnsApibUT16JsJ0dgphLhUBd-u0t-lDBNsbvvlKWTgq8XOlw=@protonmail.com> From: Hans de Goede Message-ID: <3e12e051-b874-187d-d4f5-e146f59c659b@redhat.com> Date: Sun, 2 Dec 2018 13:25:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <3iO9ehQbZm_haTV0IuZ0qhsVHR0QLUbTgRJT8ZenGuRsnz2_uBvO93f0bHVYnsApibUT16JsJ0dgphLhUBd-u0t-lDBNsbvvlKWTgq8XOlw=@protonmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01-11-18 07:55, Mogens Jensen wrote: > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Wednesday, October 31, 2018 9:29 AM, Hans de Goede wrote: > >> Hi, >> >> On 31-10-18 07:02, Mogens Jensen wrote: >> >>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >>> On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdegoede@redhat.com wrote: >>> >>>> Hi, >>>> On 30-10-18 19:56, Mogens Jensen wrote: >>>> >>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >>>>> On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdegoede@redhat.com wrote: >>>>> >>>>>> Hi, >>>>>> On 30-10-18 16:46, Hans de Goede wrote: >>>>>> >>>>>>> Hi, >>>>>>> On 30-10-18 16:04, Pierre-Louis Bossart wrote: >>>>>>> >>>>>>>> In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking for both clocks to be on might work though, >>>>>>> >>>>>>> Ok, so we need to have a DMI based quirk for the Swanky and maybe also >>>>>>> the clapper to use plt_clk_0 there. Asking for 2 clks if we only need >>>>>>> one does not seem like a good plan. >>>>>> >>>>>> Dean, Mogens, >>>>>> To write a proper patch for this I'm going to need DMI strings >>>>>> from your devices. >>>>>> Can you please run (as normal user): >>>>>> grep . /sys/class/dmi/id/* 2> /dev/null >>>>>> And reply with the output of this command? >>>>>> I have attached the output from a coreboot seabios based clapper. >>>> >>>> Thank you. >>>> >>>>> Should I still test 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and asoundrc from Dean? There seems to have been some development in the case since that request was made. >>>> >>>> Yes please test that, I expect that to also fix things for the >>>> Clapper, but I need to have that confirmed before submitting a >>>> patch upstream adding a quirk for the Clapper to use pmc_plt_clk_0 >>>> instead of pmc_plt_clk_3. >>>> Regards, >>>> Hans >>> >>> Unfortunately I only have access to longterm kernel 4.14 for building/running on this system, and 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch does not patch against 4.14.78. Can a test patch for 4.14 be created? >> >> Can you run (as root): >> >> for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat $i/clk_flags; echo; done >> >> When running a kernel with working audio? >> >> Then I can confirm that the Clapper is also using pmc_plt_clk_0, so that I can >> fix this for the clapper for 4.18+ >> >> I've just checked the 4.14 sources and in 4.14 the SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH >> driver does not support mclk control yet, so for the 4.14 kernel the only way to >> fix this is to revert the 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") >> commit. >> >> Regards, >> >> Hans >> > Here is the output from the Clapper with 4.14.78 and working sound: > > /sys/kernel/debug/clk/pmc_plt_clk_0: 0x00000800 > /sys/kernel/debug/clk/pmc_plt_clk_1: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_2: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_3: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_4: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_5: 0x00000000 Ok, so your Clapper model indeed is also using clk 0 and not clk 3 as expected. I've just submitted a patch upstream adding a quirk for this. As for what the plan is with 4.14, I don't know. I believe that reverting the commit causing the issue there is fine. Regards, Hans